Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-17 Thread Michael Tuexen
On 16 Jun 2014, at 22:13, Mark R V Murray ma...@freebsd.org wrote: Hi Mark, I just adopted the comments to the code change. So here is the improved patch: Index: cpufunc.c === --- cpufunc.c (revision 267575) +++ cpufunc.c

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-17 Thread Mark R V Murray
Hi Michael, If that works, then Brilliant! :-) :-) Could you please fix this so the _PMC_USER_READ_WRITE_ is all in one place (it’s too dangerous to split up), and put an architecture-specific #ifdef around just the MCR instruction we care about. With that, its good to commit, I’d say. I’ll

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-17 Thread Michael Tuexen
On 17 Jun 2014, at 20:33, Mark R V Murray ma...@freebsd.org wrote: Hi Michael, If that works, then Brilliant! :-) :-) Could you please fix this so the _PMC_USER_READ_WRITE_ is all in one place (it’s too dangerous to split up), and put an architecture-specific #ifdef around just the MCR

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-17 Thread Mark R V Murray
On 17 Jun 2014, at 19:58, Michael Tuexen tue...@freebsd.org wrote: So you want something like: Yup! Looks good! :-) If you want to blame me for reviewing this, thats fine, but I’ve not run it (I’m waiting for a replacement RPI, still). Please don’t be offended if a follow-up commit of mine

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-17 Thread Michael Tuexen
On 17 Jun 2014, at 21:05, Mark R V Murray ma...@freebsd.org wrote: On 17 Jun 2014, at 19:58, Michael Tuexen tue...@freebsd.org wrote: So you want something like: Yup! Looks good! :-) If you want to blame me for reviewing this, thats fine, but I’ve not run it (I’m waiting for a

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Michael Tuexen
On 15 Jun 2014, at 17:13, Mark R V Murray ma...@freebsd.org wrote: On 30 May 2014, at 09:42, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 21:21, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:27, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Mark R V Murray
On 16 Jun 2014, at 08:28, Michael Tuexen tue...@freebsd.org wrote: your patch for accessing the value is correct. However, the initialisation code also needs to be adopted to the platform. So in addition to your patch, you also need: Thanks! Is there an easy test to see if the code

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Michael Tuexen
On 16 Jun 2014, at 19:36, Mark R V Murray ma...@freebsd.org wrote: On 16 Jun 2014, at 08:28, Michael Tuexen tue...@freebsd.org wrote: your patch for accessing the value is correct. However, the initialisation code also needs to be adopted to the platform. So in addition to your patch, you

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Mark R V Murray
On 16 Jun 2014, at 20:25, Michael Tuexen tue...@freebsd.org wrote: Should print a whole lotta numbers, incrementing, unless you hit the wraparound. Don't I need to compile a kernel with _PMC_USER_READ_WRITE_ being defined, since without it a user process can't access the register. When

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Michael Tuexen
On 16 Jun 2014, at 21:29, Mark R V Murray ma...@freebsd.org wrote: On 16 Jun 2014, at 20:25, Michael Tuexen tue...@freebsd.org wrote: Should print a whole lotta numbers, incrementing, unless you hit the wraparound. Don't I need to compile a kernel with _PMC_USER_READ_WRITE_ being defined,

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Mark R V Murray
On 16 Jun 2014, at 20:38, Michael Tuexen tue...@freebsd.org wrote: Hmm, the documentation reads Which docs are you using? I’m using DDI0360F. (And that could easily be a wrong choice). M -- Mark R V Murray ___ svn-src-head@freebsd.org mailing list

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Michael Tuexen
On 16 Jun 2014, at 22:13, Mark R V Murray ma...@freebsd.org wrote: On 16 Jun 2014, at 20:38, Michael Tuexen tue...@freebsd.org wrote: Hmm, the documentation reads Which docs are you using? I’m using DDI0360F. (And that could easily be a wrong choice). That is what I'm also looking at.

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-16 Thread Michael Tuexen
On 16 Jun 2014, at 22:41, Michael Tuexen tue...@freebsd.org wrote: On 16 Jun 2014, at 22:13, Mark R V Murray ma...@freebsd.org wrote: On 16 Jun 2014, at 20:38, Michael Tuexen tue...@freebsd.org wrote: Hmm, the documentation reads Which docs are you using? I’m using DDI0360F. (And

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-15 Thread Mark R V Murray
On 30 May 2014, at 09:42, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 21:21, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:27, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 20:15, Mark R V Murray ma...@freebsd.org wrote: On 29

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-06-15 Thread Michael Tuexen
On 15 Jun 2014, at 17:13, Mark R V Murray ma...@freebsd.org wrote: On 30 May 2014, at 09:42, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 21:21, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:27, Michael Tuexen tue...@fh-muenster.de wrote: On 29

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-30 Thread Michael Tuexen
On 29 May 2014, at 21:21, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:27, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 20:15, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:13, Michael Tuexen tue...@fh-muenster.de wrote: I can

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Hans Petter Selasky
On 05/22/14 09:09, Mark R V Murray wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083 URL: http://svnweb.freebsd.org/changeset/base/266083 Log: Give

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Mark R V Murray
On 29 May 2014, at 12:05, Hans Petter Selasky h...@selasky.org wrote: On 05/22/14 09:09, Mark R V Murray wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Michael Tuexen
On 29 May 2014, at 19:41, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 12:05, Hans Petter Selasky h...@selasky.org wrote: On 05/22/14 09:09, Mark R V Murray wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Mark R V Murray
On 29 May 2014, at 19:13, Michael Tuexen tue...@fh-muenster.de wrote: I can make it work on RPI, but trying to find what else it will/won’t work on is more problematic. Wouldn't it require to use different registers on the RPI? This would mean you would need more #ifdefs… Thats the

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Michael Tuexen
On 29 May 2014, at 20:15, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:13, Michael Tuexen tue...@fh-muenster.de wrote: I can make it work on RPI, but trying to find what else it will/won’t work on is more problematic. Wouldn't it require to use different registers on

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-29 Thread Mark R V Murray
On 29 May 2014, at 19:27, Michael Tuexen tue...@fh-muenster.de wrote: On 29 May 2014, at 20:15, Mark R V Murray ma...@freebsd.org wrote: On 29 May 2014, at 19:13, Michael Tuexen tue...@fh-muenster.de wrote: I can make it work on RPI, but trying to find what else it will/won’t work on

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-24 Thread Michael Tuexen
On 22 May 2014, at 09:09, Mark R V Murray ma...@freebsd.org wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083 URL:

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-24 Thread Andrew Turner
On Sat, 24 May 2014 21:09:56 +0200 Michael Tuexen tue...@freebsd.org wrote: On 22 May 2014, at 09:09, Mark R V Murray ma...@freebsd.org wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-24 Thread Michael Tuexen
On 24 May 2014, at 23:02, Andrew Turner and...@fubar.geek.nz wrote: On Sat, 24 May 2014 21:09:56 +0200 Michael Tuexen tue...@freebsd.org wrote: On 22 May 2014, at 09:09, Mark R V Murray ma...@freebsd.org wrote: On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-22 Thread Mark R V Murray
On 21 May 2014, at 21:15, Hans Petter Selasky h...@selasky.org wrote: On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083 URL: http://svnweb.freebsd.org/changeset/base/266083 Log: Give suitably-endowed ARMs a register similar to the

Re: svn commit: r266083 - in head/sys/arm: arm include

2014-05-21 Thread Hans Petter Selasky
On 05/14/14 21:11, Mark Murray wrote: Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083 URL: http://svnweb.freebsd.org/changeset/base/266083 Log: Give suitably-endowed ARMs a register similar to the x86 TSC register. Hi, Regression issue: This commit prevents RPI-B from

svn commit: r266083 - in head/sys/arm: arm include

2014-05-14 Thread Mark Murray
Author: markm Date: Wed May 14 19:11:15 2014 New Revision: 266083 URL: http://svnweb.freebsd.org/changeset/base/266083 Log: Give suitably-endowed ARMs a register similar to the x86 TSC register. Here, suitably endowed means that the System Control Coprocessor (#15) has Performance