Re: svn commit: r317277 - head/sys/crypto/chacha20

2017-04-21 Thread Colin Percival
On 04/21/17 19:33, Rui Paulo wrote: > On Apr 21, 2017, at 18:06, Dag-Erling Smørgrav wrote: >> Author: des >> Date: Sat Apr 22 01:06:23 2017 >> New Revision: 317277 >> URL: https://svnweb.freebsd.org/changeset/base/317277 >> >> Log: >> Fix counter increment in Salsa and ChaCha.

Re: svn commit: r317277 - head/sys/crypto/chacha20

2017-04-21 Thread Rui Paulo
On Apr 21, 2017, at 18:06, Dag-Erling Smørgrav wrote: > > Author: des > Date: Sat Apr 22 01:06:23 2017 > New Revision: 317277 > URL: https://svnweb.freebsd.org/changeset/base/317277 > > Log: > Fix counter increment in Salsa and ChaCha. > > In my eagerness to eliminate a

svn commit: r317277 - head/sys/crypto/chacha20

2017-04-21 Thread Dag-Erling Smørgrav
Author: des Date: Sat Apr 22 01:06:23 2017 New Revision: 317277 URL: https://svnweb.freebsd.org/changeset/base/317277 Log: Fix counter increment in Salsa and ChaCha. In my eagerness to eliminate a branch which is taken once per 2^38 bytes of keystream, I forgot that the state words are