Re: svn commit: r357028 - head/sys/vm

You may be asking yourself, why did jeff just squish a bunch of code around with little functional change. I could not justify adding more complexity to a 900 line function with a handful of gotos. It is ~300 lines now. I tested the whole set together. I apologize if there are bugs.

svn commit: r357028 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:23:37 2020 New Revision: 357028 URL: https://svnweb.freebsd.org/changeset/base/357028 Log: (fault 9/9) Move zero fill into a dedicated function to make the object lock state more clear. Reviewed by: kib Differential Revision:

svn commit: r357027 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:22:02 2020 New Revision: 357027 URL: https://svnweb.freebsd.org/changeset/base/357027 Log: (fault 8/9) Restructure some code to reduce duplication and simplify flow control. Reviewed by: dougm, kib, markj Differential Revision:

svn commit: r357026 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:19:39 2020 New Revision: 357026 URL: https://svnweb.freebsd.org/changeset/base/357026 Log: (fault 7/9) Move fault population and allocation into a dedicated function Reviewed by: kib Differential Revision:https://reviews.freebsd.org/D23320

svn commit: r357025 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:18:00 2020 New Revision: 357025 URL: https://svnweb.freebsd.org/changeset/base/357025 Log: (fault 6/9) Move getpages and associated logic into a dedicated function. Reviewed by: kib Differential Revision:https://reviews.freebsd.org/D23311

svn commit: r357024 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:14:41 2020 New Revision: 357024 URL: https://svnweb.freebsd.org/changeset/base/357024 Log: (fault 5/9) Move the backing_object traversal into a dedicated function. Reviewed by: dougm, kib, markj Differential Revision:

svn commit: r357023 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:11:01 2020 New Revision: 357023 URL: https://svnweb.freebsd.org/changeset/base/357023 Log: (fault 4/9) Move copy-on-write into a dedicated function. Reviewed by: kib, markj Differential Revision:https://reviews.freebsd.org/D23304 Modified:

svn commit: r357022 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:07:01 2020 New Revision: 357022 URL: https://svnweb.freebsd.org/changeset/base/357022 Log: (fault 3/9) Move map relookup into a dedicated function. Add a new VM return code KERN_RESTART which means, deallocate and restart in fault. Reviewed by: kib,

svn commit: r357021 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:05:39 2020 New Revision: 357021 URL: https://svnweb.freebsd.org/changeset/base/357021 Log: (fault 2/9) Move map lookup into a dedicated function. Reviewed by: kib, markj Differential Revision:https://reviews.freebsd.org/D23302 Modified:

svn commit: r357020 - head/sys/vm

Author: jeff Date: Thu Jan 23 05:03:34 2020 New Revision: 357020 URL: https://svnweb.freebsd.org/changeset/base/357020 Log: (fault 1/9) Move a handful of stack variables into the faultstate. This additionally fixes a potential bug/pessimization where we could fail to reload the original

svn commit: r357019 - head/sys/vm

Author: rlibby Date: Thu Jan 23 04:56:38 2020 New Revision: 357019 URL: https://svnweb.freebsd.org/changeset/base/357019 Log: uma: fix zone domain overlaying pcpu cache with disabled cpus UMA zone structures have two arrays at the end which are sized according to the machine: an array of

svn commit: r357018 - head/sys/vm

Author: rlibby Date: Thu Jan 23 04:56:34 2020 New Revision: 357018 URL: https://svnweb.freebsd.org/changeset/base/357018 Log: uma: report leaks more accurately Previously UMA had some false negatives in the leak report at keg destruction time, where it only reported leaks if there were

svn commit: r357017 - in head/sys: dev/spibus kern vm

Author: jeff Date: Thu Jan 23 04:54:49 2020 New Revision: 357017 URL: https://svnweb.freebsd.org/changeset/base/357017 Log: Consistently use busy and vm_page_valid() rather than touching page bits directly. This improves API compliance, asserts, etc. Reviewed by: kib, markj

svn commit: r357016 - head/sys/x86/cpufreq

Author: cy Date: Thu Jan 23 03:38:41 2020 New Revision: 357016 URL: https://svnweb.freebsd.org/changeset/base/357016 Log: Fix 32-bit build post r357002. Modified: head/sys/x86/cpufreq/hwpstate_intel.c Modified: head/sys/x86/cpufreq/hwpstate_intel.c

svn commit: r357015 - head/sys/vm

Author: jeff Date: Thu Jan 23 03:37:35 2020 New Revision: 357015 URL: https://svnweb.freebsd.org/changeset/base/357015 Log: Some architectures with DMAP still consume boot kva. Simplify the test for claiming kva in uma_startup2() to handle this. Reported by: bdragon Modified:

svn commit: r357014 - head/sys/kern

Author: jeff Date: Thu Jan 23 03:36:50 2020 New Revision: 357014 URL: https://svnweb.freebsd.org/changeset/base/357014 Log: Block the thread lock in sched_throw() and use cpu_switch() to unblock it. The introduction of lockless switch in r355784 created a race to re-use the exiting thread

Re: svn commit: r356919 - head/sys/x86/x86

On Mon, Jan 20, 2020 at 9:23 AM Konstantin Belousov wrote: > > Author: kib > Date: Mon Jan 20 17:23:03 2020 > New Revision: 356919 > URL: https://svnweb.freebsd.org/changeset/base/356919 > > Log: > x86: Wait for curthread to be set up as an indicator that the boot stack > is no longer used. >

svn commit: r357013 - head/sys/net

Author: glebius Date: Thu Jan 23 01:49:22 2020 New Revision: 357013 URL: https://svnweb.freebsd.org/changeset/base/357013 Log: Since now drivers that support pfil run their interrupts in the network epoch, stop entering it in pfil_run_hooks(). Assert the epoch there. Modified:

svn commit: r357012 - head/sys/net

Author: glebius Date: Thu Jan 23 01:47:43 2020 New Revision: 357012 URL: https://svnweb.freebsd.org/changeset/base/357012 Log: Stop entering the network epoch in ether_input(), unless driver is marked with IFF_NEEDSEPOCH. Modified: head/sys/net/if_ethersubr.c Modified:

svn commit: r357011 - head/sys/powerpc/pseries

Author: glebius Date: Thu Jan 23 01:46:05 2020 New Revision: 357011 URL: https://svnweb.freebsd.org/changeset/base/357011 Log: This is Ethernet driver so mark the interrupt appropriately. Modified: head/sys/powerpc/pseries/phyp_llan.c Modified: head/sys/powerpc/pseries/phyp_llan.c

Re: svn commit: r357010 - in head/sys: dev/altera/atse dev/beri/virtio/network dev/dpaa dev/hyperv/netvsc dev/if_ndis dev/ntb/if_ntb dev/sbni dev/xen/netback mips/nlm/dev/net net

On Thu, Jan 23, 2020 at 01:41:10AM +, Gleb Smirnoff wrote: T> Log: T> Introduce flag IFF_NEEDSEPOCH that marks Ethernet interfaces that T> supposedly may call into ether_input() without network epoch. T> T> They all need to be reviewed before 13.0-RELEASE. Some may need T> be

svn commit: r357010 - in head/sys: dev/altera/atse dev/beri/virtio/network dev/dpaa dev/hyperv/netvsc dev/if_ndis dev/ntb/if_ntb dev/sbni dev/xen/netback mips/nlm/dev/net net

Author: glebius Date: Thu Jan 23 01:41:09 2020 New Revision: 357010 URL: https://svnweb.freebsd.org/changeset/base/357010 Log: Introduce flag IFF_NEEDSEPOCH that marks Ethernet interfaces that supposedly may call into ether_input() without network epoch. They all need to be reviewed

svn commit: r357009 - head/sys/net

Author: glebius Date: Thu Jan 23 01:38:51 2020 New Revision: 357009 URL: https://svnweb.freebsd.org/changeset/base/357009 Log: tap(4) calls ether_input() in context of write(2). Enter network epoch here. The tun(4) side doesn't need this, as netisr code will take care. Modified:

svn commit: r357008 - head/sys/dev/netmap

Author: glebius Date: Thu Jan 23 01:35:02 2020 New Revision: 357008 URL: https://svnweb.freebsd.org/changeset/base/357008 Log: In netmap() call ether_input() within the network epoch. Modified: head/sys/dev/netmap/netmap.c Modified: head/sys/dev/netmap/netmap.c

svn commit: r357007 - head/sys/kern

Author: glebius Date: Thu Jan 23 01:30:50 2020 New Revision: 357007 URL: https://svnweb.freebsd.org/changeset/base/357007 Log: DEVICE_POLLING is an alternative to network interrupts and also needs to enter epoch. Assert that in the netisr_poll() and do the work for the idle poll routine.

svn commit: r357006 - head/sys/net

Author: glebius Date: Thu Jan 23 01:27:58 2020 New Revision: 357006 URL: https://svnweb.freebsd.org/changeset/base/357006 Log: Enter network epoch in iflib rxeof task. In upcoming changes ether_input() is going to be changed not to enter the network epoch. It is going to be

svn commit: r357005 - head/sys/net

Author: glebius Date: Thu Jan 23 01:25:32 2020 New Revision: 357005 URL: https://svnweb.freebsd.org/changeset/base/357005 Log: Mark swi_net() as INTR_TYPE_NET and stop entering epoch there. Modified: head/sys/net/netisr.c Modified: head/sys/net/netisr.c

svn commit: r357004 - in head/sys: kern sys

Author: glebius Date: Thu Jan 23 01:24:47 2020 New Revision: 357004 URL: https://svnweb.freebsd.org/changeset/base/357004 Log: Enter the network epoch for interrupt handlers of INTR_TYPE_NET. Provide tunable to limit how many times handlers may be executed without reentering epoch.

svn commit: r357003 - in head/sys: kern sys

Author: glebius Date: Thu Jan 23 01:20:59 2020 New Revision: 357003 URL: https://svnweb.freebsd.org/changeset/base/357003 Log: Add ie_hflags to struct intr_event, which accumulates flags from all handlers on this event. For now handle only IH_ENTROPY in that manner. Modified:

Re: svn commit: r356989 - head/sys/netinet

Hi Michael, On Wed, Jan 22, 2020 at 10:20:55PM +0100, Michael Tuexen wrote: M> > Log: M> > Plug possible calls into ip6?_output() without network epoch from SCTP M> > bluntly adding epoch entrance into the macro that SCTP uses to call M> > ip6?_output(). This definitely will introduce

svn commit: r357002 - in head: share/man/man4 sys/conf sys/kern sys/modules/cpufreq sys/sys sys/x86/cpufreq

Author: cem Date: Wed Jan 22 23:28:42 2020 New Revision: 357002 URL: https://svnweb.freebsd.org/changeset/base/357002 Log: cpufreq(4): Add support for Intel Speed Shift Intel Speed Shift is Intel's technology to control frequency in hardware, with hints from software. Let's get a

svn commit: r356996 - head

Author: jhb Date: Wed Jan 22 21:21:24 2020 New Revision: 356996 URL: https://svnweb.freebsd.org/changeset/base/356996 Log: Remove support for auto-selecting an external binutils. All of the in-tree architectures not supported by in-tree binutils are supported by lld, so the condition is

Re: svn commit: r356989 - head/sys/netinet

> On 22. Jan 2020, at 18:19, Gleb Smirnoff wrote: > > Author: glebius > Date: Wed Jan 22 17:19:53 2020 > New Revision: 356989 > URL: https://svnweb.freebsd.org/changeset/base/356989 > > Log: > Plug possible calls into ip6?_output() without network epoch from SCTP > bluntly adding epoch

Re: svn commit: r356993 - head/sys/net

22.01.2020, 21:02, "Alexander Motin" : > On 22.01.2020 15:59, Alexander V. Chernikov wrote: >>  22.01.2020, 20:36, "Alexander Motin" : >>>  Author: mav >>>  Date: Wed Jan 22 20:36:45 2020 >>>  New Revision: 356993 >>>  URL: https://svnweb.freebsd.org/changeset/base/356993 >>> >>>  Log: >>>    

Re: svn commit: r356993 - head/sys/net

On 22.01.2020 15:59, Alexander V. Chernikov wrote: > 22.01.2020, 20:36, "Alexander Motin" : >> Author: mav >> Date: Wed Jan 22 20:36:45 2020 >> New Revision: 356993 >> URL: https://svnweb.freebsd.org/changeset/base/356993 >> >> Log: >>   Update route MTUs for bridge, lagg and vlan interfaces. >>

svn commit: r356995 - head/sys/netpfil/pf

Author: kp Date: Wed Jan 22 21:01:19 2020 New Revision: 356995 URL: https://svnweb.freebsd.org/changeset/base/356995 Log: pfsync: Ensure we enter network epoch before calling ip_output As of r356974 calls to ip_output() require us to be in the network epoch. That wasn't the case for the

Re: svn commit: r356993 - head/sys/net

22.01.2020, 20:36, "Alexander Motin" : > Author: mav > Date: Wed Jan 22 20:36:45 2020 > New Revision: 356993 > URL: https://svnweb.freebsd.org/changeset/base/356993 > > Log: >   Update route MTUs for bridge, lagg and vlan interfaces. > >   Those interfaces may implicitly change their MTU on

svn commit: r356994 - head/include

Author: kevans Date: Wed Jan 22 20:53:25 2020 New Revision: 356994 URL: https://svnweb.freebsd.org/changeset/base/356994 Log: Mark rfork(2) as __returns_twice rfork is not generally a built-in that would be recognized as behaving like vfork/fork; provide the hint. Modified:

svn commit: r356993 - head/sys/net

Author: mav Date: Wed Jan 22 20:36:45 2020 New Revision: 356993 URL: https://svnweb.freebsd.org/changeset/base/356993 Log: Update route MTUs for bridge, lagg and vlan interfaces. Those interfaces may implicitly change their MTU on addition of parent interface in addition to normal

svn commit: r356991 - head/share/termcap

Author: emaste Date: Wed Jan 22 18:55:36 2020 New Revision: 356991 URL: https://svnweb.freebsd.org/changeset/base/356991 Log: Tag etc/termcap with package=runtime /etc/termcap is a symlink to /usr/share/misc/termcap, which is in the runtime package. Tag the symlink with the same package

svn commit: r356990 - head/etc

Author: emaste Date: Wed Jan 22 18:40:19 2020 New Revision: 356990 URL: https://svnweb.freebsd.org/changeset/base/356990 Log: Tag NLS aliases with package=runtime POSIX and en_US.US_ASCII are aliases (symlinks) to the C locale. They were not previously tagged with a pkgbase pacakge.

svn commit: r356989 - head/sys/netinet

Author: glebius Date: Wed Jan 22 17:19:53 2020 New Revision: 356989 URL: https://svnweb.freebsd.org/changeset/base/356989 Log: Plug possible calls into ip6?_output() without network epoch from SCTP bluntly adding epoch entrance into the macro that SCTP uses to call ip6?_output(). This

svn commit: r356988 - head/sys/netinet6

Author: glebius Date: Wed Jan 22 17:06:55 2020 New Revision: 356988 URL: https://svnweb.freebsd.org/changeset/base/356988 Log: Enter network epoch when calling in_pcbconnect() for IPv6 mapped to IPv4 UDP sockets. This is miss from r356983. Reported by:

Re: svn commit: r356983 - head/sys/netinet

On Wed, Jan 22, 2020 at 06:10:41AM +, Gleb Smirnoff wrote: > Author: glebius > Date: Wed Jan 22 06:10:41 2020 > New Revision: 356983 > URL: https://svnweb.freebsd.org/changeset/base/356983 > > Log: > Make in_pcbladdr() require network epoch entered by its callers. Together > with this

svn commit: r356986 - head/sys/netinet

Author: bz Date: Wed Jan 22 15:06:59 2020 New Revision: 356986 URL: https://svnweb.freebsd.org/changeset/base/356986 Log: Fix NOINET kernels after r356983. All gotos to the label are within the #ifdef INET section, which leaves us with an unused label. Cover the label under #ifdef INET

svn commit: r356985 - head/etc

Author: kevans Date: Wed Jan 22 14:07:27 2020 New Revision: 356985 URL: https://svnweb.freebsd.org/changeset/base/356985 Log: Tag os-release symlink with package=runtime This ensures it gets into pkgbase-(installed/updated) systems. Modified: head/etc/Makefile Modified:

svn commit: r356984 - in head: sys/conf sys/net sys/netinet sys/netinet6 tests/sys/net/routing tests/sys/netinet tests/sys/netinet6

Author: melifaro Date: Wed Jan 22 13:53:18 2020 New Revision: 356984 URL: https://svnweb.freebsd.org/changeset/base/356984 Log: Bring back redirect route expiration. Redirect (and temporal) route expiration was broken a while ago. This change brings route expiration back, with unified