Author: glebius
Date: Tue Nov 28 19:18:00 2017
New Revision: 326338
URL: https://svnweb.freebsd.org/changeset/base/326338
Log:
Fix obvious NULL pointer dereference from r310350.
Modified:
head/usr.sbin/syslogd/syslogd.c
Modified: head/usr.sbin/syslogd/syslogd.c
lock was causing this issue).
M>
M> Best regards,
M> Michal
M>
M> 2017-11-22 1:08 GMT+01:00 Gleb Smirnoff <gleb...@freebsd.org>:
M>
M> > Hi Martin and Michal,
M> >
M> > On Tue, Oct 31, 2017 at 04:31:23PM +, Marcin Wojtas wrote:
M> > M> Aut
OREACH() works before AP startup, with
one iteration - the BSP. Now I achieve that with this hack:
https://github.com/glebius/FreeBSD/commit/834b857464972b45e659f99fa2dd91e987b17dc9
Can you please suggest a better way to do that?
--
Gleb Smirnoff
___
_get_counter() or a sysctl is called?
That would be more efficient.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: glebius
Date: Mon Nov 13 22:16:47 2017
New Revision: 325782
URL: https://svnweb.freebsd.org/changeset/base/325782
Log:
Style r320614: don't initialize at declaration, new line after declarations,
shorten variable name to avoid extra long lines.
No functional changes.
Modified:
Author: glebius
Date: Wed Nov 8 16:45:53 2017
New Revision: 325558
URL: https://svnweb.freebsd.org/changeset/base/325558
Log:
When parsing UDP messages skip optional hostname as described by
RFC 3164.
PR: 200933
Submitted by: maxim
Reported by: Konstantin Pavlov
MFC
Author: glebius
Date: Thu Dec 7 22:36:58 2017
New Revision: 326673
URL: https://svnweb.freebsd.org/changeset/base/326673
Log:
Separate out send buffer autoscaling code into function, so that
alternative TCP stacks may reuse it instead of pasting.
Obtained from:Netflix
Modified:
Author: glebius
Date: Tue Dec 5 19:55:53 2017
New Revision: 326574
URL: https://svnweb.freebsd.org/changeset/base/326574
Log:
Generate fully RFC3164 compliant messages, with timestamp and hostname.
Allow to set hostname to any string with -H.
MFC after:2 months
Modified:
Author: glebius
Date: Tue Dec 5 19:54:55 2017
New Revision: 326573
URL: https://svnweb.freebsd.org/changeset/base/326573
Log:
When parsing remote messages, require them to have standard timestamp
field, and support properly parse out the hostname as described by RFC3164,
which wasn't done
Author: glebius
Date: Wed Dec 6 00:44:49 2017
New Revision: 326608
URL: https://svnweb.freebsd.org/changeset/base/326608
Log:
Fix file missed in r326607.
Modified:
head/sys/fs/tmpfs/tmpfs_fifoops.c
Modified: head/sys/fs/tmpfs/tmpfs_fifoops.c
Author: glebius
Date: Wed Dec 6 00:42:08 2017
New Revision: 326607
URL: https://svnweb.freebsd.org/changeset/base/326607
Log:
Reduce pollution via tmpfs.h.
Modified:
head/sys/fs/tmpfs/tmpfs.h
head/sys/fs/tmpfs/tmpfs_subr.c
head/sys/fs/tmpfs/tmpfs_vfsops.c
pt/src/svn-current/usr.bin/logger/logger.c:186
C> (gdb)
Mea culpa! Can you please test the attached patch?
--
Gleb Smirnoff
Index: logger.c
===
--- logger.c (revision 326614)
+++ logger.c (working copy)
@@ -183,7 +183,7 @@ main(i
On Wed, Dec 06, 2017 at 06:11:56PM +, Ed Maste wrote:
E> Author: emaste
E> Date: Wed Dec 6 18:11:56 2017
E> New Revision: 326628
E> URL: https://svnweb.freebsd.org/changeset/base/326628
E>
E> Log:
E> tcpdump: remove undesired svn:keywords property from contrib
Thank
Author: glebius
Date: Wed Dec 6 17:50:10 2017
New Revision: 326625
URL: https://svnweb.freebsd.org/changeset/base/326625
Log:
Fix crash with a dotless hostname.
Modified:
head/usr.bin/logger/logger.c
Modified: head/usr.bin/logger/logger.c
Author: glebius
Date: Wed Dec 6 23:03:34 2017
New Revision: 326642
URL: https://svnweb.freebsd.org/changeset/base/326642
Log:
Garbage collect IFCAP_POLLING_NOCOUNT. It wasn't used since very
beginning of polling(4). The module always ignored return value
from driver polling handler.
ash _later_ than production kernels,
since instead of uma_junk it places clean zeroes.
May be changes like that deserve more than a 30 minute time frame for review?
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/ma
M> nios = 0;
M> +npages = 0;
M> goto prepend_header;
M> }
M> hdr_uio = NULL;
This initialization is redundant and a compiler warning if exists is
The initialization isn't useful.
On Wed, May 23, 2018 at 03:52:42PM -0700, Matthew Macy wrote:
M> Talk to the gcc devs. The warning is useful even if there are false
positives.
M>
M> On Wed, May 23, 2018 at 3:27 PM, Gleb Smirnoff <gleb...@freebsd.org> wrote:
M> > Hi,
M&g
If you want to _actually_ be helpful fix these:
M> https://people.freebsd.org/~mmacy/gcc8logs/GENERIC-NODEBUG.log
M>
M> https://people.freebsd.org/~mmacy/gcc8logs/GENERIC.log
M>
M> On Wed, May 23, 2018 at 9:42 PM, Gleb Smirnoff <gleb...@freebsd.org> wrote:
M> > Let me repeat
On Wed, May 23, 2018 at 10:13:25PM -0700, Matthew Macy wrote:
M> On Wed, May 23, 2018 at 10:07 PM, Gleb Smirnoff <gleb...@freebsd.org> wrote:
M> > Can you please explain the bug supposed to be fixed by r333860 QUESTION
MARK
M>
M> Did I say it fixed a bug? Or are you sayin
with
a comment /* pacify gcc */.
On Wed, May 23, 2018 at 03:59:33PM -0700, Matthew Macy wrote:
M> On Wed, May 23, 2018 at 3:57 PM, Gleb Smirnoff <gleb...@freebsd.org> wrote:
M> > The initialization isn't useful.
M>
M> It silences a gcc warning. So yes it is. It's this exchange
76b.
O> This brings us the renaming of fields in ck_queue, so that our own
O> LIST/SLIST/TAILQ/etc won't accidentally work with them.
Indeed, this broke kernel build :)
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.f
0Mbit, 100Mbit 10+ year old drivers from the kernel?
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
It is positive feedback like this which
M> keeps me going!
Btw, what was the point of checking flags || result? Most places in kernel
ignore flags and just test result regerdless of M_WAITOK/M_NOWAIT.
The result is already in a register, why do you think checking for absense
of M_WAITOK is faster th
t compilation time. If they
M> contain
M> M_WAITOK, the flag check will get elided along (we know for a fact it
M> passes)
M> and subsequently the NULL check will be short circuited, iow for known
M> M_WAITOK|M_ZERO flags this is:
M>
M> _malloc_item = malloc(_size, type, fla
plementation?
K>
K> Or 'sample frequency'
Interval definitely doesn't fit here. Frequency is closer, but still not the
right term, IMHO. Native speaker required here to judge. I am okay if anyone
who is confident changes wording here.
--
Gleb Smirnoff
__
yet fix the problem. This won't
happen if commit was reviewed.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: glebius
Date: Thu Jun 14 22:25:10 2018
New Revision: 335180
URL: https://svnweb.freebsd.org/changeset/base/335180
Log:
TCPOUTFLAGS no longer exists since r334843.
Modified:
head/sys/netinet/tcp_hpts.c
head/sys/netinet/tcp_offload.c
head/sys/netinet/tcp_output.c
M> - non NULL controlp is not an error, returning EINVAL
M> would cause X forwarding to fail
Can you please provide reference for a code that uses
control messages with a stream socket?
The removed return was in action since FreeBSD 7.0 and
everything with X forwarding was work
Author: glebius
Date: Fri Jun 15 21:36:16 2018
New Revision: 335242
URL: https://svnweb.freebsd.org/changeset/base/335242
Log:
Since 'ticks' is an int, it may wrap around and cr_ticks at a certain
counter_rate will be greater than ticks, resulting in counter_ratecheck()
failure. To fix this
Author: glebius
Date: Fri Jun 8 00:15:08 2018
New Revision: 334819
URL: https://svnweb.freebsd.org/changeset/base/334819
Log:
UMA memory debugging enabled with INVARIANTS consists of two things:
trashing freed memory and checking that allocated memory is properly
trashed, and also of
Author: glebius
Date: Thu Jun 7 22:38:40 2018
New Revision: 334817
URL: https://svnweb.freebsd.org/changeset/base/334817
Log:
Add new functionality and syntax to cron(1) to allow to run jobs at a
given interval, which is counted in seconds since exit of the previous
invocation of the job.
Author: glebius
Date: Tue May 29 21:45:15 2018
New Revision: 334356
URL: https://svnweb.freebsd.org/changeset/base/334356
Log:
Revert second chunk of r333860. The warning from gcc is false positive. The
npages won't be ever used in no space case.
Modified:
head/sys/kern/kern_sendfile.c
ute path? e.g. kern.corefile=/var/log/cores/%N.core
Looks like the vn_fullpath_global needs to be fixed rather than problem
workarounded.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-h
Author: glebius
Date: Wed Jun 27 22:00:50 2018
New Revision: 335748
URL: https://svnweb.freebsd.org/changeset/base/335748
Log:
Correct r335242. Use unsigned cast instead of abs(). Using abs() gives
incorrect result when ticks has already wrapped, and are about to reach
the cr_ticks value
Author: glebius
Date: Wed Jun 27 22:01:59 2018
New Revision: 335749
URL: https://svnweb.freebsd.org/changeset/base/335749
Log:
Check the inp_flags under inp lock. Looks like the race was hidden
before, the conversion of tcbinfo to CK_LIST have uncovered it.
Modified:
Author: glebius
Date: Sat Jun 23 06:53:53 2018
New Revision: 335577
URL: https://svnweb.freebsd.org/changeset/base/335577
Log:
Revert r334843, and partially revert r335180.
tcp_outflags[] were defined since 4BSD and are defined nowadays in
all its descendants. Removing them breaks third
_mtx, "gmountver", NULL, MTX_RECURSE);
MTX_RECURSE is a flag not a type, should be:
mtx_init(>sc_mtx, "gmountver", NULL, MTX_DEF | MTX_RECURSE);
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: glebius
Date: Fri Jan 5 20:21:46 2018
New Revision: 327596
URL: https://svnweb.freebsd.org/changeset/base/327596
Log:
In sendfile_iodone() both pru_abort and sorele need to be executed
with proper VNET context set.
Reported by: sbruno
MFC after:2 weeks
Modified:
gt;
K> return (pf_release_state(s));
K> }
IMHO, we shouldn't emit extra code to please Coverity. We can mark it
as a false positive in the interface. It may make sense to add a comment
for a human to explain why return isn't checked here.
--
Gleb Smirnoff
_
On Thu, Jan 25, 2018 at 11:16:23AM +1100, Kristof Provost wrote:
K> On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote:
K> > On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote:
K> > K> Author: kp
K> > K> Date: Wed Jan 24 04:29:16 2018
K> > K> New
===
M> --- head/sys/dev/etherswitch/ukswitch/ukswitch.c Wed Jan 24 21:26:01
2018 (r328376)
M> +++ head/sys/dev/etherswitch/ukswitch/ukswitch.c Wed Jan 24 21:33:18
2018(r328377)
M> @@ -126,6 +126,12 @@ ukswitch_attach_phys(struct ukswitch_softc *sc)
M>
xunbusy(ma[i]);
Yeah, style is sacred, but is there a single person on Earth who would
not agree that moving variables from smaller blocks to function block
reduces readability of the code?
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
ut this seems to be a lesser evil when
dealing with old code that has multiple dependencies.
New code needs to be written in a fashion that clearly separates kernel
structures from user visible structures, so that no tricks with preprocessor
are needed.
--
Gleb Smirnoff
.
Yes, this is one of the dirties parts of pf. The whole API to read and configure
tables from the userland calls to be rewritten from scratch. Conversion from
malloc to mallocarray really does nothing. Better just put a maximum value
cap.
--
Gleb Smirnoff
n: freebsd-current
Sorry if my question is too lame and late. Why can't you use ktr(4) tracer
for that purpose? The discussion on freebsd-current also doesn't have answer.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freeb
On Thu, Jan 25, 2018 at 02:46:14PM +1100, Kristof Provost wrote:
K> On 25 Jan 2018, at 12:08, Kristof Provost wrote:
K> > On 25 Jan 2018, at 11:34, Ian Lepore wrote:
K> >> On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote:
K> >>> (r328313)
K> >>
Author: glebius
Date: Tue Feb 6 04:16:00 2018
New Revision: 328916
URL: https://svnweb.freebsd.org/changeset/base/328916
Log:
Followup on r302393 by cperciva, improving calculation of boot pages required
for UMA startup.
o Introduce another stage of UMA startup, which is entered after
Author: glebius
Date: Wed Feb 7 18:32:51 2018
New Revision: 328982
URL: https://svnweb.freebsd.org/changeset/base/328982
Log:
Fix three miscalculations in amount of boot pages:
o Most of startup zones have struct uma_slab embedded into the slab,
so provide macro UMA_SLAB_SPACE and use
Author: glebius
Date: Fri Feb 9 04:45:39 2018
New Revision: 329058
URL: https://svnweb.freebsd.org/changeset/base/329058
Log:
Fix boot_pages exhaustion on machines with many domains and cores, where
size of UMA zone allocation is greater than page size. In this case zone
of zones can not
; >mp_ncpus. Use resulting number not only in the size argument to
zone_ctor()
A> >but also as args.size.
A>
A> With this I’m getting "panic: UMA: Increase vm.boot_pages” on an arm64
simulator with 4GB of memory. I can increase vm.boot_pages manually, however
this is
uickly add a one line change
to subversion that would bump boot_pages value to arbitrary +100,
to fixup the head while I'm working on a proper fix?
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo
Author: glebius
Date: Tue Feb 6 22:08:43 2018
New Revision: 328953
URL: https://svnweb.freebsd.org/changeset/base/328953
Log:
Improve DIAGNOSTIC printf. Report using a boot page every time regardless
of booted status.
Modified:
head/sys/vm/uma_core.c
Modified: head/sys/vm/uma_core.c
Peter,
can you please check post r328952 kernel?
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: glebius
Date: Tue Feb 6 22:13:40 2018
New Revision: 328955
URL: https://svnweb.freebsd.org/changeset/base/328955
Log:
Use correct arithmetic to calculate how many pages we need for kegs
and hashes. There is no functional change with current sizes.
Modified:
head/sys/vm/uma_core.c
On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote:
T> Hi Peter,
T>
T> can you please try this patch? In either case success
T> or not, please provide me with dmesg. Thanks a lot!
Sorry, patch was missing one file. 99.9% this is a no-op,
but better use full patc
Author: glebius
Date: Tue Feb 6 22:06:59 2018
New Revision: 328952
URL: https://svnweb.freebsd.org/changeset/base/328952
Log:
Fix boot_pages calculation for machines that don't have UMA_MD_SMALL_ALLOC.
o Call uma_startup1() after initializing kmem, vmem and domains.
o Include 8 eight VM
Hi Peter,
can you please try this patch? In either case success
or not, please provide me with dmesg. Thanks a lot!
--
Gleb Smirnoff
Index: uma_core.c
===
--- uma_core.c (revision 328955)
+++ uma_core.c (working copy)
@@ -96,6
On Tue, Feb 06, 2018 at 11:52:44PM +0100, Peter Holm wrote:
P> On Tue, Feb 06, 2018 at 02:15:55PM -0800, Gleb Smirnoff wrote:
P> > Peter,
P> >
P> > can you please check post r328952 kernel?
P> >
P>
P> Sure.
P>
P> FreeBSD 12.0-CURRENT #0 r328956: Tue
On Wed, Feb 07, 2018 at 07:46:17AM +0100, Peter Holm wrote:
P> On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote:
P> > On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote:
P> > T> Hi Peter,
P> > T>
P> > T> can you please try this
On Wed, Feb 07, 2018 at 08:46:19AM -0800, Gleb Smirnoff wrote:
T> On Wed, Feb 07, 2018 at 07:46:17AM +0100, Peter Holm wrote:
T> P> On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote:
T> P> > On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote:
T> P> &g
ming virtual addresses.
Thanks for this change. After it the anonymous unions in xinpcb, unpxb
are no longer needed. Do you agree? I added them to make sizes on
32-bit and 64-bit ABIs to be identical. I prefer your new code,
but didn't the unions work? Anyway, now they can be removed.
--
Gleb Smirnoff
__
Author: glebius
Date: Sat Aug 4 00:03:21 2018
New Revision: 337279
URL: https://svnweb.freebsd.org/changeset/base/337279
Log:
Now that after r335979 the kernel addresses in API structures are
fixed size, there is no reason left for the unions.
Discussed with: brooks
Modified:
Since this has been broken already several times as people who edit
surrounding code don't understand the magic, and since now we round
the struct pcpu size to PAGE_SIZE anyways, what about stop carefully
craft the padding and just change alignment of st
background school girl laughing: bob
For FreeBSD it would also make sense to bump hash sizes along with this change.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Author: glebius
Date: Fri Aug 3 22:55:58 2018
New Revision: 337278
URL: https://svnweb.freebsd.org/changeset/base/337278
Log:
Use if_tunnel_check_nesting() for ng_iface(4).
Modified:
head/sys/netgraph/ng_iface.c
head/sys/netgraph/ng_iface.h
Modified: head/sys/netgraph/ng_iface.c
On Sat, Aug 04, 2018 at 10:48:17AM +0300, Konstantin Belousov wrote:
K> On Fri, Aug 03, 2018 at 03:27:39PM -0700, Gleb Smirnoff wrote:
K> > Hi Konstantin,
K> >
K> > On Fri, Jul 06, 2018 at 07:50:44PM +, Konstantin Belousov wrote:
K> > K> Author: kib
K> >
E> int soopt_getm(struct sockopt *sopt, struct mbuf **mp);
E> int soopt_mcopyin(struct sockopt *sopt, struct mbuf *m);
E> int soopt_mcopyout(struct sockopt *sopt, struct mbuf *m);
This comment was a good mark to note that these three functions
need to go away. But IPv6 still uses them.
Author: glebius
Date: Thu Aug 23 23:24:28 2018
New Revision: 338284
URL: https://svnweb.freebsd.org/changeset/base/338284
Log:
Fix comment. The actual meaning of ub_cnt is the opposite.
Modified:
head/sys/vm/uma_int.h
Modified: head/sys/vm/uma_int.h
Author: glebius
Date: Fri Aug 24 18:47:50 2018
New Revision: 338302
URL: https://svnweb.freebsd.org/changeset/base/338302
Log:
Either "free" or "allocated" is misleading here, since an item
in a bucket is free from perspective of UMA consumer, and it is
allocated from perspective of keg.
t
N> +vlan_pcp(struct ifnet *ifp, uint16_t *pcpp)
N> +{
N> +struct ifvlan *ifv;
N> +
N> +if (ifp->if_type != IFT_L2VLAN)
N> +return (EINVAL);
N> +ifv = ifp->if_softc;
N> +*pcpp = ifv->ifv_pcp;
N> +return (0);
N> +}
Is there
On Tue, Aug 21, 2018 at 02:28:27PM -0700, Navdeep Parhar wrote:
N> On 8/21/18 2:26 PM, Gleb Smirnoff wrote:
N> > Navdeep,
N> >
N> > On Thu, Aug 16, 2018 at 11:46:38PM +, Navdeep Parhar wrote:
N> > N> Author: np
N> > N> Date: Thu Aug 16 23:46:38 2018
N
if_freemulti(ll_ifma);
M> }
Coverity suggested there is a cut and paste mistake here, and it is compilable.
After quick glance I tend to agree. Looks like flag is cleared on wrong ifma.
--
Gleb Smirnoff
___
svn-src-head@freebsd.org
idden.
P> * Locking is done in the discipline specific attach functions. Basically
P> @@ -733,34 +723,34 @@ altq_remove_queue(struct pf_altq *a)
P> * copyout operations, also it is not yet clear which lock to use.
P> */
P> int
P> -altq_getqstats(struct pf_altq *a, void *ubuf, int *
Author: glebius
Date: Tue Mar 13 22:54:29 2018
New Revision: 330883
URL: https://svnweb.freebsd.org/changeset/base/330883
Log:
Fix typo that misteriously passes compilation.
Modified:
head/stand/userboot/userboot/main.c
Modified: head/stand/userboot/userboot/main.c
or pcb %p", __func__, inp));
J> +if (inp->inp_flags2 & INP_FREED) {
J> + INP_WUNLOCK(inp);
J> +return;
J> +}
J> +
This code will create Coverity report. IMHO, only KASSERT should be left.
--
Gleb Smirnoff
__
Author: glebius
Date: Mon Apr 2 05:14:31 2018
New Revision: 331872
URL: https://svnweb.freebsd.org/changeset/base/331872
Log:
In uma_startup_count() handle special case when zone will fit into
single slab, but with alignment adjustment it won't. Again, when
there is only one item in a slab
Author: glebius
Date: Mon Apr 2 05:15:25 2018
New Revision: 331873
URL: https://svnweb.freebsd.org/changeset/base/331873
Log:
Use UMA_SLAB_SPACE macro. No functional change here.
Modified:
head/sys/vm/uma_core.c
Modified: head/sys/vm/uma_core.c
Author: glebius
Date: Mon Apr 2 05:11:59 2018
New Revision: 331871
URL: https://svnweb.freebsd.org/changeset/base/331871
Log:
Handle a special case when a slab can fit only one allocation,
and zone has a large alignment. With alignment taken into
account uk_rsize will be greater than space
/* pad out to cache line (64 bytes) */
A> +uint64_t asc_pad[2]; /* pad out to cache line (64 bytes) */
A> } aggsum_bucket_t __aligned(CACHE_LINE_SIZE);
A>
A> /*
A>
--
Gleb Smirnoff
___
svn-src-head@freebsd.org mailing list
http
quot; $pf_flags || return 1
K> -$pf_program -f "$pf_rules" $pf_flags
K> +pf_resync
K> }
K>
K> pf_resync()
K> {
K> +$pf_program -n -f "$pf_rules" $pf_flags || return 1
K> $pf_program -f "$pf_rules" $pf_flags
K>
On Tue, Apr 03, 2018 at 09:06:46AM -0700, Gleb Smirnoff wrote:
T> Hmm, may be I am wrong, but back when I was actively working with pf,
T> the "reload" command would break the ssh connection I am using, so
T> I have taught myself to use "resync".
Just checked on r
On Tue, Apr 03, 2018 at 08:49:09AM +0200, Kristof Provost wrote:
K> On 3 Apr 2018, at 0:04, Gleb Smirnoff wrote:
K> > I just want to note that this is a huge change of behaviour
K> > of pf(4) for a user. Over a decade everybody has been used
K> > to the difference between &qu
Author: glebius
Date: Tue Mar 20 22:00:58 2018
New Revision: 331270
URL: https://svnweb.freebsd.org/changeset/base/331270
Log:
Fix whitespace issues in r330034. No functional changes.
Modified:
head/usr.sbin/syslogd/syslogd.c
Modified: head/usr.sbin/syslogd/syslogd.c
Author: glebius
Date: Tue Mar 20 22:05:21 2018
New Revision: 331272
URL: https://svnweb.freebsd.org/changeset/base/331272
Log:
At this point iwmesg isn't initialized yet, so print pointer to lock
rather than panic before panicing.
Modified:
head/sys/kern/kern_lock.c
Modified:
Author: glebius
Date: Wed Mar 21 20:59:30 2018
New Revision: 331322
URL: https://svnweb.freebsd.org/changeset/base/331322
Log:
The net.inet.tcp.nolocaltimewait=1 optimization prevents local TCP connections
from entering the TIME_WAIT state. However, it omits sending the ACK for the
FIN,
Author: glebius
Date: Wed Mar 21 23:21:32 2018
New Revision: 331328
URL: https://svnweb.freebsd.org/changeset/base/331328
Log:
Fix sysctl types broken in r329612.
Modified:
head/sys/kern/vfs_bio.c
Modified: head/sys/kern/vfs_bio.c
Author: glebius
Date: Thu Mar 22 05:07:57 2018
New Revision: 331343
URL: https://svnweb.freebsd.org/changeset/base/331343
Log:
Fix LINT-NOINET build initializing local to false. This is
a dead code, since for NOINET build isipv6 is always true,
but this dead code makes it compilable.
Author: glebius
Date: Thu Mar 22 05:26:27 2018
New Revision: 331344
URL: https://svnweb.freebsd.org/changeset/base/331344
Log:
Redo r331328. We need to fix not only type but also format. While
here again notice that we are fixing regression from r331106.
Modified:
head/sys/kern/vfs_bio.c
to 50%.
Here is script:
#!/usr/sbin/dtrace -s
fbt::cpu_set_syscall_retval:entry
{
@[args[1]] = count();
}
I would be interested if anybody reports results on a busy
web server running nginx.
So, I doubt that using __predict_true() is an optimisation here.
--
Gleb Sm
Author: glebius
Date: Mon Oct 15 20:20:57 2018
New Revision: 339370
URL: https://svnweb.freebsd.org/changeset/base/339370
Log:
Avoid OOB reads in memmem(3).
commit 51bdcdc424bd7169c8cccdc2de7cad17f5ea0f70
Author: Alexander Monakov
Date: Fri Jun 30 00:35:33 2017 +0300
fix
Author: glebius
Date: Mon Oct 22 15:48:07 2018
New Revision: 339596
URL: https://svnweb.freebsd.org/changeset/base/339596
Log:
If we lost race or were migrated during bucket allocation for the per-CPU
cache, then we put new bucket on generic bucket cache. However, code didn't
honor
Author: glebius
Date: Sun Oct 21 12:39:00 2018
New Revision: 339532
URL: https://svnweb.freebsd.org/changeset/base/339532
Log:
Fix exiting an epoch(9) we never entered. May happen only with MAC.
Modified:
head/sys/net/if_gif.c
head/sys/net/if_gre.c
head/sys/net/if_me.c
Modified:
Author: glebius
Date: Tue Oct 16 15:57:16 2018
New Revision: 339379
URL: https://svnweb.freebsd.org/changeset/base/339379
Log:
Plug sendfile(2) on a listening socket with proper error code.
Reported by: ngie
Reviewed by: ngie
Approved by: re (delphij)
Modified:
Author: glebius
Date: Tue Oct 23 12:53:09 2018
New Revision: 339643
URL: https://svnweb.freebsd.org/changeset/base/339643
Log:
Fix ipw_start(), where logic was reverted in r287197.
PR: 232554
Submitted by: gl0...@mail.ru
Modified:
head/sys/dev/ipw/if_ipw.c
Modified:
Author: glebius
Date: Wed Oct 24 20:49:51 2018
New Revision: 339695
URL: https://svnweb.freebsd.org/changeset/base/339695
Log:
Remove code that is dead since r287197. Today wlan(4) interfaces aren't
children of some other interface. Creation happens only in wlan_up().
Modified:
Author: glebius
Date: Mon Oct 29 22:10:52 2018
New Revision: 339889
URL: https://svnweb.freebsd.org/changeset/base/339889
Log:
Add a note that epoch(9) may change, to untie our hands for any future MFCs.
Modified:
head/share/man/man9/epoch.9
Modified: head/share/man/man9/epoch.9
Author: glebius
Date: Wed Oct 31 19:59:20 2018
New Revision: 339970
URL: https://svnweb.freebsd.org/changeset/base/339970
Log:
Remove unnecessary include from libstand.
Modified:
head/stand/libsa/ip.c
head/stand/libsa/net.c
head/stand/libsa/udp.c
Modified: head/stand/libsa/ip.c
Author: glebius
Date: Wed Oct 31 19:37:11 2018
New Revision: 339969
URL: https://svnweb.freebsd.org/changeset/base/339969
Log:
Define QMD_SAVELINK() only for QUEUE_MACRO_DEBUG_TRASH case. Otherwise
with QUEUE_MACRO_DEBUG_TRACE compilation fails due to unused variable.
Modified:
Author: glebius
Date: Tue Nov 13 23:45:38 2018
New Revision: 340417
URL: https://svnweb.freebsd.org/changeset/base/340417
Log:
With epoch not inlined, there is no point in using _lite KPI. While here,
remove some unnecessary casts.
Modified:
head/sys/kern/genoffset.c
701 - 800 of 2438 matches
Mail list logo
