Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Mark Linimon
On Tue, Jan 14, 2020 at 10:10:46PM -0800, Gleb Smirnoff wrote: > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); > > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); I'm

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Hans Petter Selasky
On 2020-01-15 07:10, Gleb Smirnoff wrote: I really want to reverse the argument order of epoch_call() as well. The current order is really backwards: void epoch_call(epoch_t epoch, epoch_context_t ctx, void (*callback)(epoch_context_t)); Suggested declaration is:

Re: svn commit: r356725 - head/usr.bin/diff

2020-01-15 Thread Ronald Klop
Van: Baptiste Daroussin Datum: dinsdag, 14 januari 2020 18:10 Aan: Ian Lepore CC: svn-src-head@freebsd.org, svn-src-...@freebsd.org, src-committ...@freebsd.org Onderwerp: Re: svn commit: r356725 - head/usr.bin/diff On Tue, Jan 14, 2020 at 08:44:29AM -0700, Ian Lepore wrote: > On Tue,

svn commit: r356759 - head/tools/build/options

2020-01-15 Thread Ed Maste
Author: emaste Date: Wed Jan 15 13:52:13 2020 New Revision: 356759 URL: https://svnweb.freebsd.org/changeset/base/356759 Log: Update WITHOUT_BINUTILS* descriptions In the WITHOUT_ descriptions we don't need to mention that ld.bfd is limited to powerpc. When WITHOUT_BINUTILS is specified

svn commit: r356761 - head/sys/conf

2020-01-15 Thread Kyle Evans
Author: kevans Date: Wed Jan 15 15:59:32 2020 New Revision: 356761 URL: https://svnweb.freebsd.org/changeset/base/356761 Log: mips trampoline: don't bother with unwind tables The utility here seems somewhat limited, but clang will attempt to generate .eh_frame and actively fail in doing

svn commit: r356762 - head/usr.sbin/pciconf

2020-01-15 Thread Scott Long
Author: scottl Date: Wed Jan 15 16:47:44 2020 New Revision: 356762 URL: https://svnweb.freebsd.org/changeset/base/356762 Log: Fix a spacing error from the previous commit for -ll mode. Add a little more space padding to that mode to give the columns a consistent offset. Modified:

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Oliver Pinter
On Wednesday, January 15, 2020, Ben Woods wrote: > Author: woodsb02 (ports committer) > Date: Wed Jan 15 07:47:52 2020 > New Revision: 356758 > URL: https://svnweb.freebsd.org/changeset/base/356758 > > Log: > bsdinstall: Change "default" (first) Partitioning method to ZFS > > Reported by:

svn commit: r356763 - head/sys/kern

2020-01-15 Thread Kirk McKusick
Author: mckusick Date: Wed Jan 15 18:53:32 2020 New Revision: 356763 URL: https://svnweb.freebsd.org/changeset/base/356763 Log: Peter Holm reports that his test that does an umount(8) on an active mount point while numerous tests are running that are writing to files on that mount point

svn commit: r356760 - head/sys/compat/linuxkpi/common/src

2020-01-15 Thread Mark Johnston
Author: markj Date: Wed Jan 15 15:31:35 2020 New Revision: 356760 URL: https://svnweb.freebsd.org/changeset/base/356760 Log: Handle a NULL thread pointer in linux_close_file(). This can happen if a file is closed during unix socket GC. The same bug was fixed for devfs descriptors in

Re: svn commit: r355978 - head/usr.bin/top

2020-01-15 Thread Tijl Coosemans
On Sat, 21 Dec 2019 05:03:21 + (UTC) Philip Paeps wrote: > Author: philip > Date: Sat Dec 21 05:03:21 2019 > New Revision: 355978 > URL: https://svnweb.freebsd.org/changeset/base/355978 > > Log: > top: display battery capacity remaining > > Submitted by: Antranig Vartanian >

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Gleb Smirnoff
On Wed, Jan 15, 2020 at 09:51:02AM +0100, Hans Petter Selasky wrote: H> On 2020-01-15 07:10, Gleb Smirnoff wrote: H> > I really want to reverse the argument order of epoch_call() as well. H> > The current order is really backwards: H> > H> > void H> > epoch_call(epoch_t epoch,

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Warner Losh
On Wed, Jan 15, 2020 at 12:10 PM Nathan Whitehorn wrote: > I agree -- this seems like a really big change, especially with no > discussion. > I agree this is the right thing to do. ZFS is the best fit for most people (there are exceptions, and they can install UFS and if ZFS isn't right for

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Pedro Giffuni
On 15/01/2020 16:41, Ed Maste wrote: On Wed, 15 Jan 2020 at 16:10, Eugene Grosbein wrote: There are multiple scenarios there ZFS may be sub-optimal at least: small i386 virtual guests or 32-bit only hardware like AMD Geode, or big amd64 SSD-only systems with bhyve and multiple guests that

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Nathan Whitehorn
I agree -- this seems like a really big change, especially with no discussion. -Nathan On 2020-01-15 10:57, Oliver Pinter wrote: > > > On Wednesday, January 15, 2020, Ben Woods > wrote: > > Author: woodsb02 (ports committer) > Date: Wed Jan 15 07:47:52 2020 >

svn commit: r356764 - in head: share/man/man4 sys/dev/acpi_support

2020-01-15 Thread Ed Maste
Author: emaste Date: Wed Jan 15 19:43:45 2020 New Revision: 356764 URL: https://svnweb.freebsd.org/changeset/base/356764 Log: acpi_ibm: reference ThinkPad instead of IBM These are now Lenovo ThinkPads, not IBM ThinkPads. PR: 234403 Submitted by: Kevin Zheng (original)

svn commit: r356766 - in head/lib/libc: powerpc64/string string

2020-01-15 Thread Leandro Lupori
Author: luporl Date: Wed Jan 15 19:53:03 2020 New Revision: 356766 URL: https://svnweb.freebsd.org/changeset/base/356766 Log: [PPC64] strncpy optimization Assembly optimization of strncpy for PowerPC64, using double words instead of bytes to copy strings. Submitted by: Leonardo

svn commit: r356767 - head/lib/libc/powerpc64/string

2020-01-15 Thread Leandro Lupori
Author: luporl Date: Wed Jan 15 20:25:52 2020 New Revision: 356767 URL: https://svnweb.freebsd.org/changeset/base/356767 Log: [PPC64] memcpy/memmove/bcopy optimization For copies shorter than 512 bytes, the data is copied using plain ld/std instructions. For 512 bytes or more, the copy

svn commit: r356765 - in head/lib/libc: powerpc64/string string

2020-01-15 Thread Leandro Lupori
Author: luporl Date: Wed Jan 15 19:46:01 2020 New Revision: 356765 URL: https://svnweb.freebsd.org/changeset/base/356765 Log: [PPC64] strcpy optimization Assembly optimization of strcpy for PowerPC64, using double words instead of bytes to copy strings. Submitted by: Leonardo

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Eugene Grosbein
16.01.2020 3:32, Warner Losh wrote: > unless your work load hits the fairly narrow range where ZFS isn't so good. > > [*] Netflix uses UFS because of sendfile efficiencies There are multiple scenarios there ZFS may be sub-optimal at least: small i386 virtual guests or 32-bit only hardware like

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Jeff Roberson
On Wed, 15 Jan 2020, Gleb Smirnoff wrote: Author: glebius Date: Wed Jan 15 06:05:20 2020 New Revision: 356755 URL: https://svnweb.freebsd.org/changeset/base/356755 Log: Introduce NET_EPOCH_CALL() macro and use it everywhere where we free data based on the network epoch. The macro reverses

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Warner Losh
On Wed, Jan 15, 2020 at 12:45 PM Jeff Roberson wrote: > On Wed, 15 Jan 2020, Gleb Smirnoff wrote: > > > Author: glebius > > Date: Wed Jan 15 06:05:20 2020 > > New Revision: 356755 > > URL: https://svnweb.freebsd.org/changeset/base/356755 > > > > Log: > > Introduce NET_EPOCH_CALL() macro and use

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Ed Maste
On Wed, 15 Jan 2020 at 16:10, Eugene Grosbein wrote: > > There are multiple scenarios there ZFS may be sub-optimal at least: small > i386 virtual guests > or 32-bit only hardware like AMD Geode, or big amd64 SSD-only systems with > bhyve and multiple guests > that need lots of memory and should

Re: svn commit: r355978 - head/usr.bin/top

2020-01-15 Thread Alexey Dokuchaev
On Wed, Jan 15, 2020 at 07:09:58PM +0100, T??l Coosemans wrote: > On Sat, 21 Dec 2019 05:03:21 + (UTC) Philip Paeps wrote: > > New Revision: 355978 > > URL: https://svnweb.freebsd.org/changeset/base/355978 > > > > Log: > > top: display battery capacity remaining > > > > Submitted by:

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Eugene Grosbein
16.01.2020 4:41, Ed Maste wrote: > On Wed, 15 Jan 2020 at 16:10, Eugene Grosbein wrote: >> >> There are multiple scenarios there ZFS may be sub-optimal at least: small >> i386 virtual guests >> or 32-bit only hardware like AMD Geode, or big amd64 SSD-only systems with >> bhyve and multiple

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Eugene Grosbein
16.01.2020 4:41, Ed Maste wrote: > On Wed, 15 Jan 2020 at 16:10, Eugene Grosbein wrote: >> >> There are multiple scenarios there ZFS may be sub-optimal at least: small >> i386 virtual guests >> or 32-bit only hardware like AMD Geode, or big amd64 SSD-only systems with >> bhyve and multiple

Re: svn commit: r355978 - head/usr.bin/top

2020-01-15 Thread Philip Paeps
On 2020-01-16 04:09:58 (+1000), Tijl Coosemans wrote: On Sat, 21 Dec 2019 05:03:21 + (UTC) Philip Paeps wrote: Author: philip Date: Sat Dec 21 05:03:21 2019 New Revision: 355978 URL: https://svnweb.freebsd.org/changeset/base/355978 Log: top: display battery capacity remaining

svn commit: r356776 - in head/sys: kern vm

2020-01-15 Thread Jeff Roberson
Author: jeff Date: Thu Jan 16 05:01:21 2020 New Revision: 356776 URL: https://svnweb.freebsd.org/changeset/base/356776 Log: Simplify VM and UMA startup by eliminating boot pages. Instead use careful ordering to allocate early pages in the same way boot pages were but only as needed. After

Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts

2020-01-15 Thread Philip Paeps
On 2020-01-16 04:57:28 (+1000), Oliver Pinter wrote: On Wednesday, January 15, 2020, Ben Woods wrote: Author: woodsb02 (ports committer) Date: Wed Jan 15 07:47:52 2020 New Revision: 356758 URL: https://svnweb.freebsd.org/changeset/base/356758 Log: bsdinstall: Change "default" (first)

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Conrad Meyer
On Wed, Jan 15, 2020 at 12:36 PM Warner Losh wrote: > Everywhere else in the system, it's fnp, argp for ordering the args... You'd > be hard pressed to find exceptions to this rule. Since this is a new > interface, we should fix it now while we still can :) qsort_r() is one exception (and that

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-15 Thread Gleb Smirnoff
On Wed, Jan 15, 2020 at 09:44:53AM -1000, Jeff Roberson wrote: J> On Wed, 15 Jan 2020, Gleb Smirnoff wrote: J> J> > Author: glebius J> > Date: Wed Jan 15 06:05:20 2020 J> > New Revision: 356755 J> > URL: https://svnweb.freebsd.org/changeset/base/356755 J> > J> > Log: J> > Introduce