Re: svn commit: r335171 - head/sys/vm

2018-06-14 Thread Steven Hartland
Out of interest, how would this exhibit itself? On 14/06/2018 20:41, Konstantin Belousov wrote: Author: kib Date: Thu Jun 14 19:41:02 2018 New Revision: 335171 URL: https://svnweb.freebsd.org/changeset/base/335171 Log: Handle the race between fork/vm_object_split() and faults. If faul

Re: svn commit: r335171 - head/sys/vm

2018-06-15 Thread Steven Hartland
On 15/06/2018 00:07, Alan Cox wrote: On Jun 14, 2018, at 5:54 PM, Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Out of interest, how would this exhibit itself? A panic in vm_page_insert_after(). So just to confirm this couldn't cause random memory cor

svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the use of flowid for lagg by default Disabled the use of RSS hash from the network card aka flowid for lagg(4) interfaces by default as it's currently incom

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the use of flowid for lagg by default Disabled the use of RSS hash

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
On 04/01/2018 22:42, hiren panchasara wrote: On 01/04/18 at 09:52P, Steven Hartland wrote: On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 02:01, Eugene Grosbein wrote: 05.01.2018 4:52, Steven Hartland wrote: RSS by definition has meaning to received stream. What is "outbound" stream in this context, why can the hash calculatiom method change and what exactly does it mean "a stream being incorrect

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 02:09, Eugene Grosbein wrote: 05.01.2018 6:37, Steven Hartland wrote: Our TCP stack seems fragile during setup to out of order packets which this multipath behavior causes, we've seen this on our loadbalancers which is what triggered the investigation. The concrete result is

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 02:55, Adrian Chadd wrote: does it also happen when you actually enable RSS in the kernel? Since like I went through a whole lot of pain to assign a flowid at connection setup time. -a On 4 January 2018 at 15:37, Steven Hartland wrote: On 04/01/2018 22:42, hiren panchasara

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 13:41, Eugene Grosbein wrote: 05.01.2018 16:34, Steven Hartland wrote: I hope there's some improvements that can be made, for example if we can determine the stream was instigated remotely then flowid would always be valid hence we can use it assuming it matches the requ

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 13:49, Eugene Grosbein wrote: 05.01.2018 16:26, Steven Hartland пишет: On 05/01/2018 02:01, Eugene Grosbein wrote: 05.01.2018 4:52, Steven Hartland wrote: RSS by definition has meaning to received stream. What is "outbound" stream in this context, why can the hash c

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 14:38, Slawa Olhovchenkov wrote: On Fri, Jan 05, 2018 at 08:36:48PM +0700, Eugene Grosbein wrote: 05.01.2018 20:11, Slawa Olhovchenkov wrote: Irrelevant to RSS and etc. flowid distribution in lacp case work very bad. This is good and must be MFC (IMHO). It may work bad dependin

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 09:41, hiren panchasara wrote: IIRC, with 'RSS' in kernconf, most NIC drivers and stack should do the right thing. Look at drivers and also conn startup code in TCP as I recall it doing the flowid mapping correctly when stream originated from the other side and had flowid assigned t

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 17:02, Eugene Grosbein wrote: 05.01.2018 22:13, Steven Hartland wrote: I hope there's some improvements that can be made, for example if we can determine the stream was instigated remotely then flowid would always be valid hence we can use it assuming it matches the requ

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 17:16, Eugene Grosbein wrote: That is, there is no guarantee of persistance of flowid of incoming packets as they can be received with distinct ports of lagg being distinct hardware computing flowid differently. Some ports may not support RSS at all. We should not use incoming har

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 17:06, Eugene Grosbein wrote: 05.01.2018 23:11, Steven Hartland wrote: What do others think, am I missing something? You still consider only TCP case missing IP forwarning case when all IP packets are transit coming from lagg0 and going out via lagg1. Just going out via a laggX

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 17:39, Matt Joras wrote: On Fri, Jan 5, 2018 at 9:32 AM, Eugene Grosbein wrote: 06.01.2018 0:28, Matt Joras wrote: For what it's worth, this was the conclusion I came to, and at Isilon we've made the same change being discussed here. For the case of drivers that end up using a

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Steven Hartland
On 05/01/2018 23:30, Scott Long wrote: On Jan 5, 2018, at 11:20 AM, Eugene Grosbein wrote: CC'ng scottl@ as author of the change in question. 06.01.2018 0:39, Matt Joras wrote: For what it's worth, this was the conclusion I came to, and at Isilon we've made the same change being discussed

Re: svn commit: r328136 - in head/etc: defaults rc.d

2018-01-18 Thread Steven Hartland
Did you intend to add the growfs option at the same time as it wasn’t mentioned in the commit msg On Thu, 18 Jan 2018 at 20:46, Brad Davis wrote: > Author: brd (doc,ports committer) > Date: Thu Jan 18 20:45:41 2018 > New Revision: 328136 > URL: https://svnweb.freebsd.org/changeset/base/328136 >

svn commit: r328321 - head/sys/net

2018-01-24 Thread Steven Hartland
Author: smh Date: Wed Jan 24 10:13:14 2018 New Revision: 328321 URL: https://svnweb.freebsd.org/changeset/base/328321 Log: Added missing CTLFLAG_VNET to lacp default_strict_mode Added CTLFLAG_VNET to net.link.lagg.lacp.default_strict_mode which was missed in r290450. Reported by: ju

Re: svn commit: r331209 - head

2018-03-22 Thread Steven Hartland
I think it would be worth specifically detailing the steps to achieve this, as its not immediately obvious how this would be done. On 19/03/2018 15:27, Kyle Evans wrote: Author: kevans Date: Mon Mar 19 15:27:53 2018 New Revision: 331209 URL: https://svnweb.freebsd.org/changeset/base/331209 Log

Re: svn commit: r327559 - in head: . sys/net

2018-03-31 Thread Steven Hartland
On 05/01/2018 13:11, Slawa Olhovchenkov wrote: On Fri, Jan 05, 2018 at 03:50:31AM +0700, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the

Re: svn commit: r332285 - head/sys/kern

2018-04-08 Thread Steven Hartland
Worth making the sysctls so they can be tuned the the HW / use case? On 08/04/2018 17:34, Mateusz Guzik wrote: Author: mjg Date: Sun Apr 8 16:34:10 2018 New Revision: 332285 URL: https://svnweb.freebsd.org/changeset/base/332285 Log: locks: tweak backoff a little bit Previous limits w

Re: svn commit: r332523 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

2018-04-16 Thread Steven Hartland
Hey Mav, this seems like an important one to get in for 11.2 so just wanted to check if that was your intention as there's no MFC tag on the commit? On 16/04/2018 01:54, Alexander Motin wrote: Author: mav Date: Mon Apr 16 00:54:58 2018 New Revision: 332523 URL: https://svnweb.freebsd.org/chang

Re: svn commit: r333266 - head/sys/amd64/amd64

2018-05-04 Thread Steven Hartland
Can we get the why in commit messages please? This sort of message doesnt provide anything more that can be obtained from reading the diff, which just leaves us wondering why? I’m sure there is a good reason, but without confirmation we’re just left guessing. The knock on to this is if some assum

Re: svn commit: r333267 - head/sys/kern

2018-05-04 Thread Steven Hartland
Again why? On Fri, 4 May 2018 at 23:48, Mateusz Guzik wrote: > Author: mjg > Date: Fri May 4 22:48:10 2018 > New Revision: 333267 > URL: https://svnweb.freebsd.org/changeset/base/333267 > > Log: > tc: bcopy -> memcpy > > Modified: > head/sys/kern/kern_tc.c > > Modified: head/sys/kern/kern_t

svn commit: r320138 - head/usr.sbin/bsdinstall/scripts

2017-06-20 Thread Steven Hartland
Author: smh Date: Tue Jun 20 08:03:50 2017 New Revision: 320138 URL: https://svnweb.freebsd.org/changeset/base/320138 Log: Fixed bsdinstall location of vfs.zfs.min_auto_ashift vfs.zfs.min_auto_ashift is a sysctl only not a tunable so updated bsdinstall to use the correct location /etc/sys

Re: svn commit: r307507 - head/sys/cam/scsi

2016-10-17 Thread Steven Hartland
IIRC the timeout for this was intentionally lower than the default, might be worth just checking. On 17/10/2016 09:35, Alexander Motin wrote: Author: mav Date: Mon Oct 17 08:35:56 2016 New Revision: 307507 URL: https://svnweb.freebsd.org/changeset/base/307507 Log: Consider device as clean e

Re: svn commit: r307507 - head/sys/cam/scsi

2016-10-17 Thread Steven Hartland
On 17/10/2016 09:51, Alexander Motin wrote: On 17.10.2016 11:45, Steven Hartland wrote: IIRC the timeout for this was intentionally lower than the default, might be worth just checking. I did traced back the commit history, and it was hardcoded to that value since the beginning 18 years ago

Re: svn commit: r308782 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2016-11-17 Thread Steven Hartland
Is this something that should be upstreamed? On 17/11/2016 21:01, Alexander Motin wrote: Author: mav Date: Thu Nov 17 21:01:27 2016 New Revision: 308782 URL: https://svnweb.freebsd.org/changeset/base/308782 Log: After some ZIL changes 6 years ago zil_slog_limit got partially broken due to

Re: svn commit: r308782 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2016-11-17 Thread Steven Hartland
Thanks, looks like the PR needs a rebase before it can be merged. On 17/11/2016 22:11, Alexander Motin wrote: It is in OpenZFS review queue now: https://github.com/openzfs/openzfs/pull/219 Welcome to comment there to speed up the process. On 17.11.2016 13:43, Steven Hartland wrote: Is this

Re: svn commit: r354283 - in head: stand/libsa/zfs sys/cddl/boot/zfs

2019-11-03 Thread Steven Hartland
Pretty sure we had at least two systems using root with log just fine, so would be interested to know why this isn’t supported anymore? On Sun, 3 Nov 2019 at 13:26, Toomas Soome wrote: > Author: tsoome > Date: Sun Nov 3 13:25:47 2019 > New Revision: 354283 > URL: https://svnweb.freebsd.org/chan

svn commit: r346594 - head/sbin/camcontrol

2019-09-03 Thread Steven Hartland
Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it usin

Re: svn commit: r355430 - head/sys/cam/scsi

2019-12-06 Thread Steven Hartland
If the illegal chars where removed or replaced would the result be useful, if so might that be a better approach? On Fri, 6 Dec 2019 at 00:06, Alan Somers wrote: > Author: asomers > Date: Fri Dec 6 00:06:05 2019 > New Revision: 355430 > URL: https://svnweb.freebsd.org/changeset/base/355430 > >

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-16 Thread Steven Hartland
Be aware that ZFS already does a pretty decent job of this already, so the statement about upper layers isn't true for all. It even has different priorities for different request types so I'm a little concerned that doing it at both layers could cause issues. In addition to this if its anythin

Re: svn commit: r355832 - head/sys/cam

2019-12-16 Thread Steven Hartland
What if any is the impact on request ordering with this new delayed TRIM? On 17/12/2019 00:13, Warner Losh wrote: Author: imp Date: Tue Dec 17 00:13:21 2019 New Revision: 355832 URL: https://svnweb.freebsd.org/changeset/base/355832 Log: Add rate limiters to TRIM. Add rate limiters to

Re: svn commit: r355837 - head/sys/cam

2019-12-16 Thread Steven Hartland
Sticky keyboard there Warner? On a more serious note the fact that the controllers lie about the underlying location of data, the impact of skipping the TRIM requests can have a much more serious impact than one might think depending on the drive, so this type of optimisation can significantly

Re: svn commit: r355831 - head/sys/cam/nvme

2019-12-18 Thread Steven Hartland
Thanks for all the feedback Warner, some more comments in line below, would be interested in your thoughts. On 17/12/2019 02:53, Warner Losh wrote: On Mon, Dec 16, 2019, 5:28 PM Steven Hartland <mailto:steven.hartl...@multiplay.co.uk>> wrote: Be aware that ZFS already does

Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys

2020-01-14 Thread Steven Hartland
Aren’t the current and suggested the same there or do I need more coffee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we fr

Re: svn commit: r324449 - in head/sys/boot: arm/uboot efi/boot1 sparc64/loader

2017-10-09 Thread Steven Hartland
Not sure which of these sets of changes caused the issue but a clean build from scratch is currently failing here with: In file included from /usr/home/smh/freebsd/base/head/sys/boot/efi/boot1/ufs_module.c:41: In file included from /usr/home/smh/freebsd/base/head/sys/boot/efi/boot1/boot_module

Re: svn commit: r324449 - in head/sys/boot: arm/uboot efi/boot1 sparc64/loader

2017-10-09 Thread Steven Hartland
Mon, Oct 9, 2017 at 5:56 PM, Steven Hartland mailto:steven.hartl...@multiplay.co.uk>> wrote: Not sure which of these sets of changes caused the issue but a clean build from scratch is currently failing here with: In file included from /usr/home/smh/freebs

Re: svn commit: r318751 - in head/sys: kern sys

2017-10-21 Thread Steven Hartland
Personally I hate that idea as like being able to see all the processes from the host. I have a similar hate of Linux containers where you have to jump though hoops just to see whats really happening on the host. On Sat, 21 Oct 2017 at 20:29, Allan Jude wrote: > On 2017-05-23 12:59, Steve Wills

Re: svn commit: r324983 - in head: lib/libc/sys sys/sys

2017-10-25 Thread Steven Hartland
Personally I would expect the fallback to be reboot as without the ability to power back on remotely e.g. IPMI this could render the machine inaccessible, which is not ideal, thoughts? On 25/10/2017 16:30, Warner Losh wrote: Author: imp Date: Wed Oct 25 15:30:20 2017 New Revision: 324983 URL:

Re: svn commit: r325092 - head/usr.bin/fortune/datfiles

2017-10-29 Thread Steven Hartland
I’ve still had to use rehash on several occasions for it to detect new apps, so remove that reference might be a mistake On Sun, 29 Oct 2017 at 18:51, Cy Schubert wrote: > In message > om> > , Warner Losh writes: > > --94eb2c114c9a7c3c21055cb3566c > > Content-Type: text/plain; charset="UTF-8" >

Re: svn commit: r335856 - in head/sys: netinet sys

2018-07-02 Thread Steven Hartland
You have M_WAITOK and a null check in this change On Mon, 2 Jul 2018 at 06:20, Matt Macy wrote: > Author: mmacy > Date: Mon Jul 2 05:19:44 2018 > New Revision: 335856 > URL: https://svnweb.freebsd.org/changeset/base/335856 > > Log: > inpcb: don't gratuitously defer frees > > Don't defer fre

Re: svn commit: r335856 - in head/sys: netinet sys

2018-07-10 Thread Steven Hartland
wrote: [ Charset UTF-8 unsupported, converting... ] On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < steven.hartl...@multiplay.co.uk> wrote: You have M_WAITOK and a null check in this change And, that's the same as the way it was before his commits. So, he did exactly what he said

svn commit: r336165 - head/sys/netinet

2018-07-10 Thread Steven Hartland
Author: smh Date: Tue Jul 10 08:05:32 2018 New Revision: 336165 URL: https://svnweb.freebsd.org/changeset/base/336165 Log: Removed pointless NULL check Removed pointless NULL check after malloc with M_WAITOK which can never return NULL. Sponsored by: Multiplay Modified: head/sys/n

svn commit: r346594 - head/sbin/camcontrol

2019-04-23 Thread Steven Hartland
Author: smh Date: Tue Apr 23 07:46:38 2019 New Revision: 346594 URL: https://svnweb.freebsd.org/changeset/base/346594 Log: Add ATA power mode support to camcontrol Add the ability to report ATA device power mode with the cmmand 'powermode' to compliment the existing ability to set it usin

Re: svn commit: r348255 - head/sys/kern

2019-05-24 Thread Steven Hartland
Just wanted to say I really appreciate the details in this commit message. Its often the case the message get overlooked when it comes to the time needed to write a truly useful message to others and this a great example of the quality we should all try to follow. Regards Steve On Fri, 24 Ma

svn commit: r315423 - head/lib/libsysdecode

2017-03-16 Thread Steven Hartland
Author: smh Date: Thu Mar 16 20:55:00 2017 New Revision: 315423 URL: https://svnweb.freebsd.org/changeset/base/315423 Log: Fix libsysdecode vmprot flag decoding Fix the regex used to find vmprot table entries and add the missing include. This fixes kdumps output of PFLT arguments which

svn commit: r315449 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2017-03-17 Thread Steven Hartland
Author: smh Date: Fri Mar 17 12:34:57 2017 New Revision: 315449 URL: https://svnweb.freebsd.org/changeset/base/315449 Log: Reduce ARC fragmentation threshold As ZFS can request up to SPA_MAXBLOCKSIZE memory block e.g. during zfs recv, update the threshold at which we start agressive recla

svn commit: r316313 - in head: . sys/netinet

2017-03-30 Thread Steven Hartland
Author: smh Date: Fri Mar 31 00:41:54 2017 New Revision: 316313 URL: https://svnweb.freebsd.org/changeset/base/316313 Log: Allow explicitly assigned IPv4 loopback address to be used in jails If a jail has an explicitly assigned loopback address then allow it to be used instead of remappin

svn commit: r316328 - in head: . sys/netinet6

2017-03-31 Thread Steven Hartland
Author: smh Date: Fri Mar 31 09:10:05 2017 New Revision: 316328 URL: https://svnweb.freebsd.org/changeset/base/316328 Log: Allow explicitly assigned IPv6 loopback address to be used in jails If a jail has an explicitly assigned IPv6 loopback address then allow it to be used instead of rem

Re: svn commit: r316311 - in head: lib/libstand sys/boot/geli sys/boot/i386/gptboot sys/boot/i386/loader sys/boot/i386/zfsboot

2017-03-31 Thread Steven Hartland
On 31/03/2017 16:16, Ian Lepore wrote: On Fri, 2017-03-31 at 00:04 +, Allan Jude wrote: Add explicit_bzero() to libstand, and switch GELIBoot to using it revolution > man explicit_bzero No manual entry for explicit_bzero revolution > svn log -v explicit_bzero.c ...

svn commit: r316460 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2017-04-03 Thread Steven Hartland
Author: smh Date: Mon Apr 3 13:11:28 2017 New Revision: 316460 URL: https://svnweb.freebsd.org/changeset/base/316460 Log: Fix expandsz 16.0E vals and vdev_min_asize of RAIDZ children When a member of a RAIDZ has been replaced with a device smaller than the original, then the top level vd

svn commit: r316676 - in head/sys/netinet: . tcp_stacks

2017-04-10 Thread Steven Hartland
Author: smh Date: Mon Apr 10 08:19:35 2017 New Revision: 316676 URL: https://svnweb.freebsd.org/changeset/base/316676 Log: Use estimated RTT for receive buffer auto resizing instead of timestamps Switched from using timestamps to RTT estimates when performing TCP receive buffer auto resiz

Re: svn commit: r316676 - in head/sys/netinet: . tcp_stacks

2017-04-10 Thread Steven Hartland
FC to 10 too would be nice.. thanks On 10/4/17 4:19 pm, Steven Hartland wrote: Author: smh Date: Mon Apr 10 08:19:35 2017 New Revision: 316676 URL: https://svnweb.freebsd.org/changeset/base/316676 Log: Use estimated RTT for receive buffer auto resizing instead of timestamps Switched

Re: svn commit: r328625 - in head/sys: amd64/amd64 amd64/ia32 amd64/include dev/cpuctl i386/i386 x86/include x86/x86

2018-01-31 Thread Steven Hartland
Pretty sure I’ve seen that too On Wed, 31 Jan 2018 at 18:05, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Jan 31, 2018 at 02:56:24PM +, Bjoern A. Zeeb wrote: > > > On 31 Jan 2018, at 14:36, Konstantin Belousov wrote: > > > > > > > Author: kib > > > > Date: Wed Jan 31

Re: svn commit: r328996 - head/sys/kern

2018-02-07 Thread Steven Hartland
What would be the expected behavior if this was triggered, app crash or kernel panic...? On 07/02/2018 21:52, Andriy Gapon wrote: Author: avg Date: Wed Feb 7 21:51:59 2018 New Revision: 328996 URL: https://svnweb.freebsd.org/changeset/base/328996 Log: exec_map_first_page: fix an inverse co

Re: svn commit: r329812 - head/sys/cam

2018-02-22 Thread Steven Hartland
In our experience this is very device dependent, what lead you to this conclusion? On 22/02/2018 05:43, Warner Losh wrote: Author: imp Date: Thu Feb 22 05:43:20 2018 New Revision: 329812 URL: https://svnweb.freebsd.org/changeset/base/329812 Log: Don't sort TRIMs. While the code for a

svn commit: r330950 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-03-14 Thread Steven Hartland
Author: smh Date: Wed Mar 14 21:21:03 2018 New Revision: 330950 URL: https://svnweb.freebsd.org/changeset/base/330950 Log: Prevent ZFS TRIM breaking VTOC8 partitions Update the ZFS TRIM code to ensure it respects VTOC8 partition headers as documented by the ZFS On-Disk Specification secti

Re: svn commit: r330950 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2018-03-14 Thread Steven Hartland
Missed the differential review: https://reviews.freebsd.org/D14695 On 14/03/2018 21:21, Steven Hartland wrote: Author: smh Date: Wed Mar 14 21:21:03 2018 New Revision: 330950 URL: https://svnweb.freebsd.org/changeset/base/330950 Log: Prevent ZFS TRIM breaking VTOC8 partitions Update

svn commit: r330951 - head/sys/dev/mps

2018-03-14 Thread Steven Hartland
Author: smh Date: Wed Mar 14 21:32:23 2018 New Revision: 330951 URL: https://svnweb.freebsd.org/changeset/base/330951 Log: Fix mps deadlock when handling panic During shutdown mps waits for its SSU requests to complete however when performing a reboot after handling a panic the scheduler

Re: svn commit: r313260 - head/sys/kern

2017-02-04 Thread Steven Hartland
Hi Mateusz could you improve on the commit message as it currently describes what is changed, which can be obtained from the diff, but not why? I hope on one feels like I'm trying to teach them to suck eggs, as I know everyone here has a wealth of experience, but I strongly believe commit mess

Re: svn commit: r313260 - head/sys/kern

2017-02-05 Thread Steven Hartland
On 05/02/2017 15:17, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and unless there is something unusual going on (e.g. complicated circums

Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Steven Hartland
On 07/02/2017 14:57, Mateusz Guzik wrote: On Sun, Feb 05, 2017 at 03:17:46PM +, Alexey Dokuchaev wrote: On Sun, Feb 05, 2017 at 04:00:06AM +0100, Mateusz Guzik wrote: For instance, plugging an unused variable, a memory leak, doing a lockless check first etc. are all pretty standard and unle

Re: svn commit: r313260 - head/sys/kern

2017-02-07 Thread Steven Hartland
On 07/02/2017 20:34, Ed Maste wrote: On 7 February 2017 at 10:30, Steven Hartland wrote: All I'm suggesting is, while one could guess this may be a performance or possibly a compatibility thing, the reason is not obvious, so a small piece of detail on why the change was done should alwa

Re: svn commit: r314155 - head/sys/netinet

2017-02-23 Thread Steven Hartland
You might also be interested in reviewing my fix for TCP buffer scaling too Michael. https://reviews.freebsd.org/D9668 This fixes slow transfers due to no receive buffer scaling if TCP timestamps aren't negotiated. Its still got debug stuff in it ATM and I'm toying with removing the differen

svn commit: r322881 - head/usr.bin/calendar/calendars

2017-08-25 Thread Steven Hartland
) @@ -333,6 +333,7 @@ 09/07 Chris Rees born in Kettering, United Kingdom, 1987 09/08 Boris Samorodov born in Krasnodar, Russian Federation, 1963 09/09 Yoshio Mita born in Hiroshima, Japan, 1972 +09/09 Steven Hartland born in Wordsley, United Kingdom, 1973 09/10 Wesley R. Peters born in

Re: svn commit: r323566 - head/sys/kern

2017-09-14 Thread Steven Hartland
Is this something that will be MFC'ed to 11 or is this 12 / CURRENT only? On 13/09/2017 23:11, Gleb Smirnoff wrote: Author: glebius Date: Wed Sep 13 22:11:05 2017 New Revision: 323566 URL: https://svnweb.freebsd.org/changeset/base/323566 Log: Use soref() in sendfile(2) instead fhold() to ref

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Steven Hartland
Personally I disagree, chances of people finding that option in dd is slim, a dedicated trim utility makes much more sense to me. Sure have both that's cool but keep the trim would be my vote. On 30/11/2018 01:17, Cy Schubert wrote: Agreed. --- Sent using a tiny phone keyboard. Apologies for

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Steven Hartland
ZFS already does that no need for a separate tool On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why can't we have two implementations? Div

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Steven Hartland
On 30/11/2018 22:09, Eugene Grosbein wrote: 01.12.2018 4:29, Steven Hartland wrote: On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place fo

Re: svn commit: r343745 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2019-02-04 Thread Steven Hartland
On 04/02/2019 16:13, Alexander Motin wrote: Author: mav Date: Mon Feb 4 16:13:41 2019 New Revision: 343745 URL: https://svnweb.freebsd.org/changeset/base/343745 Log: Add missed tunables/sysctls for some new vdev variables. While there, make few existing sysctls writeable, since the

svn commit: r344701 - head/sbin/camcontrol

2019-03-01 Thread Steven Hartland
Author: smh Date: Fri Mar 1 14:39:15 2019 New Revision: 344701 URL: https://svnweb.freebsd.org/changeset/base/344701 Log: Fix incorrect / unused sector_count for identify requests Fix incorrect / unused sector_count for identify requests from camcontrol. Submitted by: Alexey Dokuchaev

Re: svn commit: r344701 - head/sbin/camcontrol

2019-03-03 Thread Steven Hartland
Not really much more to say that isn't explained by that and the code. Sure I could have used a different sentence structure for the body but it wouldn't add anything IMO, thoughts? On 02/03/2019 10:49, Alexey Dokuchaev wrote: On Fri, Mar 01, 2019 at 02:39:15PM +0000, Steven Hart

Re: svn commit: r267626 - head/sys/dev/vt

2014-06-19 Thread Steven Hartland
As per man 9 sysctl negative logic should be avoided so we should use enable instead ot disable here: kern.vt.enable with a default of 1 With the user setting kern.vt.enable=0 to disable. Regards Steve - Original Message - From: "Aleksandr Rybalko" To: ; ; Sent: Wednesday, Ju

Re: svn commit: r268238 - head/usr.sbin/gstat

2014-07-03 Thread Steven Hartland
Great idea thanks for this very useful :) Regards Steve - Original Message - From: "Xin LI" To: ; ; Sent: Thursday, July 03, 2014 10:48 PM Subject: svn commit: r268238 - head/usr.sbin/gstat Author: delphij Date: Thu Jul 3 21:48:19 2014 New Revision: 268238 URL: http://svnwe

svn commit: r268621 - head/cddl/contrib/opensolaris/cmd/zpool

2014-07-14 Thread Steven Hartland
Author: smh Date: Mon Jul 14 14:33:03 2014 New Revision: 268621 URL: http://svnweb.freebsd.org/changeset/base/268621 Log: Don't report non-native block-size pools under zpool status -x zpool status -x is used to identify pools that are exhibiting errors or are otherwise unavailable, there

Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2014-07-20 Thread Steven Hartland
- Original Message - From: "Nikolai Lifanov" To: "Xin LI" Cc: ; Sent: Monday, July 21, 2014 2:22 AM Subject: Re: svn commit: r268855 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys On

Re: svn commit: r268980 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2014-07-22 Thread Steven Hartland
Nice catch, that could well be the cause of the "Solaris Assert/zio.c:2548" panics don't you think? Regards Steve - Original Message - From: "Xin LI" To: ; ; Sent: Tuesday, July 22, 2014 9:37 AM Subject: svn commit: r268980 - head/sys/cddl/contrib/opensolaris/uts/common/fs/z

svn commit: r269314 - head/sys/dev/mps

2014-07-30 Thread Steven Hartland
Author: smh Date: Wed Jul 30 17:58:17 2014 New Revision: 269314 URL: http://svnweb.freebsd.org/changeset/base/269314 Log: Bring in LSI's phase16 - phase18 changes * Implements Start Stop Unit for SATA direct-attach devices in IR mode to avoid data corruption. * Use CAM_DEV_NOT_THERE ins

svn commit: r269316 - head/sys/dev/mps

2014-07-30 Thread Steven Hartland
Author: smh Date: Wed Jul 30 18:21:06 2014 New Revision: 269316 URL: http://svnweb.freebsd.org/changeset/base/269316 Log: Bring in LSI's phase19 changes * Removed unused mpssas_discovery_timeout function. * Don't alter mapping boundaries if not raid firmware. * Check free_busaddr instead o

svn commit: r269328 - head/sys/netinet

2014-07-31 Thread Steven Hartland
Author: smh Date: Thu Jul 31 09:18:29 2014 New Revision: 269328 URL: http://svnweb.freebsd.org/changeset/base/269328 Log: Only check error if one could have been generated Modified: head/sys/netinet/in.c Modified: head/sys/netinet/in.c

svn commit: r269340 - head/sys/netinet

2014-07-31 Thread Steven Hartland
Author: smh Date: Thu Jul 31 16:43:56 2014 New Revision: 269340 URL: http://svnweb.freebsd.org/changeset/base/269340 Log: Ensure that IP's added to CARP always use the CARP MAC Previously there was a race condition between the address addition and associating it with the CARP which result

svn commit: r269407 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys

2014-08-01 Thread Steven Hartland
Author: smh Date: Fri Aug 1 23:16:48 2014 New Revision: 269407 URL: http://svnweb.freebsd.org/changeset/base/269407 Log: Don't return ZIO_PIPELINE_CONTINUE from vdev_op_io_start methods This prevents recursion of vdev_queue_io_done as per r265321 but using a different method as recommend

svn commit: r269522 - head/usr.sbin/jail

2014-08-04 Thread Steven Hartland
Author: smh Date: Mon Aug 4 16:32:08 2014 New Revision: 269522 URL: http://svnweb.freebsd.org/changeset/base/269522 Log: Added support for extra ifconfig args to jail ip4.addr & ip6.addr params This allows for CARP interfaces to be used in jails e.g. ip4.addr = "em0|10.10.1.20/32 vhid 1

svn commit: r269972 - head/sys/dev/ixgbe

2014-08-14 Thread Steven Hartland
Author: smh Date: Thu Aug 14 13:25:05 2014 New Revision: 269972 URL: http://svnweb.freebsd.org/changeset/base/269972 Log: Renamed hw.ixgbe.unsupported_sfp -> hw.ix.unsupported_sfp This now matches all other ixgbe sysctl / tunables. Sponsored by: Multiplay Modified: head/sys/dev/ixgb

svn commit: r269974 - in head/sys/cam: ata scsi

2014-08-14 Thread Steven Hartland
Author: smh Date: Thu Aug 14 13:57:17 2014 New Revision: 269974 URL: http://svnweb.freebsd.org/changeset/base/269974 Log: Added 4K quirks for Corsair Force GT and Samsung 840 SSDs MFC after:1 week Sponsored by: Multiplay Modified: head/sys/cam/ata/ata_da.c head/sys/cam/scsi/scsi_

Re: svn commit: r249357 - head/cddl/contrib/opensolaris/lib/libzfs/common

2013-04-24 Thread Steven Hartland
I believe this needs a little tweak so you don't get issues with zfs send which makes use of holds to ensure snapshots being sent don't get deleted while processing. In essence it should honor the enoent_ok flag and not report such an error to stdout. @@ -4207,6 +4238,9 @@ if (nvlist_next_nvpai

svn commit: r249895 - in head: sbin/camcontrol sys/sys

2013-04-25 Thread Steven Hartland
Author: smh Date: Thu Apr 25 14:11:38 2013 New Revision: 249895 URL: http://svnweb.freebsd.org/changeset/base/249895 Log: Adds Host Protected Area (HPA) support for ATA disks to camcontrol Reviewed by: mav Approved by: pjd (mentor) MFC after:2 weeks Modified: head/sbin/camcontr

svn commit: r249921 - in head: . sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 11:24:20 2013 New Revision: 249921 URL: http://svnweb.freebsd.org/changeset/base/249921 Log: Changed ZFS TRIM sysctl from vfs.zfs.trim_disable -> vfs.zfs.trim.enabled Enabled ZFS TRIM by default Reviewed by: pjd (mentor) Approved by: pjd (mentor) MFC aft

svn commit: r249929 - head/sys/cam/scsi

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 15:31:52 2013 New Revision: 249929 URL: http://svnweb.freebsd.org/changeset/base/249929 Log: Removed unneeded tests in dadeletemethodset changing it to return void Reviewed by: mav Approved by: pjd (mentor) MFC after:2 weeks Modified: head/sys/cam/s

svn commit: r249930 - head/sys/geom

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 15:43:24 2013 New Revision: 249930 URL: http://svnweb.freebsd.org/changeset/base/249930 Log: Added a sysctl (kern.geom.dev.delete_max_sectors) to control the maximum size of a delete request sent to the providing device performed by g_dev_ioctl. This allows t

svn commit: r249931 - head/sys/sys

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 15:46:09 2013 New Revision: 249931 URL: http://svnweb.freebsd.org/changeset/base/249931 Log: Added Dataset Management defines to be used by TRIM in cam ata and scsi to calculate the size of blocks. Reviewed by: mav Approved by: pjd (mentor) MFC after:

svn commit: r249933 - head/sys/cam/scsi

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 15:53:22 2013 New Revision: 249933 URL: http://svnweb.freebsd.org/changeset/base/249933 Log: Added the ability to send ATA identify and Data Set Management (DSM) TRIM commands to an ATA device attached via a SCSI control. sys/cam/scsi/scsi_all.c: - A

svn commit: r249934 - head/sys/cam/ata

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 15:59:19 2013 New Revision: 249934 URL: http://svnweb.freebsd.org/changeset/base/249934 Log: Updated TRIM calculations in cam/ata to be based off ATA_DSM_* defines Reviewed by: mav Approved by: pjd (mentor) MFC after:2 weeks Modified: head/sys/cam/a

svn commit: r249937 - head/sys/cam/scsi

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 16:11:03 2013 New Revision: 249937 URL: http://svnweb.freebsd.org/changeset/base/249937 Log: Refactored scsi_xpt use of device_has_vpd to generic scsi_vpd_supported_page so its available for use in generic scsi code. This is a pre-requirement for using VPD que

svn commit: r249939 - head/sys/cam/scsi

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 16:17:04 2013 New Revision: 249939 URL: http://svnweb.freebsd.org/changeset/base/249939 Log: Added available delete methods discovery during device probe, including the maximum sizes for said methods, which are used when processing BIO_DELETE requests. This inclu

svn commit: r249940 - in head/sys: cam/ata cam/scsi geom

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 16:22:54 2013 New Revision: 249940 URL: http://svnweb.freebsd.org/changeset/base/249940 Log: Teach GEOM and CAM about the difference between the max "size" of r/w and delete requests. sys/geom/geom_disk.h: - Added d_delmaxsize which represents the m

svn commit: r249941 - in head/sys/cam: ata scsi

2013-04-26 Thread Steven Hartland
Author: smh Date: Fri Apr 26 16:31:03 2013 New Revision: 249941 URL: http://svnweb.freebsd.org/changeset/base/249941 Log: Added automatic detection of non-rotating media which disables the use of BIO queue sorting, hence optimising performance for devices such as SSD's Reviewed by: sco

  1   2   3   4   5   >