New commits:
commit 72c8aa3b4c41f4fc71573c3f57c38866bfa1c29a
Author: D. Hugh Redelmeier
Date: Fri Mar 26 18:38:10 2021 -0400
testing: "unexpecedly" => "unexpectedly"
___
Swan-commit mailing list
Swan-commit@li
New commits:
commit b3b8cd668e5f4306816376ee444eebec4822b6c1
Author: D. Hugh Redelmeier
Date: Mon Mar 29 17:23:21 2021 -0400
pluto: ikev2_spdb_struct.c: fix a couple of problems
jam_v2_proposal:
- previous version tried to motor through a buffer overflow. I think
New commits:
commit d8ffbbae13dfb69541086b6e118f5136bbd37407
Author: D. Hugh Redelmeier
Date: Mon Mar 29 02:07:22 2021 -0400
pervasive: correct some "it's" to "its"
___
Swan-commit mailing list
Swan-commit@lists
New commits:
commit 259c73fb19daed33a9d9e6e5f3c9a0d4166ca117
Author: D. Hugh Redelmeier
Date: Mon Mar 29 11:34:48 2021 -0400
libswan: unbound.c: unbound_resolve(): convert loop to memcpy
___
Swan-commit mailing list
Swan-commit
New commits:
commit 1c03fe90d1d87c4b8b203e686aaf764ba9ada107
Author: D. Hugh Redelmeier
Date: Wed Mar 10 13:00:25 2021 -0500
pluto: ikev2_ts.c: clarify control structure of score_ends_seclabel
2a2376e5bfa6c19e9a334e2a651b54135e64ab21 added a test that was always true
New commits:
commit a2f59d965e9f8dc6b9aeb44a24f91cbbeda75525
Author: D. Hugh Redelmeier
Date: Sat Mar 13 17:26:07 2021 -0500
pluto: beautify some closing parentheses
Every little bit helps to make complicated expressions understandable
New commits:
commit 6c05c55d937f6c3aa5c93b1a9dcccdce2c9de07e
Author: D. Hugh Redelmeier
Date: Sat Mar 13 17:12:37 2021 -0500
pluto: connections.c: find_connection_for_clients() simplify expression
|| is associative so the extra parens were pointless and made the
expression
New commits:
commit 605949eac6718cf42059b55ed69aa9466381a186
Author: D. Hugh Redelmeier
Date: Sat Mar 13 18:21:23 2021 -0500
pluto: kernel.c: setup_half_ipsec_sa: eliminate pointless and confusing test
___
Swan-commit mailing list
Swan-commit
New commits:
commit 01eeb01f542b257bd0f63e092274dad6e78393e9
Author: D. Hugh Redelmeier
Date: Sat Mar 13 21:21:12 2021 -0500
pluto: connections.c: find_connection_for_clients(): rearrange how
connection_bufs are used
- avoid having an inner-scope variable with the same
New commits:
commit 0fb1f526be7fffc66fcff5bfaa23bfa3a10f7543
Author: D. Hugh Redelmeier
Date: Mon Mar 15 16:02:29 2021 -0400
libswan: ip_selector.c: avoid useless roundtrip unsigned->int->unsigned
___
Swan-commit mailing list
Swan-
New commits:
commit d45c21fbf3e4493545ba7070d24735e6c1573ce5
Author: D. Hugh Redelmeier
Date: Thu Feb 25 10:57:31 2021 -0500
pervasive: add and exploit replace_chunk()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 2e113aab678aa7ec11cc91164ef7f4ad09c46196
Author: D. Hugh Redelmeier
Date: Thu Feb 25 10:03:12 2021 -0500
ikev1_xauth.c: eliminate two horrible line breaks
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 6136009feb5d0036af4f2f56d46019702b3ee2d2
Author: D. Hugh Redelmeier
Date: Sun Feb 28 15:55:57 2021 -0500
shunk.h: fix confusing comment
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org
New commits:
commit 20e214dc28d6e17038d25935a95031e734bdda29
Author: D. Hugh Redelmeier
Date: Sun Feb 28 14:43:28 2021 -0500
pluto/initiate.c: tidy some comments
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit a5c5d5ca7828f3b3aa0384b22cc9154acd23f985
Author: D. Hugh Redelmeier
Date: Mon Mar 1 02:23:35 2021 -0500
pluto: simplify code involving within_range()
Note: this is untested.
___
Swan-commit mailing list
Swan-commit
New commits:
commit 3f2dba1c48f5c429eb499e4d1e552d3a1a47cf65
Author: D. Hugh Redelmeier
Date: Thu Mar 4 15:23:31 2021 -0500
pluto: ikev2_ts.c: improve score_ends_seclabel()
- reduce nesting level in each loop by using another continue
- converge structure of the two loops
New commits:
commit f490a1c54587654bd391295cc4a46b7793f94ff2
Author: D. Hugh Redelmeier
Date: Thu Mar 4 16:00:22 2021 -0500
pluto: tighten up checking of representation of security labels
A security label must must have at least two bytes (a non-empty string
New commits:
commit cf919e16683a941dedde8641ebaeb174fde912cf
Author: D. Hugh Redelmeier
Date: Thu Mar 4 21:04:18 2021 -0500
pluto: consistently test for empty security labels by checking .len
This was mostly the case but not universal
New commits:
commit 90bc38af6ca7b4418d36048fcc26b6df02d39c65
Author: D. Hugh Redelmeier
Date: Thu Mar 4 20:47:21 2021 -0500
pluto: ikev2_ts.c: score_ends_seclabel() early-out for outer loop
___
Swan-commit mailing list
Swan-commit
New commits:
commit 4ee98813e547758fd3282d1d6acede4810fb5265
Author: D. Hugh Redelmeier
Date: Sat Mar 6 11:59:26 2021 -0500
pluto: ikev2_ts.c: eliminate proper_seclabel()
Replaced by vet_seclabel().
___
Swan-commit mailing list
Swan
New commits:
commit c12bf00c1d8e16b8c62a5e436b17b5f954acfa5c
Author: D. Hugh Redelmeier
Date: Wed Mar 3 09:17:37 2021 -0500
pluto: remove redundant test from score_ends_seclabel()
Related to 4622a02699d1d50f9809f407d04ff075f513ff7f
___
Swan
New commits:
commit a1cfb60803a68d7a4d04c539d73ef398e8cf67bb
Author: D. Hugh Redelmeier
Date: Wed Mar 3 09:28:40 2021 -0500
pluto: clarify selected_sec_label() by adding early-out to loops
___
Swan-commit mailing list
Swan-commit
New commits:
commit 4622a02699d1d50f9809f407d04ff075f513ff7f
Author: D. Hugh Redelmeier
Date: Wed Mar 3 08:56:16 2021 -0500
pluto: in score_ends_seclabel() trust but verify that security labels are
well-formed
- NUL at the very end of the shunk
- no other NUL
- at least one
New commits:
commit eb085f394328b8a42f2283dddfdea95fafeccfaf
Author: D. Hugh Redelmeier
Date: Thu Mar 4 11:56:18 2021 -0500
pluto: kiev2_ts.c: simplify proper_seclabel by using hunk_strnlen()
From a suggestion by Andrew.
___
Swan-commit
New commits:
commit 54791ba8ae573960322abec34f44bed9aa64e97e
Author: D. Hugh Redelmeier
Date: Mon Mar 8 12:06:16 2021 -0500
Pluto: ikev2_ts.c: deduplicate code in ts_has_seclabel()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
New commits:
commit c73f8ce93cc87ed78fb9ab543cbcfbb143f269f5
Author: D. Hugh Redelmeier
Date: Sun Mar 7 11:27:20 2021 -0500
Pluto: ikev2_ts.c: fix passert in score_ends_seclabel()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
New commits:
commit 5455a91defc0084a196bc35d7b2d5cd7ab9ab87b
Author: D. Hugh Redelmeier
Date: Fri Mar 5 17:05:09 2021 -0500
pluto: kernel.c: simplify setup_half_ipsec_sa()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 7fed6ce5a9c598fb69b3a9678a3f66c82ede7203
Author: D. Hugh Redelmeier
Date: Fri Mar 5 17:13:35 2021 -0500
pluto: unify checking of form of security label into vet_seclab()
Some places may have been missed.
___
Swan
New commits:
commit 0f3ac98fe26a4b6e4829f1ce98e5a0c8f492edae
Author: D. Hugh Redelmeier
Date: Fri Aug 20 10:54:07 2021 -0400
passert.h: PASSERT should not return a value
I don't know why PASSERT expands to an expression. In any case, it
should not be used as an expression
New commits:
commit 0f25ad250cbcc02a78eb50ec04d33c14540f82b0
Author: D. Hugh Redelmeier
Date: Mon Aug 23 11:56:00 2021 -0400
libswan: fd.c: tiny simplification of fd_dup()
commit 6012050ab666fa43630ac3f23c969e353c90e68c
Author: D. Hugh Redelmeier
Date: Mon Aug 23 11:53:49 2021 -0400
New commits:
commit 294c9820e07c7c1fd360d374c4dce8e476c63ba3
Author: D. Hugh Redelmeier
Date: Fri Aug 20 15:22:17 2021 -0400
pluto: ikev1_spdb_struct.c: eliminate off-by-one indentation
___
Swan-commit mailing list
Swan-commit
New commits:
commit d51d4458707febf44719f98144dd7e4faea97f6b
Author: D. Hugh Redelmeier
Date: Fri Sep 3 18:55:07 2021 -0400
libswan: ike_alg_dh_nss_modp_ops.c: nss_modp_clone_local_secret_ke: add a
???
??? if pexpect fails, and we are going to clone anyway, should we not use
New commits:
commit b33fb71f61dce66c0e18eb0380ab3221fc998376
Author: D. Hugh Redelmeier
Date: Sun Sep 5 11:37:36 2021 -0400
pluto: kernel.c: improve debug message in route_and_eroute()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
New commits:
commit 5f3a31626eba6aefc35a82b436db9516b25d69bd
Author: D. Hugh Redelmeier
Date: Sun Sep 5 22:22:17 2021 -0400
libswan/ttosaid.c: fix comment for ttosaid()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 2293faf5aae12ddf920c99bdb338fe9007b022ba
Author: D. Hugh Redelmeier
Date: Sun Sep 5 22:52:39 2021 -0400
pluto: kernel_xfrm.c: netlink_raw_policy(): use right type for .mode
mode in struct xfrm_user_tmpl isn't a bool (although that accidentally
works). Nor
New commits:
commit e0543f498cfc881c817c5ac1c0c2eecd58ff0ea4
Author: D. Hugh Redelmeier
Date: Thu Jul 29 13:31:03 2021 -0400
pluto: labeled_ipsec.c: fix spelling error in previous commit
commit 7ff5d57272f531ad0eee4893ea8aea209e67d00a
Author: D. Hugh Redelmeier
Date: Thu Jul 29 13:22
New commits:
commit 3186fae0f657e48affd7343b3cf1bfec3775852f
Author: D. Hugh Redelmeier
Date: Thu Jul 29 14:50:15 2021 -0400
libipsecconf: tiny simplification to parser.y
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit a7f126151a98b3ca5e11bc8358ef614170cf78f8
Author: D. Hugh Redelmeier
Date: Tue Sep 28 12:22:48 2021 -0400
pluto: kernel_xfrm.c: rewrite create_xfrm_migrate_sa() to make it simpler
The new version should have identical results (except for catching some
New commits:
commit 35de0797f640a6492b24bb7682c2ed02f090c341
Author: D. Hugh Redelmeier
Date: Mon Dec 6 11:13:00 2021 -0500
rsasigkey: add comment justifying code that Coverity Scan warns about
Coverity thinks that rand(2) should not be used by security-related
programs
New commits:
commit 2819a96ab86984b935088cf49a17229a54a90f14
Author: D. Hugh Redelmeier
Date: Mon Dec 6 12:34:52 2021 -0500
enumcheck: placate Coverity Scan; eliminate one heap use
Coverity didn't see that a second call to strchr couldn't yield NULL
if an earlier call
New commits:
commit 3e990ff054ca60ada98f83962e95cf8d0378bb22
Author: D. Hugh Redelmeier
Date: Sun Dec 19 15:24:00 2021 -0500
pluto: add "const" to all auto declarations of "ike_version" when immutable
Knowing that the ike_version is immutable should hel
New commits:
commit 692fe41d86e2458079a857d0a0ed9e838efd2de8
Author: D. Hugh Redelmeier
Date: Wed Nov 17 18:18:47 2021 -0500
pluto: ikev1.c: remove redundant test that worried Coverity Scan
After dereferencing md, the code tried to handle the case where md is NULL.
Since
New commits:
commit 18d9382b410197e3b02175978a8f29cc132d229f
Author: D. Hugh Redelmeier
Date: Fri Mar 25 12:25:27 2022 -0400
pluto: kernel.c: simplify fmt_common_shell_out()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 1062a663482b9b3841f0a48e5c99b4dd70757793
Author: D. Hugh Redelmeier
Date: Fri Mar 25 16:15:15 2022 -0400
pluto: tidy things around ipsec_proto_info.present and get_sa_info()
- get_sa_info does nothing for IPCOMP so don't call it for such SAs
- get rid
New commits:
commit 88de99f13e51e42de16eff8367e09c83ee3583c1
Author: D. Hugh Redelmeier
Date: Thu Mar 24 13:45:13 2022 -0400
pluto: kernel.c: simplify fmt_common_shell_out()
- prompted by Coverity Scan: NULL safety hidden by complicated control
flow. Fixed by merging
New commits:
commit f52734b489fe3039a54557fbdfb43ddaa2db00d7
Author: D. Hugh Redelmeier
Date: Sat Mar 26 18:29:54 2022 -0400
Pluto: more fiddling with show_established_child_details
Pervasive: rename get_sa_info get_sa_bundle_info to be more accurate
New commits:
commit 7a3d54b2275a2b08436cf7ea5156c19d29d21093
Author: D. Hugh Redelmeier
Date: Sat Feb 5 16:02:19 2022 -0500
pluto: ikev1_quick.c: paper over a bug in fc_try()
Coverity Scan found an uninitialized variable reference in fc_try.
I have initialize those variables
New commits:
commit 3e3e93b78d190090ed40e852278568658bf4d569
Author: D. Hugh Redelmeier
Date: Sun Feb 6 10:48:32 2022 -0500
pluto: remove last vestiges of KLIPS's ipsec* interface names
Simplifies kernel_linux.c's process_raw_ifaces().
It is now more like kernel_bsd.c's
New commits:
commit 29455c0e438613cc4487bd4e811c064a9b461f32
Author: D. Hugh Redelmeier
Date: Sun Feb 6 11:00:22 2022 -0500
pluto: fix a typo in comments
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org
New commits:
commit 95e464d78658080eae04a99da9d2aafed1b808cf
Author: D. Hugh Redelmeier
Date: Tue Feb 8 20:41:01 2022 -0500
improve Hugh's name.
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org/mailman
New commits:
commit 35596becd8732e0c5fec8f1ae7b6585b23d53576
Author: D. Hugh Redelmeier
Date: Sun Feb 6 17:09:00 2022 -0500
pluto kernel.c: simplify jam_common_shell_out()
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 537ac5b75a555bd54c07a3eff01091b35e782db5
Author: D. Hugh Redelmeier
Date: Sun Feb 6 18:05:34 2022 -0500
pluto crypt_dh_v1.c: simplify calc_skeyids_iv
Coverity Scan pointed out that local "hasher" was always dereferenced
so it must never have been
New commits:
commit b639690497ec524a222f25c5a2b46673a91e7d31
Author: D. Hugh Redelmeier
Date: Sun Feb 6 17:39:56 2022 -0500
pluto ikev2_hostpair.*: scatter a few "const"s
___
Swan-commit mailing list
Swan-commit@lists.libreswan
New commits:
commit 540a038eb7e8cec67657028c77d37eeb1bf12203
Author: D. Hugh Redelmeier
Date: Sun Feb 6 16:46:28 2022 -0500
pluto show.c: eliminate unreachable code
commit 8a187c8ff0cf8760a7a58c00764d1a85d23f5de1
Author: D. Hugh Redelmeier
Date: Sun Feb 6 16:33:09 2022 -0500
pluto
New commits:
commit 95aa219e0b1ff41a9faa864e1fb135072b849d29
Author: D. Hugh Redelmeier
Date: Sat Feb 5 18:18:27 2022 -0500
pluto: ikev2_create_child_sa.c: avoid NULL dereferences
Coverity Scan found these.
___
Swan-commit mailing list
New commits:
commit f703f4d32ab4d01199f7755fde1a193d96e881c5
Author: D. Hugh Redelmeier
Date: Sat Sep 9 10:33:04 2023 -0400
confread: convince Clang that a variable is not NULL
Too bad there isn't a type annotation to declare that a pointer will never
be NULL
New commits:
commit 6c58b5aad7c026cf107b036c7dc778d6ed4788c1
Author: D. Hugh Redelmeier
Date: Tue Jun 7 01:01:31 2022 -0400
pluto: for Coverity Scan change definition of ipsec_attr_val_descs_roof
Replace variable ipsec_attr_val_descs_roof with enum
IPSEC_ATTR_VAL_DESCS_ROOF
New commits:
commit ee2d529b464f7ec20bcc9356640ccfd8d40d48f0
Author: D. Hugh Redelmeier
Date: Tue Jun 7 00:21:19 2022 -0400
libswan: ttoaddress.c: tweak colon() to make Coverity Scan happy
The induction variable i goes up by steps of two.
Furthermore, sizeof(u.byte) is even
New commits:
commit 49a0f0c78ee728a45b5f80a562d6ba162446473b
Author: D. Hugh Redelmeier
Date: Mon Jun 6 23:53:01 2022 -0400
testing: ip_address_check.c
Handle missing case: should make test more robust and quiet Coverity Scan
___
Swan
New commits:
commit 4120dc96a004af55630cb70a664e23c19d1cce9b
Author: D. Hugh Redelmeier
Date: Sat Jun 18 16:08:57 2022 -0400
testing: jambufcheck.c: simplify check_jambuf() to help Coverity Scan
understand it
___
Swan-commit mailing list
Swan
New commits:
commit 71d59dfe65a91c6800fb308a973628d44758c1f0
Author: D. Hugh Redelmeier
Date: Tue Jul 26 13:58:03 2022 -0400
pluto: kernel_xfrm: netlink_policy_expire() exits iff it should not
A test was backwards. In effect, netlink_policy_expire() was a no-op
in good times
New commits:
commit 8cbf89d3e0b2c73f723bab1428e213493fa84f64
Author: D. Hugh Redelmeier
Date: Thu Aug 18 00:51:45 2022 -0400
mk/config.mk: fix typo in comment
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit 3f3c5d657fce769bbe98959528565446e2256b6f
Author: D. Hugh Redelmeier
Date: Tue Aug 16 12:00:06 2022 -0400
mk/kvm-targets.mk: fix typo in comment
___
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https
New commits:
commit e93da2d14f735792bdadd5d5739be14a02db8d7d
Author: D. Hugh Redelmeier
Date: Sun Jan 22 15:27:38 2023 -0500
pluto: updown.c: do_updown() remove redundant conjunct
The test for spd != NULL must be redundant since the subsequent call
to do_updown_verb requires
New commits:
commit b2df16e5f3eeb252caafce94f697f274aa55b9d8
Author: D. Hugh Redelmeier
Date: Sun Jan 22 16:08:09 2023 -0500
kernel.c: simplify control flow of install_outbound_ipsec_kernel_policies()
The use of the variable "ok" was more intricate than required.
New commits:
commit fe56260b04a40f4fbd94688c5029aaf5479e7b79
Author: D. Hugh Redelmeier
Date: Mon Apr 24 03:34:04 2023 -0400
testing/pluto/ikev2-68-sa-clones-pktgen/pktgen.sh: change fgrep to grep
___
Swan-commit mailing list
Swan-commit
New commits:
commit 18611dc4276db2861c89d1bee431a8f69d507239
Author: D. Hugh Redelmeier
Date: Wed Jul 26 00:55:36 2023 -0400
ttoaddress_dns.c: add passert to help lclint and other readers
___
Swan-commit mailing list
Swan-commit
New commits:
commit 9d8189f5f40f8c311cc239b1c26afc1d2bf40128
Author: D. Hugh Redelmeier
Date: Wed Jul 26 01:35:16 2023 -0400
netlink_attrib: guard memcpy from invalid pointers
A common assumption is that memcpy address arguments need not be valid
if the length is zero. The C
New commits:
commit f2c2917fdfc70ba04f02f30cb8c909fa734607ea
Author: D. Hugh Redelmeier
Date: Wed Jul 26 01:54:46 2023 -0400
pluto packet.c: conform to memcpy rules
The C standare (suprisingly) requires memcpy pointer args
to be to valid addresses, even if the length is zero
701 - 769 of 769 matches
Mail list logo
