Re: [swift-corelibs-dev] URLSession test fest!

i <vast.gra...@gmail.com>Date: 03/10/2017 04:47AMCc: Pushkar N Kulkarni <pushkar...@in.ibm.com>, swift-corelibs-dev <swift-corelibs-dev@swift.org>Subject: Re: [swift-corelibs-dev] URLSession test fest!Just one outside data point on this: as someone who's been wanting to cont

Re: [swift-corelibs-dev] URLSession test fest!

er mailto:anthony.par...@apple.com>> > From: Peter Tomaselli mailto:vast.gra...@gmail.com>> > Date: 03/10/2017 04:47AM > Cc: Pushkar N Kulkarni <mailto:pushkar...@in.ibm.com>>, swift-corelibs-dev > mailto:swift-corelibs-dev@swift.org>> > Subject: Re: [swift-corelibs

Re: [swift-corelibs-dev] URLSession test fest!

> On Jan 25, 2017, at 2:02 AM, Pushkar N Kulkarni via swift-corelibs-dev > wrote: > > That sounds like a great plan, Tony! I am keen on contributing. > > We all know that current set of unit tests for URLSession are extremely > trivial and nowhere close to it's real-world use cases! We've tr

Re: [swift-corelibs-dev] URLSession test fest!

Kulkarni <pushkar...@in.ibm.com>, swift-corelibs-dev <swift-corelibs-dev@swift.org>Subject: Re: [swift-corelibs-dev] URLSession test fest!Just one outside data point on this: as someone who's been wanting to contribute to the test fest, I agree that being able to test against http

Re: [swift-corelibs-dev] URLSession test fest!

Just one outside data point on this: as someone who's been wanting to contribute to the test fest, I agree that being able to test against httpbin.org (or some other pre-existing server — as opposed to the loopback server) would make it much easier to make useful contributions. Not that the loo

Re: [swift-corelibs-dev] URLSession test fest!

Hi Pushkar, Another option is to continue to use httpbin.org , but make the tests that use that network service not part of the normal unit tests but runnable on demand by us as we develop. That means we don’t have to reimplement the whole thing but we at least have some to

Re: [swift-corelibs-dev] URLSession test fest!

Hi Tony, PRs 911 and 913 reminded me of this conversation you started. The current unit testing infrastructure for URLSession may prove insufficient for future contributions. I've been looking at these tests written by Mike Ferenduros and they appear quite exhaustive! The only issue is that they co

Re: [swift-corelibs-dev] URLSession test fest!

eaking the CI builds, causing much agony > to many! Can you tell me more about this solution you propose? > > > > Thanks! > > Pushkar N Kulkarni, > IBM Runtimes > > *Simplicity is prerequisite for reliability - Edsger W. Dijkstra* > > > > -swift-corelibs-dev-b

Re: [swift-corelibs-dev] URLSession test fest!

relibs-dev-boun...@swift.org wrote: -To: swift-corelibs-dev <swift-corelibs-dev@swift.org>From: Peter Tomaselli via swift-corelibs-dev Sent by: swift-corelibs-dev-boun...@swift.orgDate: 02/03/2017 08:11AMSubject: Re: [swift-corelibs-dev] URLSession test fest!Following up on this…I’m wonder

Re: [swift-corelibs-dev] URLSession test fest!

Following up on this… I’m wondering if anyone has any info on what happened with the (rather more elaborate) “loopback” server and set of tests from @danieleggert’s PR #299: https://github.com/apple/swift-corelibs-foundation/pull/299

Re: [swift-corelibs-dev] URLSession test fest!

Rad, thanks Tony. I can run all the tests now. Hoping to have some time soon to dig in and see if I can make a contribution. Love that this thing is spinning up its own HTTP server for this — seems real fun. Cheers, Peter > On Jan 30, 2017, at 5:46 PM, Tony Parker wrote: > > I see what this

Re: [swift-corelibs-dev] URLSession test fest!

I see what this problem is. I’ll have a PR up shortly to fix it. - Tony > On Jan 30, 2017, at 2:33 PM, Tony Parker via swift-corelibs-dev > wrote: > > Hi Peter, > >> On Jan 29, 2017, at 11:05 AM, Peter Tomaselli via swift-corelibs-dev >> mailto:swift-corelibs-dev@swift.org>> wrote: >> >> Hi

Re: [swift-corelibs-dev] URLSession test fest!

Hi Peter, > On Jan 29, 2017, at 11:05 AM, Peter Tomaselli via swift-corelibs-dev > wrote: > > Hi all, another new person here. Perfect, the more the merrier. > This sounded like a lot of fun so I figured I would try and pitch in! > However, I’m unable to get off the ground getting the curren

Re: [swift-corelibs-dev] URLSession test fest!

Hi all, another new person here. This sounded like a lot of fun so I figured I would try and pitch in! However, I’m unable to get off the ground getting the current tests running. I’m sure it’s something I’m doing wrong, since I am completely new to the project, but I’d love it if anyone had any

Re: [swift-corelibs-dev] URLSession test fest!

Hi Paul, > On Jan 27, 2017, at 12:51 AM, Paul Stringer via swift-corelibs-dev > wrote: > > Hi Tony, > > First post and excited to join the party. Great, welcome! > > I'm sure this may have been solved many times over by the community already. > Maybe we can collect some ideas on this. In t

Re: [swift-corelibs-dev] URLSession test fest!

Hi Tony, First post and excited to join the party. I'm sure this may have been solved many times over by the community already. Maybe we can collect some ideas on this. In the spirit of a small step to get things moving forward I'm sharing my own approach which has proven very effective for ma

Re: [swift-corelibs-dev] URLSession test fest!

That sounds like a great plan, Tony! I am keen on contributing. We all know that current set of unit tests for URLSession are extremely trivial and nowhere close to it's real-world use cases! We've tried using external/public API endpoints in the tests, but intermittent connection failures (network