Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

> On Nov 1, 2017, at 9:16 AM, Ben Cohen via swift-dev > wrote: > > > >> On Oct 31, 2017, at 10:11 PM, Chris Lattner via swift-dev >> wrote: >> >> On Oct 31, 2017, at 9:07 AM, Stephen Canon via swift-dev >> wrote: >>>

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.0) #551

Title: Report [FAILURE] oss-swift-4.0-package-osx [#551] Build URL:https://ci.swift.org/job/oss-swift-4.0-package-osx/551/ Project:oss-swift-4.0-package-osx Date of build:Thu, 02 Nov 2017 21:29:39 -0500 Build duration:2 hr 44 min Changes No

Re: [swift-dev] deprecating -Ounchecked

> On Nov 2, 2017, at 9:52 AM, Erik Eckstein via swift-dev > wrote: > > Hi, > > I’d like to propose to deprecate the -Ounchecked swift optimization mode. > > The -Ounchecked mode actually contradicts one of the main goals of swift: to > be a safe language. > In the past

Re: [swift-dev] Zero-cost 'Service Provider Interface'/Signature Packages

My personal preference is to: 1. Do nothing for now, but encourage publishing standardized protocols to solve this need. 2. Hope for a future with WMO+LTO magic which recovers the performance, for the case where the entire application ends up using one implementation. You can manage some of the

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #610

Title: Report [FAILURE] oss-swift-package-osx [#610] Build URL:https://ci.swift.org/job/oss-swift-package-osx/610/ Project:oss-swift-package-osx Date of build:Thu, 02 Nov 2017 18:32:36 -0500 Build duration:2 hr 57 min Changes Commit

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.1) #84

Title: Report [FAILURE] oss-swift-4.1-package-osx [#84] Build URL:https://ci.swift.org/job/oss-swift-4.1-package-osx/84/ Project:oss-swift-4.1-package-osx Date of build:Thu, 02 Nov 2017 18:36:18 -0500 Build duration:2 hr 53 min Changes Commit

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

On Thu, Nov 2, 2017 at 7:10 PM, Stephen Canon wrote: > On Nov 2, 2017, at 7:22 PM, Xiaodi Wu via swift-dev > wrote: > > On Thu, Nov 2, 2017 at 5:22 PM, Matthew Johnson > wrote: > >> >> On Nov 2, 2017, at 5:20 PM, Jonathan Hull via

Re: [swift-dev] "Near-miss" warnings for protocol conformances

> On Oct 26, 2017, at 9:28 PM, Douglas Gregor via swift-dev > wrote: > > Unlabeled single-value initializers are probably going to cause a number of > false positives, because we can’t figure out which one we meant. When we're dealing with unlabeled initializers, can we

[swift-dev] Zero-cost 'Service Provider Interface'/Signature Packages

Hi swift-dev, I talked to a few people about this problem and we agreed that it is a problem and that it needs to be discussed. I didn't quite know where it would fit best but let's go with swift-dev, please feel free to tell to post it elsewhere if necessary. And apologies for the long mail,

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

On Nov 2, 2017, at 7:22 PM, Xiaodi Wu via swift-dev wrote: > On Thu, Nov 2, 2017 at 5:22 PM, Matthew Johnson > wrote: > >> On Nov 2, 2017, at 5:20 PM, Jonathan Hull via swift-dev >

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

On Thu, Nov 2, 2017 at 5:22 PM, Matthew Johnson wrote: > > On Nov 2, 2017, at 5:20 PM, Jonathan Hull via swift-dev < > swift-dev@swift.org> wrote: > > It looks like we have a good solution. Per Steve and David’s suggestions: > > 1) Make FloatingPoint == reflexive > > 2)

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

Thanks! > On Nov 2, 2017, at 3:26 PM, Xi Ge wrote: > > It seems my tentative fix doesn't fix this issue. As Erik suggested, I've > reverted the commit on master. > > > -- > Xi > > > >> On Nov 2, 2017, at 1:28 PM, Erik Eckstein >

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

It seems my tentative fix doesn't fix this issue. As Erik suggested, I've reverted the commit on master. -- Xi > On Nov 2, 2017, at 1:28 PM, Erik Eckstein wrote: > > Any update on this? > > Can you revert in the meantime if you’re not able to fix it within the next >

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

> On Nov 2, 2017, at 5:20 PM, Jonathan Hull via swift-dev > wrote: > > It looks like we have a good solution. Per Steve and David’s suggestions: > > 1) Make FloatingPoint == reflexive > > 2) Add &== to FloatingPoint for those who specifically want IEEE behavior > > 3)

Re: [swift-dev] Rationalizing FloatingPoint conformance to Equatable

It looks like we have a good solution. Per Steve and David’s suggestions: 1) Make FloatingPoint == reflexive 2) Add &== to FloatingPoint for those who specifically want IEEE behavior 3) Add a warning + fixit to ‘a != a’ We should take this to evolution... Thanks, Jon > On Nov 1, 2017, at

Re: [swift-dev] deprecating -Ounchecked

A -1 from me to deprecating the mode. I’ve been using Swift in high-performance situations such as in a game engine, where in particular thing like integer overflow checks become a measurable cost in tight inner loops. Currently I can’t use Array in many places due to ownership issues and

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

It seems to be a false positive of Asan container overflow checker. I've a PR to tentatively fix it. https://github.com/apple/swift/pull/12720 It's still testing -- Xi > On Nov 2, 2017, at 1:28 PM, Erik Eckstein wrote: > >

Re: [swift-dev] deprecating -Ounchecked

> On Nov 2, 2017, at 4:35 PM, Johannes Weiß via swift-dev > wrote: >> On 2 Nov 2017, at 1:33 pm, Erik Eckstein wrote: >> >> >> >>> On Nov 2, 2017, at 10:51 AM, Johannes Weiß wrote: >>> >>> Definitely a +1 from me, a haven't

Re: [swift-dev] deprecating -Ounchecked

> On 2 Nov 2017, at 1:33 pm, Erik Eckstein wrote: > > > >> On Nov 2, 2017, at 10:51 AM, Johannes Weiß wrote: >> >> Definitely a +1 from me, a haven't recently seen much of a difference either. >> >> Said that I do sometimes use it in a

Re: [swift-dev] deprecating -Ounchecked

> On Nov 2, 2017, at 10:51 AM, Johannes Weiß wrote: > > Definitely a +1 from me, a haven't recently seen much of a difference either. > > Said that I do sometimes use it in a micro-benchmark just to convince myself > we don't lose much performance on the checks.

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

Any update on this? Can you revert in the meantime if you’re not able to fix it within the next hour? > On Nov 2, 2017, at 9:26 AM, Xi Ge wrote: > > Ack, will take a look soon. > > Xi > >> On Nov 2, 2017, at 9:13 AM, Douglas Gregor >

Re: [swift-dev] deprecating -Ounchecked

I am +1 in general, but I do feel there is a legitimate need for this for a very very small subset of code. It would feel unfortunate to need to drop to C for that — would an equivalent attribute be an alternative? - Daniel > On Nov 2, 2017, at 9:52 AM, Erik Eckstein via swift-dev

Re: [swift-dev] deprecating -Ounchecked

Definitely a +1 from me, a haven't recently seen much of a difference either. Said that I do sometimes use it in a micro-benchmark just to convince myself we don't lose much performance on the checks. Usually it turns out fine, I'm happy and move on. But I guess there's some value in being able

[swift-dev] deprecating -Ounchecked

Hi, I’d like to propose to deprecate the -Ounchecked swift optimization mode. The -Ounchecked mode actually contradicts one of the main goals of swift: to be a safe language. In the past we didn’t see lot of significant performance differences compared to -O (there were some improvements but

[swift-dev] Temporary build failures while reading the Swift module?

Despite deleting my module cache and doing a clean build, I’m seeing spurious and temporary build failures like what follows. Doing an incremental build after the failure weirdly results in a successful build. Any ideas? Is this a missing build dependency? Note: I’m using the Xcode 9B55 on

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

Ack, will take a look soon. Xi > On Nov 2, 2017, at 9:13 AM, Douglas Gregor wrote: > > Xi, this is failing in > > > swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, > unsigned int) > > which might be related to your

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

Xi, this is failing in swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, unsigned int) which might be related to your recent changes. - Doug > On Nov 2, 2017, at 1:45 AM, no-re...@swift.org wrote: > > [FAILURE]

Re: [swift-dev] "Near-miss" warnings for protocol conformances

> On Nov 2, 2017, at 7:47 AM, Ted Kremenek wrote: > > > >> On Oct 31, 2017, at 11:09 PM, Douglas Gregor wrote: >> >> >> >>> On Oct 31, 2017, at 11:08 PM, Ted Kremenek wrote: >>> >>> >>> On Oct 26, 2017, at 9:28 PM,

Re: [swift-dev] "Near-miss" warnings for protocol conformances

> On Oct 31, 2017, at 11:09 PM, Douglas Gregor wrote: > > > >> On Oct 31, 2017, at 11:08 PM, Ted Kremenek wrote: >> >> >> >>> On Oct 26, 2017, at 9:28 PM, Douglas Gregor via swift-dev >>> wrote: >>> >>> Unlabeled single-value