Re: [swift-dev] JIRA labels (no worries)

2016-05-27 Thread Brian Gesiak via swift-dev
Hey Jordan, Thanks for the email! Very good point -- and I definitely felt weird assigning "Swift 3" labels to tasks, considering it's not up to me to decide what goes into Swift 3 or not. Still, I think it's helpful to see, at a glance, what are the time-sensitive tasks for a given project.

Re: [swift-dev] [swift-lldb-dev] Proposal for Swift and Ubuntu releases

2016-06-22 Thread Brian Gesiak via swift-dev
Thanks for raising this discussion, Todd! Any input from the core team here? The Swift Android build doesn't currently work for Ubuntu 14; see https://bugs.swift.org/browse/SR-1321. I'd like to know whether I should prioritize fixing this, or whether I should focus on getting the build ready for

Re: [swift-dev] [SR-710][RFC] Automatically detecting XCTest test methods on Linux: Reflection? SourceKit?

2016-04-03 Thread Brian Gesiak via swift-dev
Thanks for the feedback, Dmitri! I think I misstated options #2 and #3: where I typed "move business logic like IsTestCandidate to libIDE", I meant "move a lot of the non-XCTest-specific logic from SourceKit to libIDE, such that implementing IsTestCandidate would be trivial in SourceKit and our

[swift-dev] [SR-710][RFC] Automatically detecting XCTest test methods on Linux: Reflection? SourceKit?

2016-04-03 Thread Brian Gesiak via swift-dev
Hello all! SR-710 tracks a major goal for Swift 3: having SwiftPM/corelibs-xctest automatically generate a list of test methods to execute. The implementations we’re considering span various parts of the codebase: libIDE, SourceKit, the reflection APIs, etc.

Re: [swift-dev] [SR-710][RFC] Automatically detecting XCTest test methods on Linux: Reflection? SourceKit?

2016-04-03 Thread Brian Gesiak via swift-dev
Hmm... but then wouldn't that more tightly couple the test discovery tool and the Swift compiler? In an earlier email you said you "like #3 better [...] because that would decouple the test discovery tool from the Swift compiler." I think that part is confusing me. In any case, so far it sounds

Re: [swift-dev] [SR-710][RFC] Automatically detecting XCTest test methods on Linux: Reflection? SourceKit?

2016-04-24 Thread Brian Gesiak via swift-dev
Thanks to this commit it looks as if IsTestCandidate has been moved out of SourceKit and into libIndex: - isTestCandidate(swift::ValueDecl)

Re: [swift-dev] [SR-710][RFC] Automatically detecting XCTest test methods on Linux: Reflection? SourceKit?

2016-05-09 Thread Brian Gesiak via swift-dev
Thanks for the feedback, everyone! Porting SourceKit to Linux seems like a reasonable solution to me. Still, there are 354 lines of code in tools/SourceKit that reference "XPC", so a Linux port will take more than a few lines of source code changes. I imagine we'll need to insert some sort of

Re: [swift-dev] [swift-lldb-dev] Proposal for Swift and Ubuntu releases

2016-06-27 Thread Brian Gesiak via swift-dev
Todd, Excellent, thanks! Six months seems like plenty of time for me to fix https://bugs.swift.org/browse/SR-1321. :) I'll be looking forward to seeing the migrations, good luck! - Brian Gesiak On Thu, Jun 23, 2016 at 11:14 PM, Todd Fiala wrote: > Update: > > I’m now able

Re: [swift-dev] Swift incremental compile profiling

2016-08-29 Thread Brian Gesiak via swift-dev
Thank you, Jordan! I had guessed there wouldn't be much low-hanging fruit here -- I'm sure a ton of work has been put into improving compilation time, after all. Thanks for all the great explanations. The one thing we *could* do here is improve -driver-show-incremental. I > haven’t used it in a

Re: [swift-dev] Cross Repository Testing with Swift CI

2016-09-09 Thread Brian Gesiak via swift-dev
Mishal, this is absolutely fantastic. Excellent work, thank you! - Brian Gesiak On Thu, Sep 8, 2016 at 7:48 PM, mishal_shah via swift-dev < swift-dev@swift.org> wrote: > Cross Repository Testing with Swift CI > > Swift CI now supports the ability to test multiple pull request across >

Re: [swift-dev] Android: wrong ld (linker) keeps being invoked

2016-09-25 Thread Brian Gesiak via swift-dev
Eric, This is definitely something I'd like to improve. I believe karwa's new `-tools-directory` option (https://github.com/apple/swift/pull/2912 and https://github.com/apple/swift/pull/4543) could take care of this problem. If so, we should update docs/Android.md to recommend using that. Could

Re: [swift-dev] Reporting/Debugging Slow Swift Compile Time

2016-10-05 Thread Brian Gesiak via swift-dev
Hi Ben, I'd really like to see improvements here as well. I don't know what reports would be useful to the Swift team, but allow me to point out https://github.com/apple/swift/commit/18c75928639acf0ccf0e1fb6729eea75bc09cbd5, which adds a -warn-long-function-bodies option that you may be able to

Re: [swift-dev] Android: Build error: No such module "SwiftGlibc"

2016-09-19 Thread Brian Gesiak via swift-dev
Swift Android builds successfully for me. Following all the preliminary steps from https://github.com/apple/swift/blob/master/docs/Android.md, such as building libicu, I can successfully build with the following command on the master branch of apple/swift this morning: utils/build-script -R \

Re: [swift-dev] Extending Swift's continuous integration

2016-09-19 Thread Brian Gesiak via swift-dev
Oops, forgot to actually CC people. My bad! On Mon, Sep 19, 2016 at 8:02 AM, Brian Gesiak wrote: > Hello all, > (+cc Ted Kremenek, John Holdsworth, Philippe Hausler) > > Following up on https://github.com/apple/swift-corelibs-foundation/ > pull/622#issuecomment-247630142,

[swift-dev] PVS-Studio static analysis results for the Swift project

2016-11-07 Thread Brian Gesiak via swift-dev
Hello all, The latest LLVM Weekly featured a blog post by some folks who make a static analyzer named PVS-Studio. They published a blog post of the errors they encountered in the LLVM project. Although the report contained many

[swift-dev] [RFC] Modify the build system to enable/disable ObjC interop for any platform

2016-11-28 Thread Brian Gesiak via swift-dev
Hello all! While reviewing https://github.com/apple/swift/pull/5904, I had a crazy thought, and I'd like to get some feedback on it. Here's my original comment < https://github.com/apple/swift/pull/5904#discussion_r89797900>. Basically, I notice that we have two sets of targets we compile the

Re: [swift-dev] [RFC] Modify the build system to enable/disable ObjC interop for any platform

2016-11-29 Thread Brian Gesiak via swift-dev
v@swift.org> wrote: > >> On Nov 28, 2016, at 7:26 AM, Brian Gesiak via swift-dev < > swift-dev@swift.org> wrote: > >> > >> Hello all! > >> > >> While reviewing https://github.com/apple/swift/pull/5904, I had a > crazy thought, and I'd like to get

[swift-dev] Performance issues in automatic reference counting (ARC)?

2016-12-17 Thread Brian Gesiak via swift-dev
Hello all! I really enjoyed Chris Lattner's slides from his talk at IBM < http://researcher.watson.ibm.com/researcher/files/us-lmandel/lattner.pdf>. The speaker notes mention ARC: "There are two principle downsides to ARC that people cite: one is the need for atomic increment/decrements, which

[swift-dev] History of build-script, build-script-impl, and CMake?

2017-09-08 Thread Brian Gesiak via swift-dev
Hello all, I'm hoping a long-time Swift contributor can help shed some light on how the apple/swift repository ended up with a utils/build-script, a utils/build-script-impl, and CMake files. Based on the Git history, I've pieced together the following: - July 17, 2010: Chris Lattner first adds

[swift-dev] Fwd: History of build-script, build-script-impl, and CMake?

2017-09-08 Thread Brian Gesiak via swift-dev
Oops, sent this off-list accidentally. -- Forwarded message -- From: Brian Gesiak Date: Fri, Sep 8, 2017 at 3:38 PM Subject: Re: [swift-dev] History of build-script, build-script-impl, and CMake? To: Jordan Rose Great, thanks for the

Re: [swift-dev] Highlighting other platforms for Swift?

2017-11-15 Thread Brian Gesiak via swift-dev
For what it's worth, the build instructions for Android, as well as several build and test scripts, exist within the apple/swift repository. For example: https://github.com/apple/swift/blob/master/docs/Android.md I'm very much looking forward to the rollout of externally hosted CI bots! Last I

[swift-dev] Potential contributions to compilation time reporting?

2017-11-12 Thread Brian Gesiak via swift-dev
Hello all! I'm looking for a body of work to do on the Swift compiler for an upcoming programmer retreat I'm attending in January [1]. I've read a lot of blog posts with tips for diagnosing slow Swift compile times [2], and I was wondering if I could contribute to tooling in this area. (Just to

Re: [swift-dev] SR-3423 Starter questions

2017-11-13 Thread Brian Gesiak via swift-dev
It sounds like you haven't run the 'utils/update-checkout --clone' script. That pulls down the cmark repository, and so should take care of that error. The Swift README has step-by-step instructions, which I think mention the 'update-checkout' script. You may want to try following those from top

Re: [swift-dev] Potential contributions to compilation time reporting?

2017-11-19 Thread Brian Gesiak via swift-dev
Thanks for the reply, Graydon, and for your other email on the topic ! I need to take more time to look into some of the things you mentioned, but I won't be able to do so in earnest for another few days. In the

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1110

2017-10-19 Thread Brian Gesiak via swift-dev
Strange, CI appeared to have passed on my pull request for this change. I'll send a fix ASAP, sorry for the trouble. - Brian Gesiak From: no-re...@swift.org Sent: Thursday, October 19, 2017 5:09:14 PM To: modoca...@gmail.com;

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #1110

2017-10-19 Thread Brian Gesiak via swift-dev
I prepared a fix here: https://github.com/apple/swift/pull/12518 Sorry for the inconvenience! On Thu, Oct 19, 2017 at 5:12 PM, Brian Gesiak via swift-dev < swift-dev@swift.org> wrote: > Strange, CI appeared to have passed on my pull request for this change. > I'll send a fix