Re: [swift-dev] COW for non-mutating methods

2016-12-01 Thread Joe Groff via swift-dev
> On Dec 1, 2016, at 3:29 AM, Patrick Pijnappel via swift-dev > wrote: > > I'm implementing a COW big int type but am running into problems with > non-mutating functions (e.g. the + operator). Simplified example code below > shows AFAIK the default way to implement COW,

Re: [swift-dev] -Onone @inline(__always)?

2016-12-01 Thread Andrew Trick via swift-dev
> On Dec 1, 2016, at 11:48 AM, Andrew Trick wrote: > > Responding on swift-dev to what turned into an interesting discussion… > >> On Dec 1, 2016, at 11:19 AM, Joe Groff > > wrote: >> >>> >>> On Dec 1, 2016, at 11:18 AM, Joe

Re: [swift-dev] No commit emails

2016-12-01 Thread Kenny Leung via swift-dev
Hi All. Just a heads up. We got a big bolus on November 18, and then nothing after that. Thanks. -Kenny > On Nov 18, 2016, at 4:18 PM, Jordan Rose wrote: > > Thanks for the heads-up. I think our old notifier system is finally invalid > after a network

Re: [swift-dev] -Onone @inline(__always)?

2016-12-01 Thread Joe Groff via swift-dev
> On Dec 1, 2016, at 11:48 AM, Andrew Trick wrote: > > Responding on swift-dev to what turned into an interesting discussion… > >> On Dec 1, 2016, at 11:19 AM, Joe Groff wrote: >> >>> >>> On Dec 1, 2016, at 11:18 AM, Joe Groff wrote:

Re: [swift-dev] -Onone @inline(__always)?

2016-12-01 Thread Andrew Trick via swift-dev
Responding on swift-dev to what turned into an interesting discussion… > On Dec 1, 2016, at 11:19 AM, Joe Groff wrote: > >> >> On Dec 1, 2016, at 11:18 AM, Joe Groff wrote: >> >>> >>> On Dec 1, 2016, at 11:16 AM, Andrew Trick wrote: >>>

Re: [swift-dev] -Onone @inline(__always)?

2016-12-01 Thread Joe Groff via swift-dev
> On Dec 1, 2016, at 12:11 PM, Andrew Trick wrote: > > >> On Dec 1, 2016, at 11:55 AM, Joe Groff wrote: >> >> >>> On Dec 1, 2016, at 11:48 AM, Andrew Trick wrote: >>> >>> Responding on swift-dev to what turned into an interesting

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Jordan Rose via swift-dev
Xcode needs to know that you're building in WMO mode, so rather than putting -whole-module-optimization in your "Other Swift Flags", put -Onone there. It's an ugly hack but it should work in the near term. We do want to work to make this drastic speed difference go away, so if you're able we

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Just running a quick trial before and after I made this change in our project, we were previously seeing builds of our main target that took just under 13min. With this hack, a clean debug build takes about 4.5min. Ben On Thu, Dec 1, 2016 at 1:33 PM, Ben Asher wrote: >

[swift-dev] Details of what source compatibility with Swift 3 means

2016-12-01 Thread ematejska--- via swift-dev
Hi, (I already sent this to swift-evolution yesterday but cross-posting.) One of the Stage 1 goals of Swift 4 is source compatibility with Swift 3, but what does that precisely mean and how will we determine if the goal is achieved? This is the current proposal of how this goal ties back to

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 3:13 PM, Ben Asher via swift-dev > wrote: > > Just running a quick trial before and after I made this change in our > project, we were previously seeing builds of our main target that took just > under 13min. With this hack, a clean debug build takes

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Sure! Thanks for reminding me. I'll follow up on that, test, and get back to you. Ben On Thu, Dec 1, 2016 at 2:48 PM, Mark Lacey wrote: > > On Dec 1, 2016, at 3:13 PM, Ben Asher via swift-dev > wrote: > > Just running a quick trial before and after I

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
Sure thing! I’ll see if I can put small reproducers together tomorrow. Ben On Thu, Dec 1, 2016 at 7:08 PM, Mark Lacey wrote: > > On Dec 1, 2016, at 5:48 PM, Ben Asher via swift-dev > wrote: > > The build failed compiling 3 files in our project. Our

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Mark Lacey via swift-dev
> On Dec 1, 2016, at 5:48 PM, Ben Asher via swift-dev > wrote: > > The build failed compiling 3 files in our project. Our app is crashing that > snapshot; here is some output from the failures: It would be awesome if you could come up with small reproducers for these and

Re: [swift-dev] -whole-module-optimization with -Onone

2016-12-01 Thread Ben Asher via swift-dev
The build failed compiling 3 files in our project. Our app is crashing that snapshot; here is some output from the failures: - Assertion failed: (newType == type || (isa(newType) && cast(newType)->getNumElements() == 1 && cast(newType).getElementType(0) == type)), function rewriteType, file

[swift-dev] [Swift CI] Build Failure: 0. OSS - LLDB Incremental - OS X (master) #4921

2016-12-01 Thread no-reply--- via swift-dev
Title: Report [FAILURE] oss-lldb-incremental-osx [#4921] Build URL:https://ci.swift.org/job/oss-lldb-incremental-osx/4921/ Project:oss-lldb-incremental-osx Date of build:Thu, 01 Dec 2016 15:23:45 -0800 Build duration:1 hr 29 min Identified problems:Assertion failure:

[swift-dev] COW for non-mutating methods

2016-12-01 Thread Patrick Pijnappel via swift-dev
I'm implementing a COW big int type but am running into problems with non-mutating functions (e.g. the + operator). Simplified example code below shows AFAIK the default way to implement COW, but the non-mutating method doesn't identify the reference as unique (even with -O), resulting in a

Re: [swift-dev] Automatically building SourceKit on Linux

2016-12-01 Thread Alex Blewitt via swift-dev
So the 5861/5862 have been merged now, which means that we can build SourceKit on Linux with: swift/utils/build-script -R -T --libdispatch -- --reconfigure swift/utils/build-script -R -T --libdispatch --extra-cmake-options="-DSWIFT_BUILD_SOURCEKIT:BOOL=TRUE" -- --reconfigure I'd like to get