Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

I think there are docs on this in the main README or in a CONTRIBUTING file. Mishal (+CC) knows for sure. Michael > On Aug 9, 2017, at 5:41 AM, David Zarzycki via swift-dev > wrote: > > Hi Slava, > > Thanks! I appreciate the suggestion to run tests, but what I’ve tried in the > past, @swift

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

Hi Slava, Thanks! I appreciate the suggestion to run tests, but what I’ve tried in the past, @swift-ci ignored me. Is there a whitelist for who can request that tests be run? That would make sense from a security perspective. Dave > On Aug 8, 2017, at 23:48, Slava Pestov wrote: > > I see y

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

I see you’re two steps ahead of me already: https://github.com/apple/swift/pull/11397 This looks good, nice catch! Slava > On Aug 8, 2017, at 8:45 PM, Slava Pestov wrote: > > >> On Aug 8, 2017, at 3:34 PM, David Zarzycki via swift-dev >> wrote:

Re: [swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

> On Aug 8, 2017, at 3:34 PM, David Zarzycki via swift-dev > wrote: > > In ConstraintSystem::performMemberLookup(), constructors with “simple” names > have a dedicated lookup path. In contrast, constructors with compound names > are handled by the normal lookup. If I delete this code and let

[swift-dev] 107 lines of "dead" code in ConstraintSystem::performMemberLookup?

In ConstraintSystem::performMemberLookup(), constructors with “simple” names have a dedicated lookup path. In contrast, constructors with compound names are handled by the normal lookup. If I delete this code and let the normal lookup path handle both simple and compound named constructors, I fi