Re: [swift-evolution] [SE-0088] Dispatch API names

2016-07-14 Thread Matt Wright via swift-evolution
> On Jul 14, 2016, at 3:44 AM, Karl wrote: > > I just discovered this thread by accident - thank the Lord I’m not the only > one who feels like this about the new Dispatch API! > >> On 8 Jul 2016, at 04:16, Darren Mo via swift-evolution >>

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-07-14 Thread Karl via swift-evolution
I just discovered this thread by accident - thank the Lord I’m not the only one who feels like this about the new Dispatch API! > On 8 Jul 2016, at 04:16, Darren Mo via swift-evolution > wrote: > > Should I create a bug report for changing `DispatchQueue.after` and

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-07-07 Thread Jordan Rose via swift-evolution
> On Jun 21, 2016, at 16:46, Darren Mo via swift-evolution > wrote: > > On Jun 21, 2016, at 5:24 PM, Matt Wright > wrote: >>> On Jun 20, 2016, at 7:12 PM, Xiaodi Wu via swift-evolution >>>

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-07-07 Thread Darren Mo via swift-evolution
Should I create a bug report for changing `DispatchQueue.after` and `DispatchSource.read`? Darren > On Jun 21, 2016, at 7:35 PM, Darren Mo wrote: > > On Jun 21, 2016, at 5:28 PM, Matt Wright > wrote: >>> On Jun 20, 2016, at 5:50 PM,

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Xiaodi Wu via swift-evolution
On Tue, Jun 21, 2016 at 6:44 PM, Darren Mo wrote: > On Jun 20, 2016, at 10:12 PM, Xiaodi Wu wrote: > > On Mon, Jun 20, 2016 at 9:05 PM, Brent Royal-Gordon via swift-evolution < > swift-evolution@swift.org> wrote: > >> > DispatchQueue.async(execute:) and

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Darren Mo via swift-evolution
On Jun 21, 2016, at 5:24 PM, Matt Wright wrote: >> On Jun 20, 2016, at 7:12 PM, Xiaodi Wu via swift-evolution >> wrote: >> On Mon, Jun 20, 2016 at 9:05 PM, Brent Royal-Gordon via swift-evolution >> wrote: >>>

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Darren Mo via swift-evolution
On Jun 20, 2016, at 10:12 PM, Xiaodi Wu wrote: > On Mon, Jun 20, 2016 at 9:05 PM, Brent Royal-Gordon via swift-evolution > > wrote: > > DispatchQueue.async(execute:) and DispatchQueue.sync(execute:) > >

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Darren Mo via swift-evolution
On Jun 21, 2016, at 5:28 PM, Matt Wright wrote: >> On Jun 20, 2016, at 5:50 PM, Darren Mo via swift-evolution >> wrote: >> DispatchQueue.after(when:execute:) >> -- >> This one simply doesn’t read grammatically. For

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Matt Wright via swift-evolution
> On Jun 20, 2016, at 5:50 PM, Darren Mo via swift-evolution > wrote: > > SE-0088 was accepted with revisions a month ago. However, some of the APIs > just don’t feel right to me. I’ve only used DispatchQueue and DispatchSource > so far, so I will only comment on

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Matt Wright via swift-evolution
> On Jun 20, 2016, at 7:12 PM, Xiaodi Wu via swift-evolution > wrote: > > > > On Mon, Jun 20, 2016 at 9:05 PM, Brent Royal-Gordon via swift-evolution > wrote: > > DispatchQueue.async(execute:) and DispatchQueue.sync(execute:) > >

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Brandon Knope via swift-evolution
I'm not convinced that perform is clearer than async. performAndWait *is* clearer than sync but only in context: you wouldn't know perform was async until you read it or noticed the difference with performAndWait. Nothing about *perform* on its own conveys that it's asynchronous. Brandon

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Adrian Zubarev via swift-evolution
Just yesterday I filed a bug because Data and DispatchData overlap but the api is not consistent: https://bugs.swift.org/browse/SR–1843 I never used libdispatch in depth but wanted to learn how it works to evolve my TCP module. At first glance I spotted one wrong label name on DispatchIO:

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-21 Thread Brent Royal-Gordon via swift-evolution
> The guideline that methods should "read as imperative verb phrases" applies > to the full name, labels and arguments and all, and not just the base name. > You'll recall that the original proposal had .asynchronously(execute:), which > is very much an imperative phrase. `.async(execute:)` was

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-20 Thread Xiaodi Wu via swift-evolution
On Mon, Jun 20, 2016 at 9:05 PM, Brent Royal-Gordon via swift-evolution < swift-evolution@swift.org> wrote: > > DispatchQueue.async(execute:) and DispatchQueue.sync(execute:) > > -- > > The lack of verb in the base name bothers me. The

Re: [swift-evolution] [SE-0088] Dispatch API names

2016-06-20 Thread Brent Royal-Gordon via swift-evolution
> DispatchQueue.async(execute:) and DispatchQueue.sync(execute:) > -- > The lack of verb in the base name bothers me. The API Design Guidelines say > “methods with side-effects should read as imperative verb phrases”. You could > argue

[swift-evolution] [SE-0088] Dispatch API names

2016-06-20 Thread Darren Mo via swift-evolution
SE-0088 was accepted with revisions a month ago. However, some of the APIs just don’t feel right to me. I’ve only used DispatchQueue and DispatchSource so far, so I will only comment on those. DispatchQueue.async(execute:) and DispatchQueue.sync(execute:)