Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> On Dec 5, 2016, at 8:09 PM, Paul Cantrell wrote: > > >> On Dec 2, 2016, at 11:11 AM, Daniel Dunbar > > wrote: >> >> >>> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution >>>

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> On Dec 2, 2016, at 11:11 AM, Daniel Dunbar wrote: > > >> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution >> > wrote: >> >> This version of the proposal seems acceptable to me, though I have

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> On Nov 28, 2016, at 8:25 PM, Paul Cantrell via swift-evolution > wrote: > > Just a quick mini-review here; sorry, time pressure. > > This version of the proposal seems acceptable to me, though I have a nagging > feel that it’s more complex than it needs to be. I

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

Just a quick mini-review here; sorry, time pressure. This version of the proposal seems acceptable to me, though I have a nagging feel that it’s more complex than it needs to be. In particular, the two modes (autopin enabled / disabled) plus the --repin option seem to me to have a high

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> On Nov 23, 2016, at 3:03 PM, Martin Waitz via swift-evolution > wrote: > >> The review of "SE-0145: Package Manager Version Pinning" begins again after >> revisions, starting now and running through November 28th. The proposal is >> available here: >> >>

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> What is your evaluation of the proposal? +1. I think > Is the problem being addressed significant enough to warrant a change to > Swift? Yes, version pinning is a must-have feature for collaboration in larger scale. > Does this proposal fit well with the feel and direction of Swift? Yes,

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

Hello, Am 2016-11-24 13:54, schrieb Alex Blewitt via swift-evolution: At the moment, the proposal suggests having a secondary 'pins' file, which exists to allow explicit dependencies to be checked in to version control. This can be done at the moment, using a Version(1,2,3) or range

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> On 20 Nov 2016, at 05:48, Anders Bertelrud via swift-evolution > wrote: > > * What is your evaluation of the proposal? A way of building against a specific set of dependencies, rather than a variable set (or master), is needed in Swift. The current build

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

2016-11-20 14:48 GMT+09:00 Anders Bertelrud via swift-evolution < swift-evolution@swift.org>: > Hello Swift community, > > The review of "SE-0145: Package Manager Version Pinning" begins again > after revisions, starting now and running through November 28th. The > proposal is available here: >

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> The review of "SE-0145: Package Manager Version Pinning" begins again after > revisions, starting now and running through November 28th. The proposal is > available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md > >

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

On 2016-11-20 05:48:48 +, Anders Bertelrud via swift-build-dev said: * What is your evaluation of the proposal? Good. The revision is a good improvement over the original proposal. Build reproducability is great improvement to the ecosystem. * Is the problem being addressed

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

> What is your evaluation of the proposal? It seems like a sensible step on the way to more advanced workflow, stats, testing, checking upgrades, and reporting features - without closing any doors. > If you have used other languages or libraries with a similar feature, how do you feel that this

[swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

Hello Swift community, The review of "SE-0145: Package Manager Version Pinning" begins again after revisions, starting now and running through November 28th. The proposal is available here:

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

I have implemented the revisions to SE-0145 to support automatic pinning. The approach we took was to leave much of the existing behaviors, but to support an "automatic pinning" mode which is then on by default. If anyone wants to provide early feedback, my draft is here:

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Thanks for being open to feedback, Daniel, even when it’s difficult feedback. :) Pondering #2: is there a behavioral difference between 1. explicit “do not pin” option in SwiftPM and 2. Package.pins added to .gitignore? (In #2, individual ill-behaved packages would be version-pinned in

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Thank you, Daniel. I have marked the SE-0145 as such in the swift-evolution repository. Anders > On 2016-11-10, at 09.41, Daniel Dunbar wrote: > > Thanks to everyone who participated in this review! > > Based on the pretty universal negative feedback, we are going

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Thanks to everyone who participated in this review! Based on the pretty universal negative feedback, we are going to reject this proposal as is, and take it back for another round of revisions. Our revised plan is: 1. To introduce an "autopin" behavior to cover the problem Paul outlined where

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On Nov 4, 2016, at 5:28 AM, Max Desiatov via swift-evolution > wrote: > > Hi all, > >> On 31 Oct 2016, at 21:23, Anders Bertelrud via swift-evolution >> > wrote: >> >> * What is your evaluation of

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On Nov 4, 2016, at 9:06 AM, Paul Cantrell via swift-evolution > wrote: > > I’ve used bundler, Carthage, and CocoaPods extensively. All of them always > generate a lockfile (Gemfile.lock, Cartfile.resolved, and Podfile.lock). All > of them use these files as the

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

-1, though I do strongly think we should have version pinning. I agree with the others who believe that dependencies should be pinned by default. This doesn't mean that you have to check the pin/lock file into source control. I have a good amount of experience developing apps and libraries with

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On Nov 4, 2016, at 11:20 AM, Boris Buegling wrote: > >> On 4 Nov 2016, at 17:06, Paul Cantrell via swift-evolution >> wrote: >> >>> Overconstraint is much more of a risk in Swift than in other languages >>> using this style of package

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On 4 Nov 2016, at 17:06, Paul Cantrell via swift-evolution > wrote: > >> Overconstraint is much more of a risk in Swift than in other languages using >> this style of package management. > > …is incorrect. > > In particular, note that Ruby does not support using

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

What is your evaluation of the proposal? General +1, with reservations. Novel elements of the proposed behavior will need careful evaluation and refinement as we see how they plays out in practice, with open-mindedness from both users and the core team. Breaking it down: +1 on having this

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Hi all, > On 31 Oct 2016, at 21:23, Anders Bertelrud via swift-evolution > wrote: > > * What is your evaluation of the proposal? -1 > * Is the problem being addressed significant enough to warrant a change > to Swift? Yes, this is significant problem

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On 3 Nov 2016, at 17:36, Daniel Duan via swift-evolution > wrote: >> I am not sure why in some cases we need to be unique over state of the art >> like Cocoapods in some areas. What is the added value (not saying that there >> is none)? > > You can combine

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> On Nov 3, 2016, at 1:02 AM, Goffredo Marocchi wrote: > > Could you specify that in the tag of the dependency you need? >= 3.0.0 vs > = 2.0.0 etc… That’s missing the point of pinning though. You can already do this in Package.swift. Pinning is, in a way, guarding

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Could you specify that in the tag of the dependency you need? >= 3.0.0 vs = 2.0.0 etc... I am not sure why in some cases we need to be unique over state of the art like Cocoapods in some areas. What is the added value (not saying that there is none)? Sent from my iPhone > On 3 Nov 2016,

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> Am 03.11.2016 um 03:22 schrieb Daniel Duan : > > On Nov 2, 2016, at 3:46 PM, Martin Waitz via swift-evolution > wrote: > >>> What is your evaluation of the proposal? >> >> +1 for using reproducible versions of dependencies >> -1 for the actual

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Daniel Duan Sent from my iPhone On Nov 2, 2016, at 11:17 PM, Martin Waitz wrote: >> Am 03.11.2016 um 03:22 schrieb Daniel Duan : >> On Nov 2, 2016, at 3:46 PM, Martin Waitz via swift-evolution >> wrote: >> What is your

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> Am 03.11.2016 um 03:22 schrieb Daniel Duan : > On Nov 2, 2016, at 3:46 PM, Martin Waitz via swift-evolution > wrote: > >>> What is your evaluation of the proposal? >> >> +1 for using reproducible versions of dependencies >> -1 for the actual

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

On Nov 2, 2016, at 3:46 PM, Martin Waitz via swift-evolution wrote: >> What is your evaluation of the proposal? > > +1 for using reproducible versions of dependencies > -1 for the actual proposal > > My problem with this proposal is that it tries to please everybody

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> What is your evaluation of the proposal? +1 for using reproducible versions of dependencies -1 for the actual proposal My problem with this proposal is that it tries to please everybody by introducing options everywhere. I think we should try to build a system which is robust and works all of

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

> > * What is your evaluation of the proposal? +1 > * Is the problem being addressed significant enough to warrant a change > to Swift? Yes, version pinning is very important to dependency management in production environments. > * Does this proposal fit well with the

Re: [swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Hi Swift community > * What is your evaluation of the proposal? The proposal looks good and it solves the addressed problems. Resolving dependency graph is not a trivial problem and I like how this proposal tackles 1 problem at the time. > * Is the problem being addressed significant enough to

[swift-evolution] [Review] SE-0145: Package Manager Version Pinning

Hello Swift community, The review of SE-0145 "Package Manager Version Pinning" begins now and runs through November 4. The proposal is available here: https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md