Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Hi Alexandr, The descriptions of the new methods are too brief for the public API. For example: drawString() == Draws the given string at the specified location. Then what is difference with the Graphics#drawString()? It is absolutely unclear why the user should prefer the new API call to it?

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Hi Alexander, Since there is no change in char from this depending on status of the method, the check is not required. With Regards, Avik Niyogi > On 09-Dec-2015, at 11:29 pm, Alexander Scherbatiy > wrote: > > paramErr

Re: [9] Review Request for 8078514: Nightly: api/javax_swing/DefaultRowSorter/index_ModelStructChanged failure

On 12/8/2015 10:56 PM, Sergey Bylokhov wrote: On 02/11/15 16:51, Semyon Sadetsky wrote: On 5/26/2015 1:38 PM, Alexander Scherbatiy wrote: On 5/21/2015 5:34 PM, Semyon Sadetsky wrote: Hello, I have decided to remake the fix. The reason for that is sun.swing.FilePane class. One of its inner c

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

On 08/12/15 08:08, Avik Niyogi wrote: Hi All, Please find the updated web rev.02 with inputs provided below. Small minor change as suggested was inserted. Please commit the change if acceptable now. Thank you. http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Hi, Alexandr. I have two notes: - In the test the Swing is accessed on non EDT thread. - In some cases behavior in case of null is unclear(for example what happens if "g" is null). Also I suggest to clarify documentation of parameters(for example why the component should be passed etc.) On 2

Re: JDK9 Review Request for JDK-7104635 HTMLEditorKit fails to write down some html files

Hi, Rajeev. Did you check another place where it is decremented? Also it seems this change in some way contradicts the specification of getIndentLevel() method, because it is quite general: /** * Returns the current indentation level. That is, the number of times * incrIndent has b

Re: [9] Review Request for 8078514: Nightly: api/javax_swing/DefaultRowSorter/index_ModelStructChanged failure

On 02/11/15 16:51, Semyon Sadetsky wrote: On 5/26/2015 1:38 PM, Alexander Scherbatiy wrote: On 5/21/2015 5:34 PM, Semyon Sadetsky wrote: Hello, I have decided to remake the fix. The reason for that is sun.swing.FilePane class. One of its inner classes extends DefaultRowSorter and relays on laz

Re: Review Request for 8139169: Action registered for keyboard shortcut is called twice

Looks fine. On 08.12.15 7:08, Avik Niyogi wrote: Hi All, Please find the updated web rev.02 with inputs provided below. Small minor change as suggested was inserted. Please commit the change if acceptable now. Thank you. http://cr.openjdk.java.net/~aniyogi/8139169/webrev.02/ With Regards, Avik

Re: [9] Review Request for 8140527: JInternalFrame has incorrect title button width

On 12/7/2015 3:32 PM, Semyon Sadetsky wrote: On 11/6/2015 4:39 PM, Alexander Scherbatiy wrote: On 10/28/2015 12:54 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8140527 webrev: http://cr.openjdk.java.net/~ssadetsky/8140527/webrev