[9] Review Request: 8151857 [TEST_BUG] bug6544309.java fails intermittently

Hello, Please review the small fix for jdk9. The test javax/swing/JPopupMenu/6544309/bug6544309.java fails if executed in a batch via jtreg. The problem is that this test shows popup menu and expects that some specific menuitems will be selected after keyboard navigation. But some other test

[9] Review request for 8151015: JTextArea.insert() does not behave as expected with invalid position

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8151015 webrev: http://cr.openjdk.java.net/~ssadetsky/8151015/webrev.00/ It is regression of 4496801. The fix for 4496801 was wrong and the correct fix should be taking into account the implied character at the e

Re: [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

Thanks, Sergey. The webrev is corrected. On 3/14/2016 4:22 PM, Sergey Bylokhov wrote: Something strange occurs in the webrev for the testcase, there is no diff. On 14.03.16 14:29, Semyon Sadetsky wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8149631 webrev: http://cr.openjdk.java.net/

Re: [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

Something strange occurs in the webrev for the testcase, there is no diff. On 14.03.16 14:29, Semyon Sadetsky wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8149631 webrev: http://cr.openjdk.java.net/~ssadetsky/8149631/webrev.00/ The issue is a regression of 4419748 which added support f

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi, Avik. Can you please take a look to these two tests before fixing this bug: TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java -- TEST: javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java I remembe

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi All, Please review code changes made as per inputs provided. http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/ With Regards, Avik Niyogi > On 14-Mar-2016, at 10:53 am, Avik Niyogi wrote: > > Hi Sergey, > Seems like it is a delay i

Re: RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

The fix looks good to me. There is a small comment about code formatting. I believe that according to the new Java Style Guidelines where should not be a space between open brackets "( ()" http://cr.openjdk.java.net/~alundblad/styleguide/#toc-lambda-expressions Thanks, Alexandr. On 3/1

[9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8149631 webrev: http://cr.openjdk.java.net/~ssadetsky/8149631/webrev.00/ The issue is a regression of 4419748 which added support for border sides but it parse the rgb(...) color values wrong. Also before 4419748