Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 01.12.2016 02:52, Sergey Bylokhov wrote: On 30.11.16 21:12, Semyon Sadetsky wrote: On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

On 11/30/2016 2:53 PM, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review a fix for a continuation/regression of JDK-8081491

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

I wouldn't necessarily recommend Area as the replacement. It's designed for complicated path intersection, not as an optimal path storage mechanism. Also, since the constraint has to be installed on every repaint, re-rasterizing the shaped boundary on every repaint could potentially impact

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

On 30.11.16 2:11, Jim Graham wrote: - Region.getScaledRegion() - this method should be deleted. I think it is only used in SG2D.constrain() which needs to be rewritten as you cannot scale a region and expect any amount of accuracy, but we live with it for now until a better fix comes along. I

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

These results are good. I'm for simplifying as well... ...jim On 11/30/16 3:57 PM, Sergey Bylokhov wrote: On 29.11.16 20:46, Alexandr Scherbatiy wrote: The result of running SwingMark 2 with the following JDK is: 1. without the fix 1st test run [1]: 92373

Re: [9] Review request for 8162350 RepaintManager shifts repainted region when the floating point UI scale is used

On 29.11.16 20:46, Alexandr Scherbatiy wrote: The result of running SwingMark 2 with the following JDK is: 1. without the fix 1st test run [1]: 92373 2nd test run [2]: 92156 average: (92373 + 92156) / 2 = 92264.5 2. paintDoubleBufferedImp() method is always used 1st test

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 21:12, Semyon Sadetsky wrote: On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:51, Sergey Bylokhov wrote: On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about UIDefaults.removeResourceBundle()? This method removes the name of the

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 20:39, Semyon Sadetsky wrote: The user cannot remove internal bundle from the java.desktop, Why user cannot remove it? The method is exported. Do we talking about UIDefaults.removeResourceBundle()? This method removes the name of the bundle from the Vector in UIDefault, so when

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:33, Sergey Bylokhov wrote: On 30.11.16 19:55, Semyon Sadetsky wrote: The fix changes encapsulation of resources bundles inside java.desktop module. The UIDefaults::addResourceBundle() is a way to expose internal bundles(if the user requests the internal bundle he will be able

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.2016 20:25, Mandy Chung wrote: On Nov 30, 2016, at 8:55 AM, Semyon Sadetsky wrote: On 30.11.2016 19:34, Sergey Bylokhov wrote: On 30.11.16 9:52, Semyon Sadetsky wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 19:55, Semyon Sadetsky wrote: The fix changes encapsulation of resources bundles inside java.desktop module. The UIDefaults::addResourceBundle() is a way to expose internal bundles(if the user requests the internal bundle he will be able to read it). The fix does not change the state

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

> On Nov 30, 2016, at 8:55 AM, Semyon Sadetsky > wrote: > > > > On 30.11.2016 19:34, Sergey Bylokhov wrote: >> On 30.11.16 9:52, Semyon Sadetsky wrote: >>> On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: >>> Hello. Please review the fix for jdk9.

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 29.11.16 17:21, Alexandr Scherbatiy wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

On 30.11.16 9:52, Semyon Sadetsky wrote: On 11/28/2016 7:41 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This fix improve encapsulation of java.desktop module. After the fix the method "UIDefaults::addResourceBundle()" will not be able to register resource bundles which

Re: [9] Review Request: [JDK-8169879] [TEST_BUG] javax/swing/text/GlyphPainter2/6427244/bug6427244.java - compilation failed

ok .looks fine. Regards Prasanta On 11/30/2016 9:35 AM, Prahalad Kumar Narayanan wrote: Thank you for your time in review Prasanta. Please find my responses inline. I guess JComponent.isVisible() does not throw IllegalStateException so 141 } catch (IllegalStateException ex) { is

[9] RFR: JDK-8170349: The printed content is beyond the borders.

Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8170349 webrev: http://cr.openjdk.java.net/~psadhukhan/8170349/webrev.00/ Please review a fix for a continuation/regression of JDK-8081491 in which we made sure that we print only the