Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

2016-12-14 Thread Semyon Sadetsky
On 14.12.2016 20:11, Sergey Bylokhov wrote: Interesting. Does it mean that if I register some custom resource bundle it will not affect any UI values because all the values is already cached in some UIDefaults map, is that what you mean? The cache will be cleared when you register a new

Re: [9] Review Request: 8169900 The code which use Applets should be deprecated

2016-12-14 Thread Phil Race
Looks OK except for a couple of typo nits below. You can fix those without a new review However you will need a CCC for deprecating the public API AppletInitializer and the Beans.instantiate method which references it 159 * @deprecated It s recommended to use "It is" ? -- 160 * {@link

[9] Review request for 8133919 [macosx] JTable grid lines are incorrectly positioned on HiDPI display

2016-12-14 Thread Alexandr Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8133919 webrev: http://cr.openjdk.java.net/~alexsch/8133919/webrev.00 Draw lines calls are replaced by SwingUtilities2.drawHLine()/drawVLine in BasicTableUI. The added test is manual because the Robot takes

Re: [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

2016-12-14 Thread Sergey Bylokhov
Hi, Alexander. Should not the storage be based on soft references? In the current solution we will store the references to the checked classes forever in the static map. > 13 дек. 2016 г., в 18:41, Alexandr Scherbatiy > написал(а): > > > Hello, > > Could you

Re: [9] Review Request: 8149879 Examine UIDefaults::addResourceBundle(String bundleName) with resource encapsulation

2016-12-14 Thread Sergey Bylokhov
>> Interesting. Does it mean that if I register some custom resource bundle >>> it will not affect any UI values because all the values is already >>> cached in some UIDefaults map, is that what you mean? >> >> The cache will be cleared when you register a new bundle. > And if

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

2016-12-14 Thread Prasanta Sadhukhan
Gentle reminder... Regards Prasanta On 12/9/2016 8:27 PM, Prasanta Sadhukhan wrote: On 12/9/2016 8:18 PM, Alexandr Scherbatiy wrote: On 12/6/2016 5:52 PM, Prasanta Sadhukhan wrote: On 12/6/2016 8:17 PM, Alexandr Scherbatiy wrote: On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: On