Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi Sergey, I also was looking not to duplicate the code, but the inheritance hierarchy for AquaButtonRadioUI.java is different from MetalRadioButtonUI.java, although both ultimately derive from BasicButtonUI. As Phil pointed out, I wanted to keep the side effects to a minimum, so I copied the c

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

The bug says >This is not the native tabbed scrolling for Native buttons. The code review says > In OS X in default OS X apps, for radio button focus traversing to work, > custom actions must be set using System Preferences. I don't know what the first of these means and I don't know what the

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

If you mean, update the code so it is shared across L+Fs that can be a future project. No matter how "easy" that is, it will take extra time and add risk. Not for 11. -phil. On 8/11/18, 3:14 PM, Sergey Bylokhov wrote: Hi, Krishna. Is it possible to deduplicate this code, I guess it should. O

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

You may have fixed the "){" pattern but I still see "if(" in v.01. I have also tested out SS2 and the radio button demo now works for Aqua as it does for Metal. -phil. On 8/11/18, 11:53 AM, Krishna Addepalli wrote: Hi Phil, Thanks for quick review. I have copied the code from BasicRadioButt

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

BTW. Looks like this bu was reported before here: https://bugs.openjdk.java.net/browse/JDK-8167160 And the test was updated because our radio-buttons in the native L&F-Aqua behave in the same way as the native cocoa equivalents. Can you confirm that? On 11/08/2018 15:14, Sergey Bylokhov wrote

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi, Krishna. Is it possible to deduplicate this code, I guess it should. On 11/08/2018 08:21, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8208640: https://bugs.openjdk.java.net/browse/JDK-8208640 Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi Phil, Thanks for quick review. I have copied the code from BasicRadioButtonUI.java, so as you surmise, there are no code changes except for the references to Aqua in a couple places and the line "JComponnet compTransferFocusFrom = activeBtn" in jumpToNextComponent. This variable is no

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi, On 8/11/18, 8:21 AM, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8208640: https://bugs.openjdk.java.net/browse/JDK-8208640 Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/ The problem is th

[11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi All, Please review a fix for JDK-8208640: https://bugs.openjdk.java.net/browse/JDK-8208640 Webrev: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev00/ The problem is that the arrow key navigation for Aqua L&F was not implemented, which is why neither the tab keys nor the arrow ke