Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Thank you. I will correct the typo while checkin. Regards, Muneer -Original Message- From: Sergey Bylokhov Sent: Tuesday, August 14, 2018 7:57 AM To: Muneer Kolarkunnu ; [email protected] Cc: Aleksandre Iline Subject: Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/c

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

On 13/08/2018 19:32, Krishna Addepalli wrote: I understand that with the new jep, we no longer need to explicitly write the constructor to avoid the synthetic accessor methods generated by the compiler. AFAIK, each inner class declared results in a class file being generated rather than each

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

Hi Sergey, I understand that with the new jep, we no longer need to explicitly write the constructor to avoid the synthetic accessor methods generated by the compiler. AFAIK, each inner class declared results in a class file being generated rather than each default constructor. Could you clari

Re: [12] RFR JDK-8202702:Clearing selection on JTable causes disappearance of a row

Looks fine. On 08/08/2018 07:51, Prasanta Sadhukhan wrote: Hi All, Please review a fix for an issue where it is seen that when clearing a selected row by calling JTable.clearSelection() causes this selected row to be not painted. This is because, the present BasicTableUI paint() method paint

Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Looks fine. BTW: there is a small typo: test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java 1393 "Jemmy doesn't support getting or intializing title" On 13/08/2018 04:50, Muneer Kolarkunnu wrote: Hi, Please take a look on the set of changes brought in

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

On 08/13/2018 12:08 AM, Krishna Addepalli wrote: Hi Phil, I have run the JCK tests for JRadioButton and also focus traversal, and found no failures. Here is the new webrev with additional formatting issues fixed: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev02/

Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

I have reviewed all the changes - looks good. Shura > On Aug 13, 2018, at 4:50 AM, Muneer Kolarkunnu > wrote: > > Hi, > > Please take a look on the set of changes brought into JDK Jemmy copy from the > code-tools Jemmy repository. > Task id: https://bugs.openjdk.java.net/browse/JDK-8209418

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi Sergey, If we move the whole fix out, it will affect the behavior on Windows as well, which could be a problem. Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, August 13, 2018 11:35 PM To: Philip Race Cc: Krishna Addepalli ; [email protected] Subject: Re: [1

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

On 11/08/2018 15:46, Philip Race wrote: If you mean, update the code so it is shared across L+Fs that can be a future project. No matter how "easy" that is, it will take extra time and add risk. Not for 11. My point was to move the whole fix out from jdk11, since it is not a regression in 11,

[12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Hi, Please take a look on the set of changes brought into JDK Jemmy copy from the code-tools Jemmy repository. Task id: https://bugs.openjdk.java.net/browse/JDK-8209418 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8209418/webrev/ This includes following 5 tasks: https://bugs.openjdk.java.ne

Re: [11]RFR:JDK-8208640: [a11y][macosx] Unable to navigate between Radiobuttons in Radio group using keyboard

Hi Phil, I have run the JCK tests for JRadioButton and also focus traversal, and found no failures. Here is the new webrev with additional formatting issues fixed: http://cr.openjdk.java.net/~kaddepalli/8208640/webrev02/ Thanks, Krishna From: Prasanta Sadhukhan Sent: Monday, August