Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

ok. in that case, fix looks good. You will need a CSR. I guess the test will fail compilation without fix so no exception will be thrown but I guess we cannot escape that. Regards Prasanta On 8/29/2018 6:50 PM, Krishna Addepalli wrote: I presume you are hinting at binary compatibility. I thi

Re: [12] RFR [TEST][JDK-8209993] Create a test for SwingSet3 ToolTipDemo

Looks fine. On 27/08/2018 18:30, Muneer Kolarkunnu wrote: Hi All, Please review the following, a new client sanity test case: Task: https://bugs.openjdk.java.net/browse/JDK-8209993 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/8209993/webrev.00/

[12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

Hello. Please review the fix for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8133713 Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00 This fix provides the minimal support of accessibility(VoiceOver) for JTable. The table will be represented as a grid. The user will get aud

Re: RFR(M) : 8210039 : move OSInfo to top level testlibrary

Looks fine. On 28/08/2018 09:50, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8210039/webrev.00/index.html 698 lines changed: 114 ins; 240 del; 344 mod Hi all, could you please review this clean up of jdk testlibrary? the patch updates the tests to use jdk.test.lib.Platform in

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

I presume you are hinting at binary compatibility. I think, that should not be an issue, since we are not modifying any of the existing functions, but adding a new function. So, I don't think there would be any linking issues. Correct me if I'm wrong. Thanks, Krishna From: Krishna Addep

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

But we cannot have default methods in abstract classes. Only interfaces allow that. Thanks, Krishna From: Prasanta Sadhukhan Sent: Wednesday, August 29, 2018 3:21 PM To: Krishna Addepalli ; [email protected] Subject: Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

On 8/29/2018 2:23 PM, Krishna Addepalli wrote: Hi Prasanta, The new method “getChooserShortcutPanelFiles”, and the method “getChooserComboBoxFiles” are present in FileSystemView class itself, which makes it a default implementation already. I doubt that. If an application has extended jdk

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi Prasanta, The new method "getChooserShortcutPanelFiles", and the method "getChooserComboBoxFiles" are present in FileSystemView class itself, which makes it a default implementation already. As for the string "fileChooserShortcutPanelFolders", it goes to OS specific implementation and p

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi Krishna, One more thing...it is mentioned here 58 * Java Licensees may want to provide a different implementation of 59 * FileSystemView to better handle a given operating system If this class is ever extended by applications, then would it not be source incompatible change as there is