Hi All,
I found an issue with the test, and am working on it to make it pass reliably.
I was setting the size of the frame and then querying the preferred size, which
makes it a non-test.
I'm working to address it, meanwhile you could still review the fix itself.
Thanks,
Krishna
Fr
BTW I am not sure do we need this refinement, or maybe this text is
enough: "Returns an array of files representing the values which will be
shown in the file chooser shortcuts panel."
One more notes, if result of this method should be "shown in the file
chooser shortcuts panel", then this met
Daniel, Chris, Alan,
thank you for your review.
I've pushed it w/ Platfform::privilegedGetProperty method added to shorten
lines in Platform.java
Cheers,
-- Igor
> On Sep 4, 2018, at 6:08 AM, Daniel Fuchs wrote:
>
> Hi Igor,
>
> Nit: You could have introduced a
> private static String getP
Hi All,
Please review a fix for JDK-8208638:
https://bugs.openjdk.java.net/browse/JDK-8208638
Webrev: http://cr.openjdk.java.net/~kaddepalli/8208638/webrev00/
JEditorPane supports loading HTML content, including images, and this bug is
about image scaling when either of the width/height at
+1
-phil.
On 09/04/2018 12:52 AM, Prasanta Sadhukhan wrote:
Modified webrev caching the original antialias state and restoring it
at the end
http://cr.openjdk.java.net/~psadhukhan/8202013/webrev.1/
Regards
Prasanta
On 9/4/2018 4:58 AM, Philip Race wrote:
On 9/3/18, 12:24 AM, Prasanta Sadh
Hi Shura,
Yes, there were no changes needed to the Test Helpers class itself.
Sure, I will take care not to introduce unrelated formatting changes next time.
Best Regards,
Vikrant
-Original Message-
From: Alexandre (Shura) Iline
Sent: Tuesday, September 04, 2018 8:23 PM
To: Vikrant Agar
Vikrant,
There were no changes needed to the TestHelpers class itself, correct?
You should try to avoid formatting changes as it makes it harder to review.
Otherwise looks good.
Thank you.
Shura
> On Sep 4, 2018, at 2:03 AM, Vikrant Agarwal
> wrote:
>
> Hi All,
>
> Please review the fix
Igor,
> On 31 Aug 2018, at 19:42, Igor Ignatyev wrote:
>
> Alan, Chris,
>
> thanks for looking at it, I went w/ the alternative suggested by Chris. that
> required a sprinkle of doPrivileged in the testlibrary, but now
> Sockets/policy.* files grant the minimal required permissions to the tes
On 31/08/2018 19:42, Igor Ignatyev wrote:
Alan, Chris,
thanks for looking at it, I went w/ the alternative suggested by
Chris. that required a sprinkle of doPrivileged in the testlibrary,
but now Sockets/policy.* files grant the minimal required permissions
to the test code.
the incremental
Hi All, Please find the updated Webrev per the discussion:
http://cr.openjdk.java.net/~sveerabhadra/8182043/webrev.02/
Thanks and regards,
Shashi
From: Shashidhara Veerabhadraiah
Sent: Monday, July 30, 2018 1:32 PM
To: Prasanta Sadhukhan ;
[email protected]; awt-...@openjdk.
Hi All,
Please review the fix to add support for testing for all the available look and
feels for the following SwingSet3 Demo Tests:
ButtonDemoScreenshotTest.java
ButtonDemoTest.java
ComboBoxDemoTest.java
ListDemoTest.java
OptionPaneDemoTest.java
ProgressBarDemoTest.java
ScrollPaneDemo
Modified webrev caching the original antialias state and restoring it at
the end
http://cr.openjdk.java.net/~psadhukhan/8202013/webrev.1/
Regards
Prasanta
On 9/4/2018 4:58 AM, Philip Race wrote:
On 9/3/18, 12:24 AM, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where i
12 matches
Mail list logo
