Vikrant,

There were no changes needed to the TestHelpers class itself, correct?

You should try to avoid formatting changes as it makes it harder to review.

Otherwise looks good.

Thank you.

Shura

> On Sep 4, 2018, at 2:03 AM, Vikrant Agarwal <[email protected]> 
> wrote:
> 
> Hi All,
>  
> Please review the fix to add support for testing for all the available look 
> and feels for the following SwingSet3 Demo Tests:
> ButtonDemoScreenshotTest.java 
> ButtonDemoTest.java 
> ComboBoxDemoTest.java 
> ListDemoTest.java 
> OptionPaneDemoTest.java 
> ProgressBarDemoTest.java 
> ScrollPaneDemoTest.java 
> SpinnerDemoTest.java 
> TabbedPaneDemoTest.java 
> TableDemoTest.java 
> ToggleButtonDemoTest.java 
> TreeDemoTest.java
>  
> Task: https://bugs.openjdk.java.net/browse/JDK-8210052
> Webrev Link: http://cr.openjdk.java.net/~vagarwal/8210052/webrev.1/
> Summary: We use “availableLookAndFeels” dataProvider from TestHelpers class  
> to run the test iteratively using all the available look and feels.
>  
> Best Regards,
> Vikrant

Reply via email to