Re: [12] Review Request: 8133713 [macosx] Accessible JTables always reported as empty

On 06/09/2018 04:23, Krishna Addepalli wrote: Hi Sergey, I imported the patch and tested it locally. It does report the number of rows/columns, table description. However, it reads out the text in the current cell the first time it is focused, but not after that > Looking at the code changes, I

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

Hi Phil/Sergey, As per our conversation I have modified the fix to include following: 1. Adding final modifier to the new API. 2. Finding the usages of “fileChooserShortcutPanelFiles”, and replacing it with the new API - Fortunately, there is only one place in WindowsPlacesBar.java, and I have c

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Looks fine to me. > On 10-Sep-2018, at 5:06 PM, Prasanta Sadhukhan > wrote: > > Hi Krishna, > > updateStyle creates a new context whereas SynthLookAndFeel.updateStyle > updates the style for present context > > Regards > Prasanta > On 9/10/2018 4:57 PM, Krishna Addepalli wrote: >> Hi Prasant

Re: RFR: [12] JDK-8208638: Instead of circle rendered in appl window, but ellipse is produced JEditor Pane

+1 Regards Prasanta On 9/10/2018 5:56 PM, Krishna Addepalli wrote: Thanks for the comments Prasanta, here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8208638/webrev02/ Krishna On 10-Sep-2018, at 5:20 PM, Prasanta

Re: RFR: [12] JDK-8208638: Instead of circle rendered in appl window, but ellipse is produced JEditor Pane

Thanks for the comments Prasanta, here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8208638/webrev02/ Krishna > On 10-Sep-2018, at 5:20 PM, Prasanta Sadhukhan > wrote: > > yes, right. fix looks ok to me. Please chang

Re: RFR: [12] JDK-8208638: Instead of circle rendered in appl window, but ellipse is produced JEditor Pane

yes, right. fix looks ok to me. Please change comment style in l946 and make it similar to l956. Also, l960 change "ration" to "ratio" Regards Prasanta On 9/7/2018 9:00 PM, Krishna Addepalli wrote: Hi Prasanta, I think you are confused by the same name of the variables. newHeight/newWidth ar

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi Krishna, updateStyle creates a new context whereas SynthLookAndFeel.updateStyle updates the style for present context Regards Prasanta On 9/10/2018 4:57 PM, Krishna Addepalli wrote: Hi Prasanta, Is there any reason why you are explicitly calling SynthLookAndFeel.updateStyle compared to

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

Hi Prasanta,   Is there any reason why you are explicitly calling SynthLookAndFeel.updateStyle compared to the updateStyle function present in the same class?   Thanks, Krishna   From: Prasanta Sadhukhan Sent: Friday, September 7, 2018 4:28 PM To: [email protected] Subject: [12]