On 06/09/2018 04:23, Krishna Addepalli wrote:
Hi Sergey,

I imported the patch and tested it locally. It does report the number of 
rows/columns, table description.
However, it reads out the text in the current cell the first time it is focused, but not after that > Looking at the code changes, I could follow that you have implemented
functions to get the row and column information, but couldn’t see any function related to getting the text out of the selected cell. Could you explain that?

It is implemented via an existed code(used by JList):
JavaComponentAccessibility.m:
498         if ([javaRole isEqualToString:@"list"]
499                 || [javaRole isEqualToString:@"table"]) {
....
668             if ([parentRole isEqualToString:@"list"]
669                     || [parentRole isEqualToString:@"table"]) {


Also, do you plan to include the example in the JBS as a test case?

It is already there:
https://bugs.openjdk.java.net/browse/JDK-8133713?focusedCommentId=14207364&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14207364

Note that it has a description of shortcuts which should be used for interactions with the table.


Thanks,
Krishna

On 30-Aug-2018, at 3:33 AM, Sergey Bylokhov <[email protected]> wrote:

Hello.
Please review the fix for jdk12.

Bug: https://bugs.openjdk.java.net/browse/JDK-8133713
Webrev: http://cr.openjdk.java.net/~serb/8133713/webrev.00

This fix provides the minimal support of accessibility(VoiceOver) for JTable.

The table will be represented as a grid. The user will get audio information 
about:
- number of columns
- number of rows
- the selected cells
- the description of the whole table
- the text in the current cell

The user will be able to interact with the table(select/deselect cells.)

Example and fix limitations are provided in the bug:
https://bugs.openjdk.java.net/browse/JDK-8133713?focusedCommentId=14207364&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14207364


--
Best regards, Sergey.



--
Best regards, Sergey.

Reply via email to