Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-09-11 Thread Prasanta Sadhukhan
Ok. Modified test http://cr.openjdk.java.net/~psadhukhan/8192888/webrev.1/ Regards Prasanta On 12-Sep-18 2:41 AM, Sergey Bylokhov wrote: Hi, Prasanta. One small comment about the test, it will be good to check all supported LaF. On 11/09/2018 14:09, Sergey Bylokhov wrote: Hi, Prasanta. On 0

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-09-11 Thread Prasanta Sadhukhan
Hi Sergey, On 12-Sep-18 2:39 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L&F results in NPE. Reason for it is when SynthPanelUI#installDefaults is called during frame

Re: [12] RFR [TEST][JDK-8210056] Enable different look and feel tests in SwingSet3 demo test TextFieldDemoTest

2018-09-11 Thread Sergey Bylokhov
Looks fine. On 07/09/2018 00:13, Muneer Kolarkunnu wrote: Hi All, Please review the fix to add support for testing for all the available look and feels for the TextFieldDemoTest. Task: https://bugs.openjdk.java.net/browse/JDK-8210056 Webrev Link:http://cr.openjdk.java.net/~akolarkunnu/82100

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-09-11 Thread Sergey Bylokhov
Hi, Prasanta. One small comment about the test, it will be good to check all supported LaF. On 11/09/2018 14:09, Sergey Bylokhov wrote: Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L&F results in

Re: [12] RFR JDK-8192888: AllSwingComponentsBaselineTest fails with NullPointerException for NimbusLookAndFeel

2018-09-11 Thread Sergey Bylokhov
Hi, Prasanta. On 07/09/2018 03:57, Prasanta Sadhukhan wrote: Please review a fix for an issue where obtaining baseline for Button UI in Nimbus L&F results in NPE. Reason for it is when SynthPanelUI#installDefaults is called during frame instantiation, it calls SynthPanelUI#updateStyle which sets

Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests

2018-09-11 Thread Sergey Bylokhov
Looks fine. On 11/09/2018 01:18, Vikrant Agarwal wrote: Gentle Reminder -Original Message- From: Vikrant Agarwal Sent: Tuesday, September 04, 2018 8:57 PM To: Aleksandre Iline Cc: [email protected] Subject: Re: [12] RFR JDK-8210052:Enable testing for all the available look a

Re: [12]RFR:JDK-8182041- FIle Chooser Shortcut Panel folders under on JDK9

2018-09-11 Thread Sergey Bylokhov
Hi, Krishna. Please recheck the new "ShellFolderQueriesSecurityManagerTest", it does not work when I run it on macOS. On 10/09/2018 06:08, Krishna Addepalli wrote: Hi Phil/Sergey, As per our conversation I have modified the fix to include following: 1. Adding final modifier to the new API. 2.

Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests

2018-09-11 Thread Vikrant Agarwal
Gentle Reminder -Original Message- From: Vikrant Agarwal Sent: Tuesday, September 04, 2018 8:57 PM To: Aleksandre Iline Cc: [email protected] Subject: Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests Hi Shura, Yes, there we