Looks fine.
On 11/09/2018 01:18, Vikrant Agarwal wrote:
Gentle Reminder
-----Original Message-----
From: Vikrant Agarwal
Sent: Tuesday, September 04, 2018 8:57 PM
To: Aleksandre Iline <[email protected]>
Cc: [email protected]
Subject: Re: <Swing Dev> [12] RFR JDK-8210052:Enable testing for all the
available look and feels in SwingSet3 demo tests
Hi Shura,
Yes, there were no changes needed to the Test Helpers class itself.
Sure, I will take care not to introduce unrelated formatting changes next time.
Best Regards,
Vikrant
-----Original Message-----
From: Alexandre (Shura) Iline
Sent: Tuesday, September 04, 2018 8:23 PM
To: Vikrant Agarwal <[email protected]>
Cc: [email protected]; Muneer Kolarkunnu <[email protected]>;
Srinivas Mandalika <[email protected]>
Subject: Re: <Swing Dev> [12] RFR JDK-8210052:Enable testing for all the
available look and feels in SwingSet3 demo tests
Vikrant,
There were no changes needed to the TestHelpers class itself, correct?
You should try to avoid formatting changes as it makes it harder to review.
Otherwise looks good.
Thank you.
Shura
On Sep 4, 2018, at 2:03 AM, Vikrant Agarwal <[email protected]>
wrote:
Hi All,
Please review the fix to add support for testing for all the available look and feels for the following SwingSet3 Demo Tests:
ButtonDemoScreenshotTest.java
ButtonDemoTest.java
ComboBoxDemoTest.java
ListDemoTest.java
OptionPaneDemoTest.java
ProgressBarDemoTest.java
ScrollPaneDemoTest.java
SpinnerDemoTest.java
TabbedPaneDemoTest.java
TableDemoTest.java
ToggleButtonDemoTest.java
TreeDemoTest.java
Task: https://bugs.openjdk.java.net/browse/JDK-8210052
Webrev Link: http://cr.openjdk.java.net/~vagarwal/8210052/webrev.1/
Summary: We use “availableLookAndFeels” dataProvider from TestHelpers class to
run the test iteratively using all the available look and feels.
Best Regards,
Vikrant
--
Best regards, Sergey.
