Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Hi Sergey, > On 06-Dec-2019, at 4:43 AM, Sergey Bylokhov > wrote: > > Hi, Tejpal. > > Are you sure that it will be possible to change the value of the > JSpinner and It is possible to change the value of JSpinner after the fix. The Values can be changed by clicking on the JSpinner editor and

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

Gentle reminder On 28-Nov-19 3:52 PM, Prasanta Sadhukhan wrote: Hi Sergey, Hi Sergey, On 27-Jul-19 2:56 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 01.07.2019 03:25, Prasanta Sadhukhan wrote: Currently this rectangle is created based on the size of the component, so this rectangle is

Re: [14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

Hi, Tejpal. The test should dispose the frame on all code paths. On 12/5/19 4:06 am, Tejpal Rebari wrote: Hi All, Please review a test fix for jdk-14. Bug     : https://bugs.openjdk.java.net/browse/JDK-8234802 Webrev : http://cr.openjdk.java.net/~trebari/swing/8234802/webrev0/ This is a new

Re: [14] RFR JDK-8227607: Broken external links in java.desktop

Hi, Prasanta. Can you please share the final generated JavaDoc, it is hard to read the diff below. On 12/4/19 10:09 am, Prasanta Sadhukhan wrote: Inlined information from element_interface page into Document class

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Hi, Tejpal. Are you sure that it will be possible to change the value of the JSpinner and navigate over JSpinner and its buttons by the keyboard after this fix? On 12/4/19 10:25 pm, Tejpal Rebari wrote: There is no such issue with other LookAndFeels. Fix : The focusable property is set to

Re: [14] RFR : JDK-4949105 : Access Bridge lacks html tags parsing

Looks fine. On 12/5/19 4:41 am, Ambarish Rapte wrote: Hi Sergey, I suggest to use String.strip() instead of trim(). Updated the same: http://cr.openjdk.java.net/~arapte/a11y/4949105/webrev.03/ Please take a look. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent:

Re: [14] RFR : JDK-4949105 : Access Bridge lacks html tags parsing

Hi Sergey, >> I suggest to use String.strip() instead of trim(). Updated the same: http://cr.openjdk.java.net/~arapte/a11y/4949105/webrev.03/ Please take a look. Regards, Ambarish -Original Message- From: Sergey Bylokhov Sent: Thursday, December 5, 2019 4:23 AM To: Ambarish Rapte ;

[14] RFR JDK-8234802 - [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms

Hi All, Please review a test fix for jdk-14. Bug : https://bugs.openjdk.java.net/browse/JDK-8234802 Webrev : http://cr.openjdk.java.net/~trebari/swing/8234802/webrev0/ This

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

Looks good to me Regards, Pankaj From: Prasanta Sadhukhan Sent: Thursday, December 5, 2019 3:38 PM To: Tejpal Rebari; swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key +1 but you need to

Re: [14] RFR JDK-8223788 - [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key

+1 but you need to put noreg-demo label in JBS. Regards Prasanta On 05-Dec-19 11:55 AM, wrote: Hi All, Please review the following fix for jdk14. Bug: https://bugs.openjdk.java.net/browse/JDK-8223788 Webrev: http://cr.openjdk.java.net/~trebari/swing/8223788/webrev0/ Issue  : In

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

looks good to me. Regards Prasanta On 05-Dec-19 3:23 PM, Pankaj Bansal wrote: Hello Prasanta, I have made the changes suggested by you. webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev02/ Regards, Pankaj Bansal *From:*Prasanta Sadhukhan *Sent:* Wednesday, December 4, 2019

Re: [13] RFR JDK-8234733: We can't distinguish if the spinner button is pressed or unpressed

Hello Prasanta, I have made the changes suggested by you. webrev: http://cr.openjdk.java.net/~pbansal/8234733/webrev02/ Regards, Pankaj Bansal From: Prasanta Sadhukhan Sent: Wednesday, December 4, 2019 12:58 PM To: Pankaj Bansal; Philip Race Cc: swing-dev@openjdk.java.net Subject: