Looks good to me

 

Regards,

Pankaj

 

From: Prasanta Sadhukhan 
Sent: Thursday, December 5, 2019 3:38 PM
To: Tejpal Rebari; swing-dev@openjdk.java.net
Subject: Re: <Swing Dev> [14] RFR JDK-8223788 - [macos] JSpinner buttons in 
JColorChooser dialog may capture focus using TAB Key

 

+1 but you need to put noreg-demo label in JBS.

Regards

Prasanta

On 05-Dec-19 11:55 AM, wrote:

Hi All, 

Please review the following fix for jdk14.

 

Bug                  :  https://bugs.openjdk.java.net/browse/JDK-8223788

Webrev :  http://cr.openjdk.java.net/~trebari/swing/8223788/webrev0/

 

Issue  : In AquaLookAndFeel  JSpinner buttons inside JColorChooser dialog 
captures focus.

If we click on the editor inside the JSpinner to make it gain focus and then 
press TAB key, the focus should go to next component but it disappears and it 
is captured by the JSpinner button.By again pressing TAB the focus goes to next 
component.

 

There is no such issue with other LookAndFeels.

 

Fix : The focusable property is set to true by default, Fix is to set the 
JSpinner button focusable property false in AquaLookAndFeel.

 

Testing : Tested In Mac.

 

Regards

Tejpal

Reply via email to