> Hi All, Could you please review this fix for JDK16?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>
> Fix: Rewritten the above applet based test to a regular java test.
>
> Best Regards,
> K Suman Rajkumaar
K Suman Rajkumaar
On Wed, 6 Jan 2021 07:18:46 GMT, Prasanta Sadhukhan
wrote:
> These radiobutton tests were failing on macos in nightly testing. However
> recent run of these test are working fine on local mac10.14.6, 10.15.7
> systems as well as mach5 macos systems, so we can deproblemlist these tests.
>
On Wed, 6 Jan 2021 07:18:46 GMT, Prasanta Sadhukhan
wrote:
> These radiobutton tests were failing on macos in nightly testing. However
> recent run of these test are working fine on local mac10.14.6, 10.15.7
> systems as well as mach5 macos systems, so we can deproblemlist these tests.
>
On Wed, 6 Jan 2021 09:20:38 GMT, Pankaj Bansal wrote:
> The JDK-8249548 may be backed out soon as it has caused some other issue
> JDK-8259237. I am working on it.
So please take care of these tests, so we do not break them again.
-
PR: https://git.openjdk.java.net/jdk/pull/1957
On Wed, 6 Jan 2021 16:25:16 GMT, K Suman Rajkumaar
wrote:
>> Hi All, Could you please review this fix for JDK16?
>>
>> Problem Description: The test
>> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>>
>> Fix: Rewritten the above applet based test to a regular
On Wed, 6 Jan 2021 19:52:35 GMT, Alexey Ivanov wrote:
>> K Suman Rajkumaar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed the setSize()
>
> Marked as reviewed by aivanov (Reviewer).
"Hi All, Could you please review this fix
> Hi All, Could you please review this fix for JDK16?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>
> Fix: Rewritten the above applet based test to a regular java test.
>
> Best Regards,
> K Suman Rajkumaar
K Suman Rajkumaar
On Wed, 6 Jan 2021 14:28:29 GMT, K Suman Rajkumaar
wrote:
>> Hi All, Could you please review this fix for JDK16?
>>
>> Problem Description: The test
>> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>>
>> Fix: Rewritten the above applet based test to a regular
> Hi All, Could you please review this fix for JDK16?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>
> Fix: Rewritten the above applet based test to a regular java test.
>
> Best Regards,
> K Suman Rajkumaar
K Suman Rajkumaar
On Wed, 6 Jan 2021 08:24:04 GMT, K Suman Rajkumaar
wrote:
>> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 68:
>>
>>> 66:
>>> 67: if (!latch.await(5, TimeUnit.MINUTES)) {
>>> 68: frame.dispose();
>>
>> The `dispose()` method should be called on EDT.
>
> If I
On Wed, 6 Jan 2021 09:46:10 GMT, K Suman Rajkumaar
wrote:
>> Hi All, Could you please review this fix for JDK16?
>>
>> Problem Description: The test
>> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>>
>> Fix: Rewritten the above applet based test to a regular
Please review the following fix for jdk17.
In this fix i have deprecated and marked for removal following classes and
methods
public void intervalAdded(ListDataEvent e)
public void intervalRemoved(ListDataEvent e)
protected boolean lt(File a, File b) in BasicDirectoryModel.java
> Hi All, Could you please review this fix for JDK16?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>
> Fix: Rewritten the above applet based test to a regular java test.
>
> Best Regards,
> K Suman Rajkumaar
K Suman Rajkumaar
On Wed, 6 Jan 2021 08:57:42 GMT, Sergey Bylokhov wrote:
>> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we
>> dont see the issue now as can be seen by mach5 run.
>
>> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we
>> dont see the issue
On Wed, 6 Jan 2021 09:17:50 GMT, Prasanta Sadhukhan
wrote:
>>> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and
>>> we dont see the issue now as can be seen by mach5 run.
>>
>> So the tests will fail on the builds before jdk16 b14?
>
> Yes, maybe not all but
On Wed, 6 Jan 2021 08:51:44 GMT, Prasanta Sadhukhan
wrote:
> Not sure but the code added by JDK-8226892 is reworked by JDK-8249548 and we
> dont see the issue now as can be seen by mach5 run.
So the tests will fail on the builds before jdk16 b14?
-
PR:
On Wed, 6 Jan 2021 08:45:19 GMT, Sergey Bylokhov wrote:
>> These radiobutton tests were failing on macos in nightly testing. However
>> recent run of these test are working fine on local mac10.14.6, 10.15.7
>> systems as well as mach5 macos systems, so we can deproblemlist these tests.
>>
On Wed, 6 Jan 2021 07:18:46 GMT, Prasanta Sadhukhan
wrote:
> These radiobutton tests were failing on macos in nightly testing. However
> recent run of these test are working fine on local mac10.14.6, 10.15.7
> systems as well as mach5 macos systems, so we can deproblemlist these tests.
>
On Tue, 5 Jan 2021 08:25:00 GMT, Alexey Ivanov wrote:
>> K Suman Rajkumaar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update bug8031573.java
>>
>> Corrected the jtreg tag from @run main bug8031573 to @run main/manual
>>
> Hi All, Could you please review this fix for JDK16?
>
> Problem Description: The test
> open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based.
>
> Fix: Rewritten the above applet based test to a regular java test.
>
> Best Regards,
> K Suman Rajkumaar
K Suman Rajkumaar
20 matches
Mail list logo
