Integrated: 8058704: Nimbus does not honor JTextPane background color

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 29 Jul 2021 11:44:31 GMT, Prasanta Sadhukhan wrote: > The Nimbus look and feel ignores the configured background color of a > JTextPane and always uses white. > Every other look and feel tested (Metal, Motif, and Windows) correctly honors > the configured background color of a

Re: RFR: 5015261: JInternalFrame causes NPE [v2]

2021-08-12 Thread Prasanta Sadhukhan
On Thu, 12 Aug 2021 22:31:08 GMT, Sergey Bylokhov wrote: >> I guess that is why we are putting up this statement, no so that user thinks >> twice before making it null? Should we make the field private? > > We cannot make it private, we can only update the spec there as well. done

Re: RFR: 5015261: JInternalFrame causes NPE [v3]

2021-08-12 Thread Prasanta Sadhukhan
> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be called > with null value. There are many places in JInternalFrame where > getDesktopIcon() is accessed without null check which might cause NPE. > Added null check for those cases. Prasanta Sadhukhan has updated the pull

Re: RFR: 5015261: JInternalFrame causes NPE [v2]

2021-08-12 Thread Sergey Bylokhov
On Thu, 12 Aug 2021 04:09:18 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/JInternalFrame.java line 1308: >> >>> 1306: * Sets the JDesktopIcon associated with this >>> 1307: * JInternalFrame. >>> 1308: * Setting null icon is unsupported and may

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan wrote: > The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Sergey Bylokhov
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote: > Initial implementation and a test case. > > The problem is that Aqua LaF shows the focused component with the glow on the > border, hence when the border is not painted the foxus is not displayed. The > idea is to paint the glowing

Re: RFR: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked

2021-08-12 Thread Alexander Zuev
On Thu, 12 Aug 2021 02:15:06 GMT, Sergey Bylokhov wrote: > Painting the border while the user tries to disable the border via > setBorderPainted(false) does not look like a correct solution. The user might > be drawn something there already. I remember we discussed a similar a11y bug >