Re: RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]

2021-09-04 Thread Pankaj Bansal
On Wed, 25 Aug 2021 10:39:42 GMT, Pankaj Bansal wrote: >> A container may include few default components as children, which are added >> to it during creation. Due to this, calling function getChildrenCount on a >> new created instance may return non zero value. This behaviour may vary >>

Re: RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]

2021-09-04 Thread Phil Race
On Wed, 25 Aug 2021 10:39:42 GMT, Pankaj Bansal wrote: >> A container may include few default components as children, which are added >> to it during creation. Due to this, calling function getChildrenCount on a >> new created instance may return non zero value. This behaviour may vary >>

Re: RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]

2021-09-04 Thread Pankaj Bansal
On Mon, 23 Aug 2021 17:05:25 GMT, Phil Race wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review Comments > >> > I wonder how the other components handle that. For example, the JComboBox >> > in Aqua L is a

Integrated: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-09-04 Thread Prasanta Sadhukhan
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan wrote: > The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v2]

2021-09-04 Thread Prasanta Sadhukhan
On Fri, 3 Sep 2021 05:54:45 GMT, Sergey Bylokhov wrote: >> I will like to know how because as it is pointed out, paintArrow delegates >> drawing to ImageIcon#paintIcon which is in shared code and this is mac >> specific issue so it needs to be handled before we call ImageIcon#paintIcon > > You

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v5]

2021-09-04 Thread Prasanta Sadhukhan
> It is seen in macos disabled JMenuItem arrow is not disabled even though > JMenuItem itself is disabled. > In native app, same menuitem arrow is disabled for disabled menuitem. > > Issue is when AquaMenuPainter#paintMenuItem() is called, it tries to draw a > ImageIcon image of the arrow via