Re: RFR: 8268087: Update documentation of the JPasswordField

LGTM > On Jun 3, 2021, at 7:41 AM, Phil Race wrote: > > On Wed, 2 Jun 2021 13:08:08 GMT, Alexander Zvegintsev > wrote: > >>> Some useful documentation was added to the JPasswordField. >> >> src/java.desktop/share/classes/javax/swing/JPasswordField.java line 68: >> >>> 66: * handling

Re: RFR: 8268087: Update documentation of the JPasswordField

> On Jun 3, 2021, at 1:13 AM, Sergey Bylokhov wrote: > > This is the reason why the initial text in this fix contained "The text > entered in {@code JPasswordField} displays something that was typed". So yes > it really may contain something that was typed, in opposite to "displays that >

Re: RFR: 8268087: Update documentation of the JPasswordField

> On Jun 2, 2021, at 11:00 PM, Phil Race wrote: > > It is a text field. It displays unicode text. Nothing else. It can't display > a graphic such as a dot unless it is a unicode > assigned code point. So if we want to re-define text across the platform to > exclude some subset of unicode it

Re: RFR: 8268087: Update documentation of the JPasswordField

I think this statement is over-constraining the UI behavior. What the password field displays does not have to be text in the ordinary sense of the word. It could be a series of large dots. It is really up to the UI. Also, the sentence is turned around. It should not start with the “text

synchronization of invalidateLayout

It is mentioned in the documentation of BoxLayout.invalidateLayout() that this method may be called on a thread other than the UI thread. Is this still the case? If it is, shouldn’t this fact be documented more prominently? I notice that OverlayLayout does not synchronize. I also notice that

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

What alternative are you proposing? I don’t believe there is any option that is guaranteed not to require changing for some future release of macOS without some new API from Apple, e.g. “selectedTabTextColor”. > On Dec 24, 2020, at 9:39 AM, Phil Race wrote: > > On Wed, 23 Dec 2020 10:41:04

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

Just to be clear, there is no Apple API whose purpose is to reveal the color that AppKit uses to paint the text in a tab. Any color choice you make, literal or symbolic, will either be wrong now or sometime in the future, or both. Trying to deduce the color by analyzing an actual native view

Re: EA8 build of Project Lanai (Java 2D Metal rendering pipeline for macOS) is now posted

> On Dec 16, 2020, at 11:57 PM, Philip Race wrote: > > To anyone who has a mac still running 10.12 - we don't expect Metal to run > (it requires at least 10.13 > and maybe even later by the time it is final) but we would like confirmation > that nothing in Metal > prevents OpenGL running on

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

Isn’t that what -Dapple.awt.application.appearance=system does? > On Nov 30, 2020, at 12:56 AM, Prasanta Sadhukhan > wrote: > > On Mon, 30 Nov 2020 04:49:25 GMT, Prasanta Sadhukhan > wrote: > >>> Since color of tabpane is controlled by Apple, Can you point me to the code >>> where we call

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

> On Nov 24, 2020, at 1:26 PM, Sergey Bylokhov wrote: > > The problem here is that we do not control the color of the tab pane, it is > controlled by Apple, and if we hardcore some color on our side we will get > the same bugs again and again. I am sure that a similar bug will come in the >

Re: taskbar icon badge issue

> On Nov 24, 2020, at 1:32 PM, Sergey Bylokhov > wrote: > > It was there, and it was reported to Apple ID-7261735. Looks like this bug > has a few > fixes and the last update was that it could work in 10.15.5 beta 3. > I'll take a look. Thanks. By the way, it is not clear to me why it is a

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Nov 24, 2020, at 7:21 PM, Prasanta Sadhukhan wrote: > > On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov > wrote: > >>> Tried to find and change tabpane background color for "selected" tab but >>> unable to do so. >>> Tried changing

Re: taskbar icon badge issue

image [1]. I hope the “fix” can be reverted in JDK 16. Alan [1] https://cr.openjdk.java.net/~alans/8230869/Notifications.png > On Oct 26, 2020, at 2:29 PM, Sergey Bylokhov > wrote: > > On 26.10.2020 14:16, Alan Snyder wrote: >>> I have tested the "DockBadge

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

When inactive, I use 0 0 0 192. As far as I can tell, this does not correspond to a named color. It would be wrong to assume that Apple only uses named colors in their UIs. The named colors are for application developers, not for Apple itself. Alan > On Nov 19, 2020, at 4:05 PM, Alan Sny

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

VAqua uses controlTextColor which has the value 255 255 255 217. If you are seeing opaque white, then the alpha channel is getting lost somewhere. Alan > On Nov 19, 2020, at 10:59 AM, Sergey Bylokhov wrote: > > On Thu, 19 Nov 2020 10:51:55 GMT, Prasanta Sadhukhan

Re: taskbar icon badge issue

> I have tested the "DockBadge.java" from the > https://bugs.openjdk.java.net/browse/JDK-8230869 on macOS 10.15.7 + JDK12 and > it does not work =( That seems odd. Are you saying that no dock icons ever show a badge on 10.15.7? On my 10.15.6, I see dock badges on System Preferences, App Store,

taskbar icon badge issue

I’m confused by this code in Taskbar: public void setIconBadge(final String badge) { checkEventsProcessingPermission(); checkFeatureSupport(Feature.ICON_BADGE_NUMBER); peer.setIconBadge(badge); } which requires ICON_BADGE_NUMBER even though ICON_BADGE_TEXT is specified as acceptable

adding a component to a container that it is already a member of (specifically a JLayeredPane container)

The Container.addImpl method, although protected, defines the behavior of adding a component to a container. The documentation for this method says: If the component is not an ancestor of this container and has a non-null parent, it is removed from its current parent before it is added to this

Re: Box.Filler focusability

cusable by default, but not sure we > can change it. > It will be necessary to check the history of the related code. I suggest to > create a new bug to track it. > > On 8/13/19 7:12 am, Alan Snyder wrote: >> I ask only because I don’t want to file a bug report that will be r

Re: Box.Filler focusability

I ask only because I don’t want to file a bug report that will be rejected immediately... > On Aug 9, 2019, at 11:01 AM, Alan Snyder wrote: > > I find that Box.Filler instances are focusable by default. That seems wrong. > Am I missing something? >

Box.Filler focusability

I find that Box.Filler instances are focusable by default. That seems wrong. Am I missing something?

JDesktopPane and menu bars

I gather from recent bug fixes that JDesktopPane is being used, but I don’t have a feel for how it is being used. Can someone explain? My specific question: if a JInternalFrame is used on macOS and the screen menu bar is enabled for Java, should the frame menu bar be displayed in the frame or

[11] Review Request: 8196322: [macosx] When the screen menu bar is used, clearing the default menu bar should permit AWT shutdown

Hello, Please review the following bug fix. Thank you. Alan Bug: https://bugs.openjdk.java.net/browse/JDK-8196322 webrev: http://cr.openjdk.java.net/~serb/alans/8196322/webrev.00/

RFR: 8196322: [macosx] When the screen menu bar is used, clearing the default menu bar should permit AWT shutdown

Bug: https://bugs.openjdk.java.net/browse/JDK-8196322 webrev: http://cr.openjdk.java.net/~serb/alans/8196322/webrev.00/ When a default menu bar is set and the screen menu bar is in

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

hich contains > a list of properties for the Component and I assume it simply was not updated > when implementation of Component was updated(or updated in one place but not > other, etc). > >> Alan >>> On Nov 15, 2017, at 5:10 PM, Sergey Bylokhov <serg

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

), although unfortunately the lists are not identical. Alan > On Nov 15, 2017, at 5:10 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 15/11/2017 08:42, Alan Snyder wrote: >> If the solution is to listen for changes to the graphicsConfiguration >>

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

5, 2017, at 8:52 AM, Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > It seems I missed that point in the discussion. I agree the documenting the > new property make sense because of its importance for HiDPI. > > --Semyon > > On 11/15/2017 08:42 AM

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

t;>>>>>> create at least one auto test to check the behavior of new property. >>>>>>> I guess I am firing after the graphicsConfig has been changed from what >>>>>>> it was last time ie, after >>>>>>> if (grap

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Config automatically. >> - What about other classes which call BasicHTML.updateRenderer() in a >> propertyChange? for example: BasicToolTipUI, SynthToolTipUI, >> BasicButtonListener. > Yes, these needs to be updated as well. > http://cr.openjdk.java.net/~psadhukhan/8178025/web

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

er property too. Do you see any other property being > documented in our javadoc? > > Regards > Prasanta > On 11/7/2017 7:37 AM, Alan Snyder wrote: >> Is “graphicsConfig” a new public client property? I don’t see it documented >> anywhere. >> >> I t

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Is “graphicsConfig” a new public client property? I don’t see it documented anywhere. I think it should be public, or some public equivalent is needed, because there are cases where applications need to recompute a layout after the graphics configuration changes. Alan > On Oct 30, 2017,

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

u have > any test/steps which changes GC at "later" stage, please provide and I will > see if it does not call propertyChange. > > On 10/24/2017 11:13 AM, Alan Snyder wrote: >> You’re guessing? Really? >> >>> On Oct 23, 2017, at 10:

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

gards > Prasanta > On 10/23/2017 7:45 PM, Alan Snyder wrote: >> Does it handle the case where the graphics configuration is later changed? >> >> Alan >> >> >>> On Oct 22, 2017, at 11:23 PM, Prasanta Sadhukhan >>> <prasanta.sadhuk...@ora

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Does it handle the case where the graphics configuration is later changed? Alan > On Oct 22, 2017, at 11:23 PM, Prasanta Sadhukhan > wrote: > > > > On 10/19/2017 3:42 PM, Prasanta Sadhukhan wrote: >> >> >> On 10/19/2017 3:49 AM, Sergey Bylokhov wrote: >>>

Swing performance issue on JDK 9

I have a Swing program that works fine on JDK 8 but runs like a dog [unusably slowly] on JDK 9. My investigation finds the problem in text layout (e.g. FlowView.layout), which is a whopping 20–25 times slower on JDK 9. Any idea what might have changed to cause this slowdown? Could it be the

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Code would have to be changed to make it do that. I’m suggesting that is the right hook, but it is up to you to use it. Presumably as Swing is part of the JDK, access can be arranged... > On Oct 20, 2017, at 10:01 AM, Prasanta Sadhukhan > wrote: > > I do not

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

ee it being called with "ancestor" property name, I am not sure > if that is property that would be used to notify if gc is updated or not. > > Regards > Prasanta > On 10/19/2017 7:54 PM, Alan Snyder wrote: >> Do you mean JLabel.updateGraphicsData()? >> >&g

Re: [10] Review request for 8188081: Text selection does not clear after focus is lost

I’m confused about this part. Couldn’t a selection be in more than one inactive window at the same time and thus all use the inactive selection color? Alan > On Oct 19, 2017, at 11:36 AM, Semyon Sadetsky > wrote: > > - Selection may not be shown in the same

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Do you mean JLabel.updateGraphicsData()? Also, this issue could affect applications as well, if they are computing data based on layout information such as the default preferred size. What is the recommended method for an application to respond to a change in the graphics configuration? From

Re: [10] RFR JDK-8178025:HiDPI with non-integer scale factor - SPANs in HTML are rendered overlapping each other

Having run into similar problems, I believe this is an area where Swing has a serious design flaw. When a component is created, it has no idea which window it will be displayed in, and even when the window is known, the window could be moved to a different screen at any time. In addition, it

Re: [OpenJDK 2D-Dev] [10] Review Request: 8187399 Different problems in the javadoc's links in java.desktop package

It’s also not English, which not using @code would make it look like... > On Sep 15, 2017, at 12:34 PM, Phil Race wrote: > > 771 * @implNote Please note that for Mac OS, notifications > 772 * are only sent if the Java app is a bundled application, > 773

a possible bug in javax.swing.text.Utilities.getTabbedTextOffset

I believe I have found a bug in javax.swing.text.Utilities.getTabbedTextOffset. As the bug involves fractional metrics, it is not clear that it can be demonstrated without kludges, so I do not have a test program. If anyone is interested in the code and sees the same problem that I see, I will

repaint problem

I am having a problem involving repaint with no success as yet in tracking down the cause. Perhaps someone can suggest something that would help me make some progress. The symptom is that some portion of a repaint operation is delayed until the next repaint. In other words, I make a change to

Re: [9] Review request for 8027639: JComboBox's popup leaves tracks after closing

> On Nov 24, 2016, at 7:18 AM, Semyon Sadetsky > wrote: > >> If someone(in the application) change the background to transparent color >> then it should change opaque state as well. > Can you prove this statement at least with a reference to spec? It seems >

Re: [9] Review request for 8156217 Selected text is shifted on HiDPI display

Suppose an application is only partially fixed to use/override the floating point methods. Perhaps it uses a library that has not been fixed. Is there a more fine grained way to detect programmer awareness or lack of awareness of the new methods? Alan > On Jun 28, 2016, at 9:59 AM,

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

to Aqua as suggested by Sergey. > > Regards, > Rajeev Chamyal > > -Original Message- > From: Alexandr Scherbatiy > Sent: 11 May 2016 01:16 > To: Alan Snyder; swing-dev@openjdk.java.net > Subject: Re: [9] Review request for JDK-8147521 [macosx] Internal > API Usa

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

I use only heavy weight. > On May 10, 2016, at 12:46 PM, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > Do you need to use medium-weight popups in your application or > light/heavy-weight popups are enough? > > Thanks, > Alexandr. >

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

> On May 10, 2016, at 5:58 AM, Sergey Bylokhov > wrote: > > Hi, Alan. > Can you please take a look to the proposed solutions? Thanks. > > Approach 2 matches what I currently do. The problem noted by Rajeev does not happen because my popup factory calls

Re: internal API usage: PopupFactory.setPopupType()

> wrote: > > Hi, Alan. > Did you try to use JPopupMenu.setLightWeightPopupEnabled() for this usecase? > > On 17/01/16 07:19, Alan Snyder wrote: >> I have submitted an RFE to make the functionality >> of PopupFactory.setPopupType() publicly available. >>

internal API usage: PopupFactory.setPopupType()

I have submitted an RFE to make the functionality of PopupFactory.setPopupType() publicly available. JI-9028692 Regards, Alan

design question regarding UI defaults and painting

I am curious about a design decision that was made in the implementation of textured window backgrounds in the Aqua LAF/AWT. In a nutshell, a textured window background is an optional NSWindow background style that involves gradients. Textured windows are requested in Java using a window

JScrollPane optimized drawing issue

I have implemented a scroll pane UI that simulates the modern OS X scroll bars that are painted over the viewport rather than occupying their own space in the scroll pane. Overlaying the scroll bars requires that the scroll pane return false from isOptimizedDrawingEnabled(). However,

Re: Swing Dev Public API for internal Swing classes.

Although not strictly a Swing issue, this request could be of interest for platform specific LAFs: JDK-8133998 https://bugs.openjdk.java.net/browse/JDK-8133998 Provide public API to make natively rendered images cacheable On Aug 6, 2015, at 2:39 AM, Alexander Scherbatiy

Swing Dev JTable layout problem

I would like to raise awareness of bug JDK-5108458 https://bugs.openjdk.java.net/browse/JDK-5108458 (from 2004), similar to JDK-4514643 https://bugs.openjdk.java.net/browse/JDK-4514643 (from 2001). In a nutshell, the bug affects the layout of the table body when the table has RTL orientation

Swing Dev OS X screen menu bar support in JDK 9

I am wondering whether the hiding of JDK internal classes in JDK 9 might prevent a third party look and feel from using the screen menu bar. The reason is that the screen menu bar support is tightly bound to classes in the Aqua look and feel, specifically AquaMenuBarUI and AquaMenuItemUI, which

Re: Swing Dev AWT Dev internal API usage: sun.awt.AppContext

there will be a class per classloader. If necessary you can roll your own that just uses the ThreadGroup as a key to get to a map .. that's what it amounts to. -phil. On 06/02/2015 10:37 AM, Alan Snyder wrote: Is this the proper forum for asking this question? I have not seen any reply. On May 28

Re: Swing Dev internal API usage: sun.awt.AppContext

Is this the proper forum for asking this question? I have not seen any reply. On May 28, 2015, at 7:13 PM, Alan Snyder javali...@cbfiddle.com wrote: I am using code — a custom Swing look and feel — that uses the getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext

Swing Dev internal API usage: sun.awt.AppContext

I am using code — a custom Swing look and feel — that uses the getAppContext(), get(), put(), and remove() methods of sun.awt.AppContext to store configuration data. Since the look and feel is registered by UIManager using the same mechanism, this seems like the right way to store

Re: Swing Dev customizing LFs in JDK9

, or perhaps exposed - perhaps being a key word. Note that bundling a JRE is not the same thing as building your own bundling. I expect most applications will want to work with a pre-built Oracle JDK which will hide internal APIs. Perhaps On 5/15/2015 12:09 PM, Alan Snyder wrote

Swing Dev customizing LFs in JDK9

If my understanding is correct, the classes for several JDK specific LFs (Aqua, GTK, and Windows) will become inaccessible to applications in JDK9. Is this true? I am concerned about the impact of this change for the Aqua look and feel, which historically has lagged behind the platform UI and

Re: Swing Dev customizing LFs in JDK9

the changes in a jar on the class path will not work with the modular JDK even if we made all of these classes public and exported .. jigsaw does not allow such split packages. -phil. On 5/15/2015 1:10 PM, Alan Snyder wrote: Bundled apps run without a Security Manager, at least they do for me

Swing Dev Aqua LAF on Yosemite

I would like to comment on the bug report regarding the Aqua LAF on Yosemite. Where is it? I found bug JDK-8052173, but it was closed as a duplicate. A comment says it is a duplicate of JDK-8051717, but I cannot find or see that bug report. Is it a secret bug report?