On Wed, 25 Aug 2021 12:47:41 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/java/net/URLPermission.java line 222:
>>
>>> 220:
>>> 221: List l = normalizeMethods(methods);
>>> 222: l.sort(null);
>>
>> I am not opposed to this change, but I find this is slightly
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote:
>> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(up
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
On Fri, 30 Jul 2021 10:38:58 GMT, Prasanta Sadhukhan
wrote:
>> JComponent.setUIProperty method uses string identity check (==) rather than
>> string equality checks (.equals) when comparing against the property name.
>> This is suspicious since string identity and equality and equivalent only
On Fri, 30 Jul 2021 10:35:46 GMT, Prasanta Sadhukhan
wrote:
> I am not sure of switch which probably might be a hindrance in backporting if
> needed to earlier release trains.
You still can use the old switch statement with breaks.
-
PR:
On Fri, 30 Jul 2021 06:04:17 GMT, Prasanta Sadhukhan
wrote:
> JComponent.setUIProperty method uses string identity check (==) rather than
> string equality checks (.equals) when comparing against the property name.
> This is suspicious since string identity and equality and equivalent only
On Wed, 28 Jul 2021 07:24:38 GMT, Prasanta Sadhukhan
wrote:
> This test was failing in CI test run due to timing issue. Adjusted robot
> delay..Also, made frame to show in middle of screen and dispose of frame at
> end.
> CI test run is green.
Marked as reviewed by azvegint (Reviewer).
On Wed, 2 Jun 2021 01:14:39 GMT, Sergey Bylokhov wrote:
> Some useful documentation was added to the JPasswordField.
Marked as reviewed by azvegint (Reviewer).
src/java.desktop/share/classes/javax/swing/JPasswordField.java line 68:
> 66: * handling confidential information such as the
On Mon, 17 May 2021 09:05:06 GMT, Prasanta Sadhukhan
wrote:
> This testcase has failed intermittently in CI testing citing icon and
> ImageIcon images are not same.
> It's been observed that the rectangle been passed to
> Robot.createScreenCapture was incorrect to compare the icon images but
On Mon, 17 May 2021 05:13:06 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Example in JavaDoc fixed
Marked as reviewed by azvegint (Reviewer).
On Fri, 14 May 2021 19:46:03 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Slight change of wording in javadoc
> Fixed
On Sat, 8 May 2021 16:01:28 GMT, Alexander Zuev wrote:
>> Fixed popup position taking into account its offset
>> Added a lot of screenshots taking to better understand failures should they
>> happen down the line
>
> Alexander Zuev has updated the pull request incrementally with one additional
On Mon, 3 May 2021 17:09:59 GMT, Pankaj Bansal wrote:
> > Looks like it requires CSR.
>
> I think CSR is not required in this case. CSR would have been required if
> return type was being changed. Here the change only says that the function
> can return both true or false instead of just
On Sun, 2 May 2021 06:09:23 GMT, Pankaj Bansal wrote:
> There is a small error in javadoc for doAccessibleAction function added in
> AccessibleJSlider class under JDK-8262981. The documentation says that the
> API returns true always, whereas it can return both true or false depending
> upon
On Tue, 13 Apr 2021 19:24:43 GMT, Alexander Zvegintsev
wrote:
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removin
On Fri, 16 Apr 2021 09:52:35 GMT, Alexander Zuev wrote:
> 8039270: The background color of the button can't be displayed and when
> pressed the button, the background color can not be changed in accordance
> with the case described.
Marked as reviewed by azvegint (Reviewer).
-
On Fri, 16 Apr 2021 13:54:05 GMT, Alexander Zvegintsev
wrote:
>> This manual test was written for Metal L, so now it is set explicitly.
>> Test is also refactored to use JFrame instead of Applet.
>>
>> The test is not in `ProblemList.txt`.
>> It still fails
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removing all syntactic sugar).
Alexander Zvegintsev has updated t
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removing all syntactic sugar).
Alexander Zvegintsev has updated t
On Fri, 16 Apr 2021 11:17:05 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> trailing whitespace
>
> test/jdk/javax/swing/JCheckBox/4449413/bug
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removing all syntactic sugar).
Alexander Zvegintsev has updated t
On Thu, 15 Apr 2021 09:39:12 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> allow to run it with different L
>
> test/jdk/javax/swing/JCheckBox/44
On Wed, 14 Apr 2021 12:43:38 GMT, Prasanta Sadhukhan
wrote:
> I am referring to check mark only, not the shape...I could see the white
> visible selected checkmark(circular) for RadioButton when "Ocean Theme" is
> not selected but when "Ocean Theme" is selected, black checkmark over black
>
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removing all syntactic sugar).
Alexander Zvegintsev has updated t
On Wed, 14 Apr 2021 12:12:59 GMT, Prasanta Sadhukhan
wrote:
> Modified test instruction to point that IME option is supposed to be "Full
> width Katakana" for the test to pass which by default was picking up "Half
> width Alphanumeric" english style input IME option.
Marked as reviewed by
On Wed, 14 Apr 2021 06:45:16 GMT, Prasanta Sadhukhan
wrote:
> I see RadioButton and RBMenuItem check mark is not visible...so probably
> there is still a product bug somewhere...I guess we need to fix that as well
> when we fix this test..
Actually it is clearly visible. You can click on it
On Tue, 13 Apr 2021 20:14:46 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tuned for standalone mode.
>
> test/jdk/javax/swing/JCheckBox/4449413/bug
> This manual test was written for Metal L, so now it is set explicitly.
> Test is also refactored to use JFrame instead of Applet.
>
> The test is not in `ProblemList.txt`.
> It still fails on JDK 1.5 (after removing all syntactic sugar).
Alexander Zvegintsev has updated t
This manual test was written for Metal L, so now it is set explicitly.
Test is also refactored to use JFrame instead of Applet.
The test is not in `ProblemList.txt`.
It still fails on JDK 1.5 (after removing all syntactic sugar).
-
Commit messages:
- trailing whitespaces fix
-
On Thu, 8 Apr 2021 14:43:50 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Wed, 7 Apr 2021 06:39:48 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Tue, 30 Mar 2021 19:05:37 GMT, Andrey Turbanov
wrote:
>> There are few possible cleanups in java.desktop related to legacy
>> StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String
>> concatenation.
>> 2. StringBuffer can be replaced with StringBuilder.
On Sat, 3 Apr 2021 22:28:54 GMT, Alex Blewitt
wrote:
>> 8264680: Use the blessed modifier order in java.desktop
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Additionally remove detritus from PNGImageDecoder.java
On Thu, 4 Mar 2021 05:50:18 GMT, Tejpal Rebari wrote:
>> Please review the following fix for jdk17.
>> In this fix i have deprecated and marked for removal following classes and
>> methods
>>public void intervalAdded(ListDataEvent e)
>>public void intervalRemoved(ListDataEvent e)
>>
On Wed, 31 Mar 2021 16:23:23 GMT, Jie Fu wrote:
> Hi all,
>
> I'd like to fix the timeout of
> javax/swing/text/html/parser/Parser/8078268/bug8078268.java.
> It seems to take about 6~7 seconds to run on some of our testing platforms.
> But the timeout of the test is hard-coded as 5 seconds.
>
On Tue, 23 Mar 2021 10:26:42 GMT, Prasanta Sadhukhan
wrote:
> SonarCloud reports the potential issue with
> MetalHighContrastTheme.getControlHighlight where `controlHighlight ` field is
> not used and the getControlHighlight() uses secondary field.
> public ColorUIResource
On Mon, 22 Mar 2021 22:19:18 GMT, Alexander Zvegintsev
wrote:
> Looks like the original idea was to set `fallbacktext` on strings containing
> only spaces.
>
> I decided to remove the `trim()` call to keep the same behavior and to allows
> to set such meaningless space only
On Tue, 23 Mar 2021 10:26:42 GMT, Prasanta Sadhukhan
wrote:
> SonarCloud reports the potential issue with
> MetalHighContrastTheme.getControlHighlight where `controlHighlight ` field is
> not used and the getControlHighlight() uses secondary field.
> public ColorUIResource
On Tue, 23 Mar 2021 22:13:21 GMT, Sergey Bylokhov wrote:
>> Yes, I think it would be better to allow to set empty text to conform with
>> other LaF behavior.
>>
>> Also `JFileChooser.getApproveButtonText()` and
>> `JFileChooser.getApproveButtonToolTipText()` will now return correct values
>>
On Tue, 23 Mar 2021 05:00:45 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> allow empty text
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaF
e want empty label for some reason).
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
allow empty text
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3136/files
- new: https://git.openjdk.java.net/j
On Tue, 23 Mar 2021 05:53:30 GMT, Prasanta Sadhukhan
wrote:
> The constructor JEditorPaneAccessibleHypertextSupport javadoc wording is
> wrong. Rectified the anomaly.
Marked as reviewed by azvegint (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3145
Looks like the original idea was to set `fallbacktext` on strings containing
only spaces.
I decided to remove the `trim()` call to keep the same behavior and to allows
to set such meaningless space only titles/tooltips(same as on other platforms,
maybe someone want empty label for some
On Fri, 19 Mar 2021 11:15:03 GMT, Prasanta Sadhukhan
wrote:
>> Default implementation of
>> JFormattedTextField.AbstractFormatter.getDocumentFilter()/getNavigationFilter()
>> returns null but it is not mentioned in the spec.
>> It is now explicitly mentioned in the spec by @impNote tag.
>
>
On Sat, 20 Feb 2021 12:17:32 GMT, Сергей Цыпанов
wrote:
> This is a very simple and trivial improvement about getting rid of pointless
> char wrapping into array
Marked as reviewed by azvegint (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2660
On Thu, 11 Mar 2021 04:40:25 GMT, Prasanta Sadhukhan
wrote:
>> ListModel class javadoc refers to ListDataModel interface but there is no
>> ListDataModel interface. Rectified the anomaly.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the
On Wed, 10 Mar 2021 04:38:19 GMT, Prasanta Sadhukhan
wrote:
>> BasicTextUI: installDefaults javadoc specifies only font, foreground and
>> background properties are set if their current value is either null or a
>> UIResource
>> and other properties are set if the current value is null
>>
On Tue, 9 Mar 2021 04:10:38 GMT, Prasanta Sadhukhan
wrote:
> javadoc of ComboBoxModel incorrectly specifies "extends ListDataModel" but
> actually it extends ListModel and there is no such interface as
> ListDataModel. Rectified the anomaly.
Marked as reviewed by azvegint (Reviewer).
On Tue, 9 Mar 2021 08:09:04 GMT, Prasanta Sadhukhan
wrote:
> BasicTextUI: installDefaults javadoc specifies only font, foreground and
> background properties are set if their current value is either null or a
> UIResource
> and other properties are set if the current value is null
> but in
On Wed, 3 Mar 2021 05:14:11 GMT, Alexander Zuev wrote:
>> 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with
>> "Exception: Failed to hide opaque button"
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 2 Mar 2021 09:15:22 GMT, Alexander Zuev wrote:
> 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with
> "Exception: Failed to hide opaque button"
test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 112:
> 110: frh = bounds.height - insets.top -
On Sat, 27 Feb 2021 17:02:13 GMT, Alexander Zvegintsev
wrote:
> This issue occurs only under `MetalLookAndFeel` on Linux.
>
> It was introduced by
> [JDK-8040630](https://bugs.openjdk.java.net/browse/JDK-8040630) fix.
>
>> component.setBounds(ownerX, ownerY, 1, 1)
On Mon, 1 Mar 2021 04:08:43 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> simplified test
>
> test/jdk/javax/swing/JToolTip/FastTooltipSw
)` for negative sizes.
> The provided test fails for me in 0-30s interval(before the fix), other
> testing(client-tier1,2,3) looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
Do not fail on UnsupportedLookAnd
On Sat, 27 Feb 2021 21:42:30 GMT, Sergey Bylokhov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> simplified test
>
> test/jdk/javax/swing/JToolTip/FastTooltipSw
)` for negative sizes.
> The provided test fails for me in 0-30s interval(before the fix), other
> testing(client-tier1,2,3) looks good.
Alexander Zvegintsev has updated the pull request incrementally with one
additional commit since the last revision:
simplified test
-
C
This issue occurs only under `MetalLookAndFeel` on Linux.
It was introduced by
[JDK-8040630](https://bugs.openjdk.java.net/browse/JDK-8040630) fix.
> component.setBounds(ownerX, ownerY, 1, 1);
This line adds an extra reshape call with `1x1` size right before getting
another one with correct
On Mon, 22 Feb 2021 09:45:31 GMT, Prasanta Sadhukhan
wrote:
> It is seen
> JTextArea.setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT)
> orientation is not honoured if it is called after setText() and remain at LTR
> orientation. It changes the orientation only if some more text is
looks fine to me.
Thanks,
Alexander.
On 10/27/2017 04:48 AM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The EventListenerList class was implemented to be thread safe. To
achieve the correct state of the object:
- two mutators(add/remove) were marked as synchronized.
-
Hi Semyon,
the fix looks good to me, but I found a minor typo in the test:
testShortcatPanelFiles -> testShortcutPanelFiles
no need for a new webrev
Thanks,
Alexander.
On 04/10/2017 00:41, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK10 (the changes involve AWT and Swing):
bug:
+1
Thanks,
Alexander.
On 16/09/2017 07:16, Sergey Bylokhov wrote:
That's of course a stylistic issue, but I think that the keywords(not
necessary a java) look better when they are highlighted. Depending
from the style it can look like this:
http://cr.openjdk.java.net/~serb/8187399/img.png
+1
Thanks,
Alexander.
On 14/09/2017 04:09, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
Some of the tidy warnings were fixed.
Report is here:
http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html
Description:
- java/awt/Desktop.java: the
+1
Thanks,
Alexander.
On 22/09/2017 06:09, Anton Litvinov wrote:
Hello Sergey,
Thank you very much for review of this fix. The second version of the
fix with minor changes in 3 places which address your remarks is
created. The new fix version applied to the today's version of the
Looks fine.
Thanks,
Alexander.
On 03/09/2017 07:01, Sergey Bylokhov wrote:
Any volunteers to review?
Thank you =)
On 8/27/17 14:19, Sergey Bylokhov wrote:
Hi,
I would like to propose a new review as a solution which I think
should solve the problem:
Bug:
Looks fine.
Thanks,
Alexander.
On 30/08/2017 12:10, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The MotifGraphicsUtils is an internal utility class, it have some unused
methods.
These methods were removed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8186967
Webrev can
Looks good.
Thanks,
Alexander.
On 09/08/2017 10:28, Prasanta Sadhukhan wrote:
ok. Request to review.
Regards
Prasanta
On 8/8/2017 9:52 PM, Kevin Rushforth wrote:
I think this should be reviewed on the swing-dev list, since the
stack trace and proposed fix are both entirely in Swing code.
Looks fine to me.
Thanks,
Alexander.
On 11/07/2017 07:26, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
Two typos were fixed. Actually the tests are more complicated than the fix
itself.
Bug: https://bugs.openjdk.java.net/browse/JDK-8134256
Webrev can be found at:
Looks good to me.
Thanks,
Alexander.
On 21/06/2017 14:13, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where tooltip for "Home" or Desktop
button is in English even though locale is non-English.
This is because even though i18n properties has
Looks good to me.
Thanks,
Alexander.
On 14/06/2017 12:03, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen that
when clicking the right-most pixel of a JComboBox the related Popup
opens and closes immediately. This is non-standard behaviour.
Issue was,
Hi Prasanta,
If app again calls setKeymap(null) then the static variable will be
"true" and it will reset back to default keymap.
It doesn't seem to be relevant to this fix. setKeymap(): " Setting to
null effectively disables keyboard input." As it does with
you fix.
Otherwise the fix
Thanks for clarification, looks good to me.
Thanks,
Alexander.
On 07/06/2017 23:22, Sergey Bylokhov wrote:
Hi, Alexander.
These closing tags are optional in html5 standard [1]. On the link to
the SO there are three the example which work differently but
according standards[2][3][4].
[1]
Hi Sergey,
Why do we omitting closing th tag?
e.g.
+ * Metal's system color mapping
+ *
+ *
+ * Key
+ * Value
+ *
I know that HTML parsers are usually forgiving such things. But
sometimes it may make thing worse:
+1
Thanks,
Alexander.
On 28/03/2017 14:21, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 3/28/2017 1:41 AM, Phil Race wrote:
webrev: http://cr.openjdk.java.net/~prr/8043773/
bug : https://bugs.openjdk.java.net/browse/JDK-8043773
This just deprecates the
Looks good to me;
Thanks,
Alexander.
On 14/03/2017 13:54, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8174845
webrev: http://cr.openjdk.java.net/~alexsch/8174845/webrev.00
Metal JCheckBox and JMenuItem icons are updated to
+1
Thanks,
Alexander.
On 15/03/2017 15:33, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 3/14/2017 6:12 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk9.
In the fixes for JDK-7072653 [1] and JDK-8129838 [2] and JDK-8144161[3]
[1]
+1
--
Thanks,
Alexander.
On 01.03.2017 6:44, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8175831
webrev: http://cr.openjdk.java.net/~prr/8175831/
Adds missing javadoc description.
I observed that javadoc is not actually generated for this module
and makefiles needed to be
Looks good.
On 10/7/16 4:21 PM, Sergey Bylokhov wrote:
On 07.10.16 10:06, Semyon Sadetsky wrote:
Hi Sergey,
After applying the patch I found 72 usages of the Event class. Why they
are not replaced?
By the same reason why InputEvent.getModifiers() was not replaced by
+1
On 10/6/16 11:18 AM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8164321
webrev: http://cr.openjdk.java.net/~ssadetsky/8164321/webrev.00/
The issue is caused by concurrent XLib access form FX and AWT toolkit
threads in case of
+1
--
Thanks,
Alexander.
On 07/07/2016 12:51 PM, Semyon Sadetsky wrote:
Looks good to me.
--Semyon
On 07.07.2016 12:33, Alexandr Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8160879
webrev:
Vote: yes
--
Thanks,
Alexander.
On 06/23/2016 09:21 AM, Alexandr Scherbatiy wrote:
I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to
Membership in the Swing Group.
Sergey is active member of Swing group and contributed a lot of fixes
which include Aqua L, Retina support on
, 2016 at 2:01 PM, Alexander Zvegintsev
<alexander.zvegint...@oracle.com> wrote:
You should create the diff against the repository. This will
allow to test your fix without applying a bunch of patches.
--
Thanks,
Alexander.
On 06/29/2016 02:49 PM, Robin Stevens
one which contains the diff compared to the current
tip of the repository, or do I need to create one which contains the
diff compared to my previous patch ?
Robin
On Wed, Jun 29, 2016 at 12:03 PM, Alexander Zvegintsev
<alexander.zvegint...@oracle.com
<mailto:alexander.zvegint...@orac
amount of RAM (250G or more)?
--Semyon
On 6/28/2016 6:08 PM, Alexander Zvegintsev wrote:
Hi all,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8158325/00/index.html
for the issue
https://bugs.openjdk.java.net/browse/JDK-8158325
Hi Robin,
- The cleanup code was not triggered when removeAll() was called from
the updateItems method. I fixed this by overriding the remove(int)
method, and putting the cleanup code in that method. An alternative
here would be to not override the remove(int) method, but instead call
Vote: yes
--
Thanks,
Alexander.
On 21.03.2016 9:01, Alexander Scherbatiy wrote:
I hereby nominate Semyon Sadetsky (OpenJDK user name: ssadetsky) to
Membership in the Swing Group.
Semyon is active member of Swing group and contributed a lot of fixes
which include Swing TimerQueue race
+1
--
Thanks,
Alexander.
On 09/24/2015 02:30 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/23/2015 7:55 PM, Sergey Bylokhov wrote:
Yes, Thanks.
The new version:
http://cr.openjdk.java.net/~serb/8135122/webrev.02/
AquaUtilControlSize.applyUISizing
Hi Shilpi,
The fix looks good to me.
Thanks,
Alexander.
On 09/16/2015 09:37 AM, shilpi rastogi wrote:
Hi All,
Please review the fix
Bug: https://bugs.openjdk.java.net/browse/JDK-7133530
webrev: http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev/
Issue: Colored text is not shown on
Hi Sergey,
the fix looks good to me.
Thanks,
Alexander.
On 09/14/2015 03:29 PM, Sergey Bylokhov wrote:
Hello.
Please review the small fix for jdk9.
The unspecified COMPONENT_UI_PROPERTY_KEY property was removed,
because it was replaced by the public method in jdk9 [1].
[1]
+1
Thanks,
Alexander.
On 09/10/2015 04:15 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/10/2015 3:31 PM, Semyon Sadetsky wrote:
Correct. It causes i18n layout errors
[https://bugs.openjdk.java.net/browse/JDK-8076164].
GlyphView calculates its
looks fine.
Thanks,
Alexander.
On 09/08/2015 02:24 PM, shilpi rastogi wrote:
Hi all,
Please review a bug fix
Bug Link- https://bugs.openjdk.java.net/browse/JDK-8135176
http://cr.openjdk.java.net/~psadhukhan/shilpi/webrev/
Thanks,
Shilpi
Hello Sergey,
the fix looks good to me.
--
Thanks,
Alexander.
On 07.09.2015 15:48, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
Initially I found this bug in JSpinner during my work on
JDK-7124397, after I covers other components in the test I found other
cases in Aqua.
The
+1
Thanks,
Alexander.
On 08/31/2015 04:54 PM, Sergey Bylokhov wrote:
Looks fine.
On 31.08.15 15:19, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8134721
webrev: http://cr.openjdk.java.net/~alexsch/8134721/webrev.00
The
BTW, there is no need in try/catch block.
Thanks,
Alexander.
On 08/27/2015 03:08 PM, Alexander Scherbatiy wrote:
On 8/27/2015 1:12 PM, pooja chopra wrote:
Hi Alexandr,
Please review updated webrev link :-
http://cr.openjdk.java.net/~pchopra/8130481/webrev.06/
There are some problems
Hi Shilpi,
56 test();
57 f.dispose();
In case of test failure runtime exception will be thrown, thus
f.dispose() will not be called.
So it would be better to call it from a finally block.
The fix contains mixed tab/spaces indentation(we are using spaces),
trailing
+1
Thanks,
Alexander.
On 08/21/2015 06:12 PM, Sergey Bylokhov wrote:
On 21.08.15 16:12, Alexander Scherbatiy wrote:
On 8/21/2015 2:18 PM, Sergey Bylokhov wrote:
Hi, Alexander.
It seems this is only a part of the request. It does not cover some
situations like java properties, which can be
+1
Thanks,
Alexander.
On 08/21/2015 02:41 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 8/21/2015 2:37 PM, Sergey Bylokhov wrote:
On 21.08.15 14:20, Alexander Scherbatiy wrote:
On 8/21/2015 1:49 PM, Sergey Bylokhov wrote:
I just double checked that
The fix looks good to me.
Thanks,
Alexander.
On 08/06/2015 11:29 AM, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8081411
webrev: http://cr.openjdk.java.net/~alexsch/8081411/webrev.00
The following use case were considered:
+1
Thanks,
Alexander.
On 07/29/2015 01:39 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/29/2015 10:00 AM, pooja chopra wrote:
Hi ,
As default look and feel in mac is aqua only so there is no need of
setting system look and feel explicitly.
+1
Thanks,
Alexander.
On 07/22/2015 10:49 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/16/2015 10:00 AM, nadeesh tv wrote:
|Hi all,|
|Please review a ||*Test **bu**g *fix ||for| |the issue
|
JDK-8028618:[TEST BUG]
looks fine to me.
--
Thanks,
Alexander.
On 17.07.2015 17:32, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8130892
webrev: http://cr.openjdk.java.net/~ssadetsky/8130892/webrev.00/
On Linux and Solaris platforms the initial frame
1 - 100 of 177 matches
Mail list logo
