Re: [OpenJDK 2D-Dev] RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports - (client/desktop)

Hi. That is correct. Sources of Jemmy in JDK repository is a copy of sources from code-tools Jemmy project. Any changes should be done there first, and then propagated to the jdk testable. Thank you for the good catch, Sergey, Shura > On May 4, 2020, at 8:03 PM, Sergey Bylokhov > wrote:

RFR JDK-8236044 Create jdk_accessibility test group

Hi. Can you please take a look on this minor change. Bug: https://bugs.openjdk.java.net/browse/JDK-8236044 Webrev: http://cr.openjdk.java.net/~shurailine/JDK-8236044/webrev.00/ Shura

Re: [13] RFR [JDK-8211322] Reduce the timeout of tooltip in SwingSet2DemoTest

Hi. SwingSet2DemoTest.java changes look good. I have a small comment on JToolTipOperator changes: 323Thread.currentThread().interrupt(); 324throw (new JemmyException("Waiting of " + waitable.getDescription() 325+ " state has been interrupted!")); only

Re: [13] RFR [JDK-8217235] Create automated test for SwingSet ColorChooserDemoTest

Looks good. Shura > On Jan 16, 2019, at 4:50 AM, Vikrant Agarwal > wrote: > > Hi All, > > Please review this new test for SwingSet3 ColorChooserDemo: > > Task: https://bugs.openjdk.java.net/browse/JDK-8217235 > > > Webrev:

Re: [13] RFR JDK-8214471 : Enable different look and feel tests in SwingSet3 demo test ToolTipDemoTest

Looks good. Shura > On Jan 14, 2019, at 7:34 AM, Muneer Kolarkunnu > wrote: > > Hi All, > > Please review fix for the task: > Task: https://bugs.openjdk.java.net/browse/JDK-8214471 > > Webrev:

Re: RFR 8186549: move ExtendedRobot closer to tests

I have updated the web rev accordingly: http://cr.openjdk.java.net/~shurailine/8186549/webrev.01/test/jdk/java/awt/Modal/ModalBlockingTests/BlockingDFSetModalTest.java.sdiff.html Let me know if there are other concerns. Shura > On Nov 7, 2018, at 3:05 PM, Alexandre (Shura) Iline >

Re: RFR 8186549: move ExtendedRobot closer to tests

That aside, Phil, Sergey, I would really like your opinion on test selection. Did I run the right tests to verify the fix? Shura > On Nov 7, 2018, at 3:05 PM, Alexandre (Shura) Iline > wrote: > > Phil, Igor, > > A quick check shows that indeed most of cases where a

Re: RFR 8186549: move ExtendedRobot closer to tests

28 > * @summary [macosx] Swing. JDialog. Modal dialog goes to background > * @author Alexandr Scherbatiy > - * @library ../../../../lib/testlibrary > + * @library ../../../../lib/client > * @build ExtendedRobot > * @run main ModalDialogOrderingTest > */ > public c

Re: RFR 8186549: move ExtendedRobot closer to tests

Ping. > On Oct 29, 2018, at 3:02 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please take a look on this fix for JDK-8186549. > > For testing I have selected tests and groups of tests which use the > ExtendedRobot class. The tests show the same pass rate. T

RFR 8186549: move ExtendedRobot closer to tests

Hi. Please take a look on this fix for JDK-8186549. For testing I have selected tests and groups of tests which use the ExtendedRobot class. The tests show the same pass rate. There are still few tests which use lib/testlibrary, they are not affected by this fix. Task:

Re: [12] RFR JDK-8210052:Enable testing for all the available look and feels in SwingSet3 demo tests

Vikrant, There were no changes needed to the TestHelpers class itself, correct? You should try to avoid formatting changes as it makes it harder to review. Otherwise looks good. Thank you. Shura > On Sep 4, 2018, at 2:03 AM, Vikrant Agarwal > wrote: > > Hi All, > > Please review the fix

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

. > If there are some issues like > - absent of the image files > - errors in the file system > - bugs in EditorPane, etc > which prevent the correct representation of the text in EditorPane, then the > test should fail. But the test passed when I applied the patch without images. >

Re: [12] RFR [TEST][JDK-8209499] Create test for SwingSet3 EditorPaneDemo

Sergey, > On Aug 20, 2018, at 4:11 PM, Sergey Bylokhov > wrote: > > Hi, Muneer. > Is it possible to enhance the test so it will fail if the images are not > loaded by the editor pane(it will pass if you apply the patch w/o images)? I am trying to understand the use case. The images would be

Re: [12] RFR [JDK-8209418] : Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

I have reviewed all the changes - looks good. Shura > On Aug 13, 2018, at 4:50 AM, Muneer Kolarkunnu > wrote: > > Hi, > > Please take a look on the set of changes brought into JDK Jemmy copy from the > code-tools Jemmy repository. > Task id: https://bugs.openjdk.java.net/browse/JDK-8209418

Re: [12] RFR [JDK-8209198] [macosx]Jemmy: JFileChooserOperator.selectFile(..) throws NullPointerException on Mac

The original fix belongs to me , so I do not qualify as a reviewer. I, however, have a comment that perhaps we could import multiple changesets in code-tools/jemmy/v2 with one changeset in jdk/jdk. I have done it in the past, that’s for sure: https://bugs.openjdk.java.net/browse/JDK-8188779

Re: [11] RFR [JDK-8202718] Jemmy JInternalFrameOperator: Dependency with orders of Minimize, Maximize and Close buttons

These changes seem to be consistent with what’s in Jemmy code-tools repository and, therefore, correct. Shura > On May 7, 2018, at 5:47 AM, Muneer Kolarkunnu > wrote: > > Hi All, > > Please review fix for a bug in jemmy: > Bug:

RFR JDK-8198922 Provide instrumentation for sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java

Hi, Could you please take a look on this fix? This fix adds some instrumentation to an existing test which is known to fail intermittently. Bug: https://bugs.openjdk.java.net/browse/JDK-8198922 Webrev: http://cr.openjdk.java.net/~shurailine/8198922/webrev.00/ Thank you. Shura

Re: [10] RFR JDK-8191803 : [TEST_BUG] : sanity/client/SwingSet/src/ProgressBarDemoTest.java failed with "Wait "greater then 1349" state to be reached

> On Dec 4, 2017, at 10:54 AM, Phil Race wrote: > > From memory, I think Sergey is right that the jtreg default time out is 2 > minutes (120 seconds). > As to changing that to 3 minutes .. that is something that needs to be > decided at a jtreg ownership level. I

RFR 8191616: [TEST_BUG] : sanity/client/SwingSet/src/SliderDemoTest.java: Failed with TimeoutExpiredException: Wait "Wait till Slider attains the specified state."

Hi. Please take a look on a quick fix for one of the client sanity tests. The tests is known fo file periodically with the same problem. Bug: https://bugs.openjdk.java.net/browse/JDK-8191616 Webrev: http://cr.openjdk.java.net/~shurailine/8191616/webrev.00/ Thank you. Shura

Re: RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

c-all > > If the bug is fixed then this record can be removed. Ah! Thank you! New webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.01 Shura > > > On 14/11/2017 11:03, Alexandre (Shura) Iline wrote: >> Hi, >> Please take a look on this fix. >> Bug: htt

RFR: 8157338 sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java is unstable

Hi, Please take a look on this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8157338 I have changed the code to _wait_ for the image change and I have also replaced some of the homemade code with proper Jemmy calls. Webrev: http://cr.openjdk.java.net/~shurailine/8157338/webrev.00/ Thank

RFR JDK-8188824: sanity/client/SwingSet/src/ProgressBarDemoTest: Failed with NullPointerException

Please take a quick look on this simple fix. Webrev: http://cr.openjdk.java.net/~shurailine/8188824/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8188824 This fix is a copy of fix made in the Jemmy code-tools repository. Webrev:

RFR 8188779: Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2

Hi, Please take a look on the set of changes brought into JDK Jemmy copy from the code-tools Jemmy repository. The changes include next fixes and enhancements 1. CODETOOLS-7901931: JFileChooserOperator.enterSubDir does not navigate to sub directory 2. CODETOOLS-7901925: Add subcomponents

Re: [10] RFR JDK-8184272 : Jemmy JFileChooserOperator.enterSubDir does not navigate to sub directory

Hi. Semyon, this is a good idea, this is indeed where we want to be, but we are not there yet. We need one thing to happen first to have the code-tools Jemmy repo to be used for development and the openjdk jdk/test to only contain a read-only copy: there must be some test support in the

Re: [10] RFR JDK-8184272 : Jemmy JFileChooserOperator.enterSubDir does not navigate to sub directory

Will you be preparing a parallel fix to the Jemmy code-tools repo? Shura > On Jul 13, 2017, at 2:50 AM, Vikrant Agarwal > wrote: > > Hi All, > Please review the following: > > Bug : JDK-8184272 > > JDK 10

Re: [10] RFR JDK-8184325: Add subcomponents accessor methods to JColorChooserOperator

Looks good. Thank you. Shura > On Jul 13, 2017, at 1:53 AM, Vikrant Agarwal > wrote: > > Hi All, > Please review the following fix: > Bug : JDK-8184325 > JDK 10 Webrev:

Re: [10] RFR JDK-8184272 : Jemmy JFileChooserOperator.enterSubDir does not navigate to sub directory

This looks good. Thank you, Vikrant! Shura > On Jul 13, 2017, at 2:50 AM, Vikrant Agarwal > wrote: > > Hi All, > Please review the following: > > Bug : JDK-8184272 > > JDK 10 Webrev:

Re: RFR JDK-8172804: SwingSet Automation: Jemmy Library : FrameOperator: maximize() and demaximize() are not properly implemented

Looks good. > On Jan 16, 2017, at 5:39 AM, Muneer Kolarkunnu > wrote: > > Hi All, > > Please review the following: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8172804 > > > Webrev Link:

Re: Review request for JDK-8172489

Looks good. Thank. Shura > On Jan 12, 2017, at 12:43 AM, Vikrant Agarwal > wrote: > > Hi All, > > Please review the following: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8172489 > > > Webrev Link:

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

Here it goes. http://cr.openjdk.java.net/~shurailine/8157339/webrev.02 Could any of you guys push it for me? Shura > On May 24, 2016, at 9:38 AM, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > > >> On May 24, 2016, at 9:15 AM, Sergey Bylokhov <

Re: RFR 8157339: Further stabilization for the SwingSet client sanity tests.

a reviewer? I can >> review changes to these tests and demos. >> >> Thank you! >> >> Best regards, >> Alexander Kouznetsov >> (408) 276-0387 >> >> On 5/23/2016 11:52 AM, Alexandre (Shura) Iline wrote: >>> >>> Sergey, Phil, could any of you take a look or recommend somebody else >>> for that? >> > > > -- > Best regards, Sergey.

RFR 8157339: Further stabilization for the SwingSet client sanity tests.

Hi. Please take a look on the changes in: http://cr.openjdk.java.net/~shurailine/8157339/webrev.00/ I have gone through the code to discover potential instabilities. I was not changing the test logic much and mostly changed the code where I had to change it for stabilization reason. In some