Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

2016-01-13 Thread Rajeev Chamyal
Hello All, Please review the following fix for Jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8139213 Webrev : http://cr.openjdk.java.net/~rchamyal/8139213/webrev.00/ Issue : In Mac OS X Aqua LAF JOptionPane truncates the first button if multiple buttons are added to it. Cause:

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-13 Thread Alexander Scherbatiy
On 1/13/2016 9:28 AM, Avik Niyogi wrote: Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/ It looks like a string on a vertical progress bar with the right

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-13 Thread Alexander Scherbatiy
On 1/13/2016 1:12 AM, Pete Brunet wrote: Hi Alexandr, On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: It seems that there still is the case when tab titles are empty string, tab components are null, components are not null and the correct index should be returned for the given page. In the

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2016-01-13 Thread Sergey Bylokhov
On 13/01/16 09:27, Avik Niyogi wrote: Hi Sergey, If fFileList refers to a soft linked empty folder, we will will not need to apply orientation to it’s sub-components. I didn't understand what "soft linked empty folder" means here =(( Just to clarify. In the fix you have this code: 95

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

2016-01-13 Thread Pete Brunet
How does this look? http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/ Pete On 1/13/16 7:16 AM, Alexander Scherbatiy wrote: > On 1/13/2016 1:12 AM, Pete Brunet wrote: >> Hi Alexandr, >> >> On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: >>> It seems that there still is the case when tab

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

2016-01-13 Thread Sergey Bylokhov
Hi, Avik. In the fix you update getIconWidth() and getIconHeight, so now we take the Icon into account. but it seems if the Icon is bigger that the maximum size it will not be resided to 16x16, right? On 14/01/16 07:49, Avik Niyogi wrote: Hi All, Kindly review the bug fix for JDK 9. *Bug:*

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

2016-01-13 Thread Avik Niyogi
Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/ With Regards, Avik Niyogi > On 13-Jan-2016, at 7:02 pm, Alexander Scherbatiy >

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2016-01-13 Thread Sergey Bylokhov
Looks fine. On 14/01/16 07:37, Avik Niyogi wrote: Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ With Regards, Avik Niyogi On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

2016-01-13 Thread Avik Niyogi
Hi Sergey, I have verified it with the test case as well. If a test case overrides these methods to imply a change with icons larger than 16x16 it will show that for ImageIcon and Icon as before. The resize of ImageIcon is only in case it has an image file that it will try to fit. I had a

Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

2016-01-13 Thread Avik Niyogi
Hi All, Kindly review the bug fix for JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8146321 Webrev: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.00/ Issue: Under the Mac

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

2016-01-13 Thread Avik Niyogi
Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ With Regards, Avik Niyogi > On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

2016-01-13 Thread Alexander Scherbatiy
On 1/12/2016 5:28 PM, Rajeev Chamyal wrote: Hello All, Gentle reminder to review the fix. http://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/ My impression was that the scroll timer is started before an adjustment listener is executed. In this case the timer can track the open modal

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

2016-01-13 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8132119/webrev.05/ - the methods description are updated to mention a component numeric shaper and non-print graphics context - @since tag value is updated to 9 Thanks, Alexandr. On 1/12/2016 10:42