RFR: 8255916: [macos] javax/swing/JInternalFrame/6647340/bug6647340.java timed out

2020-11-09 Thread Prasanta Sadhukhan
This test has failed in one of jdk nightly testing although it always passed locally. Made the test use robot delays, waitForIdle() to make it more stable and appropriate to run in slower mach5 systems and also remove the dependancy on ExtendedRobot. Mach5 job has been run for several iterations

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Alexander Zuev
On Tue, 3 Nov 2020 16:44:36 GMT, Prasanta Sadhukhan wrote: > I think even if the fix is in windows, there's no harm in making the test > platform agnostic and let it run for all platforms. Done. - PR: https://git.openjdk.java.net/jdk/pull/1035

Withdrawn: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper

2020-11-09 Thread Alexander Zuev
On Tue, 3 Nov 2020 10:32:01 GMT, Alexander Zuev wrote: > 4907798: MEMORY LEAK: > javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1035

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Alexander Zuev
> 4907798: MEMORY LEAK: > javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Test case made multiplatform and testing all the LaF's - Changes: - all: https://g

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Alexander Zuev
On Tue, 3 Nov 2020 18:41:20 GMT, Sergey Bylokhov wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test case made multiplatform and testing all the LaF's > > test/jdk/javax/swing/JMenu/PopupReferenceMemoryLeak.java

Re: RFR: 8255916: [macos] javax/swing/JInternalFrame/6647340/bug6647340.java timed out

2020-11-09 Thread Sergey Bylokhov
On Mon, 9 Nov 2020 08:34:24 GMT, Prasanta Sadhukhan wrote: > This test has failed in one of jdk nightly testing although it always passed > locally. Made the test use robot delays, waitForIdle() to make it more stable > and appropriate to run in slower mach5 systems and also remove the dependa

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Sergey Bylokhov
On Mon, 9 Nov 2020 11:57:40 GMT, Alexander Zuev wrote: >> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java >> line 1229: >> >>> 1227: // and uninstall menu keybindings >>> 1228:removeItems(); >>> 1229:menuInputMa

Re: RFR: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Alexandre Iline
On Tue, 13 Oct 2020 08:05:34 GMT, Amresh Sahu wrote: > Four files has been modified: > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/dialog/DialogDemo.java > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/frame/Fr

Re: RFR: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Amresh Sahu
On Tue, 13 Oct 2020 17:03:16 GMT, Alexandre Iline wrote: >> Four files has been modified: >> modified: >> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/dialog/DialogDemo.java >> modified: >> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos

Re: RFR: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Dalibor Topic
On Tue, 20 Oct 2020 03:43:49 GMT, Amresh Sahu wrote: >> Marked as reviewed by shurailine (Committer). > > @mrserb @akolarkunnu > > Please review my code changes. Hi, can you let me know under whose OCA your contributions would be covered via e-mail to dalibor.to...@oracle.com, please? Then I

RFR: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Amresh Sahu
Four files has been modified: modified: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/dialog/DialogDemo.java modified: test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/frame/FrameDemo.java modified: test/jdk/sanity/client/lib/Swing

Re: RFR: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Sergey Bylokhov
On Tue, 13 Oct 2020 08:05:34 GMT, Amresh Sahu wrote: > Four files has been modified: > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/dialog/DialogDemo.java > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/frame/Fr

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Alexander Zuev
On Mon, 9 Nov 2020 18:08:57 GMT, Sergey Bylokhov wrote: >> We do call ninstall() at the beginning of the method but it does not resolve >> the issue. > > I meant this code at the start of the method: > `if (!(UIManager.getLookAndFeel() instanceof BasicLookAndFeel)) { >

Re: RFR: 4907798: MEMORY LEAK: javax.swing.plaf.basic.BasicPopupMenuUI$MenuKeyboardHelper [v2]

2020-11-09 Thread Sergey Bylokhov
On Mon, 9 Nov 2020 23:25:13 GMT, Alexander Zuev wrote: >> I meant this code at the start of the method: >> `if (!(UIManager.getLookAndFeel() instanceof BasicLookAndFeel)) { >> uninstall(); >> return; >> }` >> If "uninstall" will not solve th

Re: RFR: 7190978: javax/swing/JComponent/7154030/bug7154030.java fails on mac [v3]

2020-11-09 Thread Prasanta Sadhukhan
On Sat, 7 Nov 2020 23:08:18 GMT, Sergey Bylokhov wrote: >> but 300x300 is set in frame setSize..if I use frame getBounds instead of >> already set 300x300, that will not be right, according to me...What if >> getBounds() has some bug (in some platform) and return some other >> width/height (sa

Re: RFR: 8255916: [macos] javax/swing/JInternalFrame/6647340/bug6647340.java timed out [v2]

2020-11-09 Thread Prasanta Sadhukhan
> This test has failed in one of jdk nightly testing although it always passed > locally. Made the test use robot delays, waitForIdle() to make it more stable > and appropriate to run in slower mach5 systems and also remove the dependancy > on ExtendedRobot. > Mach5 job has been run for several

Integrated: 8253905: Update sanity test suite to not place windows at (0, 0)

2020-11-09 Thread Amresh Sahu
On Tue, 13 Oct 2020 08:05:34 GMT, Amresh Sahu wrote: > Four files has been modified: > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/dialog/DialogDemo.java > modified: > test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/frame/Fr