On Sat, 7 Nov 2020 23:08:18 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> but 300x300 is set in frame setSize..if I use frame getBounds instead of >> already set 300x300, that will not be right, according to me...What if >> getBounds() has some bug (in some platform) and return some other >> width/height (say 1 pixel less, we might have similar bug in 8196465) that >> what is set in setSize, then the test might pass even though robot is >> capturing wrong bounds. > >> but 300x300 is set in frame setSize..if I use frame getBounds instead of >> already set 300x300, that will not be right, according to me... > > The test should set the size 300,300 to the frame and then request and use > the real bounds of the frame. > >> What if getBounds() has some bug (in some platform) and return some other >> width/height (say 1 pixel less, we might have similar bug in 8196465) that >> what is set in setSize, then the test might pass even though robot is >> capturing wrong bounds. > > The getBounds() simply returns the size which was set by the native system, > so is it a bug in getBounds() or the real bounds of the frame "say 1 pixel > less"? Any further feedback? ------------- PR: https://git.openjdk.java.net/jdk/pull/955
