Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

2017-01-12 Thread Avik Niyogi
A gentle reminder, please review the code changes made. With Regards, Avik Niyogi > On 12-Jan-2017, at 10:02 am, Avik Niyogi wrote: > > In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only > arrow keys would work within ungrouped radio buttons

Re: Review Request for JDK-8172500

2017-01-12 Thread Vikrant Agarwal
Hi Sergey,   As of now we are testing Metal Look And Feel, but we have planned to first finish automation tests for all the individual Swingset demos and then add support for testing all the different look and feels.   Best Regards, Vikrant     From: Sergey Bylokhov Sent: Thursday,

Re: Review request for JDK-8172489

2017-01-12 Thread Philip Race
There's a change in the logic now so that if adj.getScrollDirection() is not INCREASE or DECREASE nothing gets changed. I presume that is deliberate. Assuming so, "+1". -phil. On 1/12/17, 10:32 AM, Alexander Kouznetsov wrote: Looks good to me. Phil, could you please review? Best

Re: Review request for JDK-8172489

2017-01-12 Thread Alexandre (Shura) Iline
Looks good. Thank. Shura > On Jan 12, 2017, at 12:43 AM, Vikrant Agarwal > wrote: > > Hi All, > > Please review the following: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8172489 > > > Webrev Link:

Re: Review Request for JDK-8172500

2017-01-12 Thread Alexander Kouznetsov
Looks good to me. Best regards, Alexander Kouznetsov (408) 276-0387 On 1/12/2017 12:26 AM, Vikrant Agarwal wrote: Hi All, Please review the following: Bug : https://bugs.openjdk.java.net/browse/JDK-8172500 Webrev Link: http://cr.openjdk.java.net/~vagarwal/8172500/webrev_01/

Re: Review request for JDK-8172489

2017-01-12 Thread Alexander Kouznetsov
Looks good to me. Phil, could you please review? Best regards, Alexander Kouznetsov (408) 276-0387 On 1/12/2017 12:43 AM, Vikrant Agarwal wrote: Hi All, Please review the following: *Bug :* https://bugs.openjdk.java.net/browse/JDK-8172489 *Webrev Link:*

Re: Review Request for JDK-8172500

2017-01-12 Thread Sergey Bylokhov
Hi, Vikrant. What look and feels are tested by this test? > > Hi All, > > Please review the following: > Bug : https://bugs.openjdk.java.net/browse/JDK-8172500 > > > Webrev Link: http://cr.openjdk.java.net/~vagarwal/8172500/webrev_01/ >

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2017-01-12 Thread alexander popov
Yep, its reasonable! Will fix that and update diff. On 1/11/2017 1:39 PM, Avik Niyogi wrote: Hi Alexander, The following is my input for this webrev: In case the LAF is Aqua, the check for combobox alignment is skipped. Instead, if default LAF is Aqua, the LAF should be changed to cross

Re: [9] RFR JDK-8172558: [PIT][TEST_BUG] Bad filename for javax/swing/JTable/8133919/DrawGridLinesTest.java

2017-01-12 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 1/12/2017 10:04 AM, Prasanta Sadhukhan wrote: Hi All, Please review the name change for this regression test which was causing jtreg to fail as it was not finding the test. Bug: https://bugs.openjdk.java.net/browse/JDK-8172558 Filename was

Review request for JDK-8172489

2017-01-12 Thread Vikrant Agarwal
Hi All, Please review the following: Bug : https://bugs.openjdk.java.net/browse/JDK-8172489 Webrev Link: http://cr.openjdk.java.net/~vagarwal/8172489/webrev_01/ Summary: This is a fix for a bug in Jemmy, that we found while automating the SwingSet Demo. JSlider was not able to

Review Request for JDK-8172500

2017-01-12 Thread Vikrant Agarwal
Hi All, Please review the following: Bug : https://bugs.openjdk.java.net/browse/JDK-8172500 Webrev Link: http://cr.openjdk.java.net/~vagarwal/8172500/webrev_01/ Summary: This is a new test for automated testing of SwingSet SliderDemo using Jemmy. Please see the bug for description