A gentle reminder, please review the code changes made. With Regards, Avik Niyogi
> On 12-Jan-2017, at 10:02 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only > arrow keys would work within ungrouped radio buttons but not within grouped > radio button groups. Also, verified Aqua LAF with native application on > MacBook. So to test this focus traversal, it works only in LAF which do not > use Aqua. I was informed last time a similar bug was fixed about this > behaviour regarding Nimbus LAF as well and was confirmed by me by testing it. > > With Regards, > Avik Niyogi >> On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy >> <alexandr.scherba...@oracle.com <mailto:alexandr.scherba...@oracle.com>> >> wrote: >> >> On 1/11/2017 2:01 PM, Avik Niyogi wrote: >>> Hi All, >>> I have addressed the inputs received in the following update. Please review >>> the same for JDK 9. >>> http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ >>> <http://cr.openjdk.java.net/%7Eaniyogi/8172509/webrev.01/> >>> >>> With Regards, >>> Avik Niyogi >>>> On 11-Jan-2017, at 4:22 pm, Prasanta Sadhukhan >>>> <prasanta.sadhuk...@oracle.com <mailto:prasanta.sadhuk...@oracle.com>> >>>> wrote: >>>> >>>> I guess we need to throw the exception if changing LaF fails instead of >>>> silently consuming it!! >>>> Regards >>>> Prasanta >>>> On 1/11/2017 2:16 PM, Avik Niyogi wrote: >>>>> Hi All, >>>>> >>>>> Kindly review the proposed fix for JDK9. >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8172509 >>>>> <https://bugs.openjdk.java.net/browse/JDK-8172509> >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~aniyogi/8172509/webrev.00/ >>>>> <http://cr.openjdk.java.net/%7Eaniyogi/8172509/webrev.00/> >>>>> >>>>> Issue: The focus traversal policy being tested was incorrect >>>>> >>>>> Cause: For Aqua and Nimbus, the focus traversal policy used is different >>>>> and as this is tested on default LAF, it fails on Mac OS X >> Could you give more details what are the differences between using the >> focus traversal policy in Metal, Nimbus and Aqua L&F? >> >> Thanks, >> Alexandr. >>>>> >>>>> Fix: Cross-platform (Metal) LAF is used in case the default LAF is either >>>>> Aqua or Nimbus and the focus traversal works in those cases. >>>>> >>>>> With Regards, >>>>> Avik Niyogi >>>> >>> >> >
