Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

2017-03-15 Thread Philip Race
I see the fix was just pushed. But my comments are clearly not addressed. -phil. On 3/15/17, 10:11 AM, Philip Race wrote: Does this actually try to address everything they complained about here http://stackoverflow.com/questions/41117190/java-9-on-windows-with-large-fonts which points to

Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

2017-03-15 Thread Philip Race
Does this actually try to address everything they complained about here http://stackoverflow.com/questions/41117190/java-9-on-windows-with-large-fonts which points to an image : https://i.stack.imgur.com/fgpBu.png Check boxes are some of it but not all of it. There is what appears to be a

Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

2017-03-15 Thread Sergey Bylokhov
> On 3/14/2017 7:31 PM, Sergey Bylokhov wrote: >> The initial image at [1] also show some issues in the submenu pointer and >> the menu corners, did we solve them already? > The submenu icon is updated in the current fix and the issue with a menu > corner is covered by the fix >JDK-8162350

Re: [9] Review request for 8174845 Bad scaling on Windows with large fonts with Java 9ea

2017-03-15 Thread Alexander Zvegintsev
Looks good to me; Thanks, Alexander. On 14/03/2017 13:54, Alexandr Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8174845 webrev: http://cr.openjdk.java.net/~alexsch/8174845/webrev.00 Metal JCheckBox and JMenuItem icons are updated to

Re: [9] Review Request: 8176448 [macos] Popups in JCombobox and Choice have incorrect location in multiscreen systems

2017-03-15 Thread Alexander Zvegintsev
+1 Thanks, Alexander. On 15/03/2017 15:33, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 3/14/2017 6:12 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In the fixes for JDK-7072653 [1] and JDK-8129838 [2] and JDK-8144161[3] [1]

Re: [9] Review Request: 8176448 [macos] Popups in JCombobox and Choice have incorrect location in multiscreen systems

2017-03-15 Thread Alexandr Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 3/14/2017 6:12 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk9. In the fixes for JDK-7072653 [1] and JDK-8129838 [2] and JDK-8144161[3] [1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/7606d0af7b80 Notes about JDK-7072653 -

Re: [9] JDK-8169897: [PIT] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails

2017-03-15 Thread Prasanta Sadhukhan
On 3/14/2017 6:48 PM, Alexandr Scherbatiy wrote: On 3/14/2017 3:37 PM, Philip Race wrote: I am not sure why the test went to the trouble of looking for Arial. If there was a good reason (Alexander ??) an alternative is to initialise The test tries to calculate number of intersection with