Re: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful

2018-08-09 Thread Jayathirth D V
Hi Prasanta, Looks good to me. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Friday, August 10, 2018 10:50 AM To: swing-dev@openjdk.java.net Subject: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful Hi All, Please

[12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful

2018-08-09 Thread Prasanta Sadhukhan
Hi All, Please review this test which needs to be marked headful to avoid mach5 test failing. --- a/test/jdk/javax/swing/border/TestTitledBorderLeak.java Thu Aug 09 11:01:59 2018 +0530 +++ b/test/jdk/javax/swing/border/TestTitledBorderLeak.java    Fri Aug 10 10:45:51 2018 +0530 @@ -31,6

[12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

2018-08-09 Thread Sergey Bylokhov
Hello. Please review the small cleanup for jdk12. Bug: https://bugs.openjdk.java.net/browse/JDK-8209340 Webrev: http://cr.openjdk.java.net/~serb/8209340/webrev.00 To avoid synthetic accessors in the class files, in some of our private nested classes the empty default constructor was added.

Re: [12] RFR [JDK-8209198] [macosx]Jemmy: JFileChooserOperator.selectFile(..) throws NullPointerException on Mac

2018-08-09 Thread Muneer Kolarkunnu
Ok. Then I will include all outstanding changes in a single task.   Regards, Muneer   From: Alexandre (Shura) Iline Sent: Thursday, August 09, 2018 11:42 PM To: Muneer Kolarkunnu Cc: swing-dev@openjdk.java.net Subject: Re: [12] RFR [JDK-8209198] [macosx]Jemmy:

Re: [12] RFR [JDK-8209198] [macosx]Jemmy: JFileChooserOperator.selectFile(..) throws NullPointerException on Mac

2018-08-09 Thread Alexandre (Shura) Iline
The original fix belongs to me , so I do not qualify as a reviewer. I, however, have a comment that perhaps we could import multiple changesets in code-tools/jemmy/v2 with one changeset in jdk/jdk. I have done it in the past, that’s for sure: https://bugs.openjdk.java.net/browse/JDK-8188779

[12] RFR [JDK-8209198] [macosx]Jemmy: JFileChooserOperator.selectFile(..) throws NullPointerException on Mac

2018-08-09 Thread Muneer Kolarkunnu
Hi All, Please review fix for a bug in jemmy: Bug: https://bugs.openjdk.java.net/browse/JDK-8209198 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8209198/webrev.00/ This fix is a copy of fix made in the Jemmy code-tools repository.

Re: [12] RFR JDK-8203281:[Windows] JComboBox change in ui when editor.setBorder() is called

2018-08-09 Thread Prasanta Sadhukhan
Gentle reminder. I guess it's for vista as the bug description states it's for Vista Info: === Vista Build No: 5840 Vista Theme: Default Theme(Aero) Regards Prasanta On 8/2/2018 12:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. I am not sure that previous fix[JDK-6490753] was implemented