Re: RFR : JDK-8239334:Tab Size does not work correctly in JTextArea with setLineWrap on

2020-02-19 Thread Prasanta Sadhukhan
Thanks Pankaj for the review. I will fix it during the push. Regards Prasanta On 20-Feb-20 11:47 AM, Pankaj Bansal wrote: Hello Prasanta, The fix looks good. I have couple of minor comments about the test. There is an indentation issue at line 59 You have imported classes like JScrollPane,

Re: RFR : JDK-8239334:Tab Size does not work correctly in JTextArea with setLineWrap on

2020-02-19 Thread Pankaj Bansal
Hello Prasanta, The fix looks good. I have couple of minor comments about the test. There is an indentation issue at line 59 You have imported classes like JScrollPane, JTextArea and while using them, you have used full path like javax.swing.JScrollPane, javax.swing.JTextArea etc. Regards,

Re: RFR : JDK-8239334:Tab Size does not work correctly in JTextArea with setLineWrap on

2020-02-19 Thread Sergey Bylokhov
Looks fine. On 2/18/20 2:32 am, Prasanta Sadhukhan wrote: Hi All, Bug: https://bugs.openjdk.java.net/browse/JDK-8239334 webrev: http://cr.openjdk.java.net/~psadhukhan/8239334/webrev.0/ Please review a fix for an issue where it is seen string with "tab" in them are not aligned properly with