Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

2020-03-05 Thread Pankaj Bansal
Hello Tejpal, I think you need to iterate over the full "tables" array instead of just using the tables[0] as is being done in entrySet function in same class. Also, you need to create a copy of the key set like entrySet function instead of returning the original handle. Also, please follow

Re: Remove System.out.println from ImageIcon.loadImage

2020-03-05 Thread Langer, Christoph
Hi Vlad, I just had a look at your change. The effective change to ImageIcon.java looks correct at a glance. But it would be good if some Reviewer from the swing area, e.g. Sergey, can have a look. Then, I think, the import reordering is not quite correct. Packages in the java namespace should

MultiResolutionImage unusable with Buttons

2020-03-05 Thread Alan White
Hi Folks I'd like to help move https://bugs.openjdk.java.net/browse/JDK-8212226 this along, or ask if anyone has a workaround to the issue. To recap MultiResolutionImages work perfectly with JButton, until you disable it, then you get the exception as per the bug above. There is no way (unless y

RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

2020-03-05 Thread Tejpal Rebari
Hi All, Please review the following fix for jdk15. Bug : https://bugs.openjdk.java.net/browse/JDK-8146330 Webrev : http://cr.openjdk.java.net/~trebari/swing/8146330/webrev0/

Re: RFR: 8219578 No associated icon for the leaf node of Jtree

2020-03-05 Thread Jayathirth D V
Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; swing-dev@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf no