Re: RFR: 8233584: [Win LAF] When navigating the contents of the file list changes in Win LAF

2020-04-20 Thread Alexey Ivanov
Hi Bhawesh, Looks good to me. Sorry for my delayed response. I noted that making the test automatic is out of scope at this time, however, it seems to be possible. You don't need to read the list of files. The file list reacts to the even sent by combo box. After the fix, navigating items

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 20-Apr-20 10:20 PM, Prasanta Sadhukhan wrote: On 20-Apr-20 10:16 PM, Sergey Bylokhov wrote: On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 20-Apr-20 10:16 PM, Sergey Bylokhov wrote: On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/ used the right GC for the tip but we still need

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Sergey Bylokhov
On 4/20/20 8:34 am, Prasanta Sadhukhan wrote: On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/ used the right GC for the tip but we still need the preferredSize in the paint() Why do we need

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 20-Apr-20 8:54 PM, Sergey Bylokhov wrote: On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/ used the right GC for the tip but we still need the preferredSize in the paint() Why do we need it? Do we calculate the size in the

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Sergey Bylokhov
On 4/20/20 2:40 am, Prasanta Sadhukhan wrote: http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.4/ used the right GC for the tip but we still need the preferredSize in the paint() Why do we need it? Do we calculate the size in the ToolTipManager.showTipWindow() incorrectly? We call

Re: [13] RFR JDK-8213535:Windows HiDPI html lightweight tooltips are truncated

2020-04-20 Thread Prasanta Sadhukhan
On 19-Apr-20 8:52 PM, Sergey Bylokhov wrote: On 4/17/20 4:16 am, Prasanta Sadhukhan wrote: Also, the popupType will remain LW as we are only using it to create the tip but doing setPopupType() to LW after tooltip popup creation. http://cr.openjdk.java.net/~psadhukhan/8213535/webrev.3/