Re: RFR: 8189198: Add "forRemoval = true" to Applet API deprecations [v2]

2021-03-25 Thread Phil Race
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote: >> implementation of >> JDK-8256145: JEP 398: Deprecate the Applet API for Removal > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes >

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-26 Thread Phil Race
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in > `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy > > Similar

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-26 Thread Phil Race
On Fri, 26 Feb 2021 20:21:21 GMT, Sergey Bylokhov wrote: >> src/java.desktop/unix/classes/sun/print/UnixPrintJob.java line 601: >> >>> 599: try (BufferedInputStream bin = new >>> BufferedInputStream(instream); >>> 600: BufferedOutputStream bout = new >>>

Re: RFR: 8262161 Refactor manual I/O stream copying to new convinient methods in java.desktop

2021-02-25 Thread Phil Race
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov wrote: > Cleanup code to use new handy methods in > `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy: > 1. java.io.InputStream#readAllBytes > 2. java.io.InputStream#transferTo > 3. java.nio.file.Files#copy > > Similar

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge

2021-03-07 Thread Phil Race
On Sun, 7 Mar 2021 03:18:53 GMT, Yasumasa Suenaga wrote: > I saw C4530 with VS 2019 (16.9.0) as following (on Japanese locale): > > AccessBridgeDebug.cpp > メモ: インクルード ファイル: > d:\github-forked\jdk\src\jdk.accessibility\windows\native\common\AccessBridgeDebug.h > > : > >

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

2021-04-20 Thread Phil Race
On Fri, 16 Apr 2021 06:53:21 GMT, Prasanta Sadhukhan wrote: > This test was marked as unstable in CI run in samevm mode but later on was > found passing in now-default othervm mode but was problemlisted only on macos > by JDK-8254976. > It is found that this test started failing in macos due

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

2021-04-20 Thread Phil Race
On Wed, 21 Apr 2021 05:09:48 GMT, Prasanta Sadhukhan wrote: >> So on macOS 11 we enter this block since isMacOSX14 is false and the test >> passes ? > > No, it still fails in macosx11 without this modification. macos11, System > .getProperty returns 10.16 so it satisfies this macosx >=10.14

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

2021-04-20 Thread Phil Race
On Wed, 21 Apr 2021 03:55:50 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/UIDefaults/6302464/bug6302464.java line 138: >> >>> 136: } >>> 137: if (!isMacOSX14) { >>> 138: HashSet colorsAAOff = >>> getAntialiasedColors(VALUE_TEXT_ANTIALIAS_OFF, 100); >> >>

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Phil Race
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan wrote: >> This test was marked as unstable in CI run in samevm mode but later on was >> found passing in now-default othervm mode but was problemlisted only on >> macos by JDK-8254976. >> It is found that this test started failing in macos

Re: RFR: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable [v2]

2021-04-21 Thread Phil Race
On Wed, 21 Apr 2021 11:23:02 GMT, Prasanta Sadhukhan wrote: >> This test was marked as unstable in CI run in samevm mode but later on was >> found passing in now-default othervm mode but was problemlisted only on >> macos by JDK-8254976. >> It is found that this test started failing in macos

Integrated: 8261198: [macOS] Incorrect JNI parameters in number conversion in A11Y code

2021-02-05 Thread Phil Race
On Fri, 5 Feb 2021 01:27:26 GMT, Phil Race wrote: > we need to specify ()I for the signature of the method that returns int. > Additionally number (the instance!) needs to be passed to the method up call. This pull request has now been integrated. Changeset: 4a89733e Author: Phil Rac

Re: RFR: 5015261: JInternalFrame causes NPE [v5]

2021-08-21 Thread Phil Race
On Thu, 19 Aug 2021 16:48:46 GMT, Prasanta Sadhukhan wrote: >> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be >> called with null value. There are many places in JInternalFrame where >> getDesktopIcon() is accessed without null check which might cause NPE. >> Added

Integrated: 8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos

2021-08-15 Thread Phil Race
On Sun, 15 Aug 2021 16:23:52 GMT, Phil Race wrote: > This will fail regularly so problem list it. This pull request has now been integrated. Changeset: 6a5241c3 Author: Phil Race URL: https://git.openjdk.java.net/jdk/commit/6a5241c3adfd3ba886e469156dea56ed5b9673ff Stats: 1 l

RFR: 8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos

2021-08-15 Thread Phil Race
This will fail regularly so problem list it. - Commit messages: - 8272491: Problem list javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java on macos Changes: https://git.openjdk.java.net/jdk/pull/5119/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5119=00 Issue:

Re: RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel

2021-08-23 Thread Phil Race
On Mon, 16 Aug 2021 08:22:35 GMT, Pankaj Bansal wrote: > A container may include few default components as children, which are added > to it during creation. Due to this, calling function getChildrenCount on a > new created instance may return non zero value. This behaviour may vary >

Re: RFR: 5015261: NPE may be thrown if JDesktopIcon is set to null on a JInternalFrame [v6]

2021-08-23 Thread Phil Race
On Mon, 23 Aug 2021 03:58:49 GMT, Prasanta Sadhukhan wrote: >> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be >> called with null value. There are many places in JInternalFrame where >> getDesktopIcon() is accessed without null check which might cause NPE. >> Added

Re: RFR: 5015261: JInternalFrame causes NPE [v3]

2021-08-14 Thread Phil Race
On Fri, 13 Aug 2021 04:34:52 GMT, Prasanta Sadhukhan wrote: >> JInternalFrame.getDesktopIcon() can be null as setDesktopIcon() can be >> called with null value. There are many places in JInternalFrame where >> getDesktopIcon() is accessed without null check which might cause NPE. >> Added

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-14 Thread Phil Race
On Wed, 11 Aug 2021 09:03:57 GMT, Prasanta Sadhukhan wrote: > The test fails in CI testing citing expected "rededited" but found > "redEDITED", which seems to point to fact that either there is a CAPS_LOCK > key switched on or some other test did not use SHIFT key corectly ie, > pressed but

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."

2021-08-14 Thread Phil Race
On Sat, 14 Aug 2021 22:12:57 GMT, Sergey Bylokhov wrote: > > I don't believe any of the scenarios. > > As you well know these headful tests will be re-run 2 more times if they > > fail. > > But we know the log information only for the last failure, probably the > button was pressed only for

Re: RFR: 5015261: JInternalFrame causes NPE [v3]

2021-08-14 Thread Phil Race
On Sat, 14 Aug 2021 22:15:53 GMT, Sergey Bylokhov wrote: > > Folks who are doing it are likely seeing random exceptions anyway at a > > later time ! > > What we will do if the field will be set to null directly? Throw NPE at any > point later when we will found null? The field is protected.

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

2021-08-16 Thread Phil Race
On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan wrote: >> The test fails in CI testing citing expected "rededited" but found >> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK >> key switched on or some other test did not use SHIFT key corectly ie, >> pressed

Re: RFR: 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." [v2]

2021-08-16 Thread Phil Race
On Mon, 16 Aug 2021 13:45:49 GMT, Prasanta Sadhukhan wrote: >> The test fails in CI testing citing expected "rededited" but found >> "redEDITED", which seems to point to fact that either there is a CAPS_LOCK >> key switched on or some other test did not use SHIFT key corectly ie, >> pressed

Re: RFR: 5015261: JInternalFrame causes NPE [v3]

2021-08-16 Thread Phil Race
On Mon, 16 Aug 2021 04:36:03 GMT, Prasanta Sadhukhan wrote: > > We should either prevent null being set or catch all those nulls. > > I did that in 1st iteration of this > PR..https://github.com/openjdk/jdk/pull/4989/files/2a2ab50ded3305f3a9e0f01e90417b484a0b2db4 > > @prrace Should I bring

Re: RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel [v2]

2021-09-04 Thread Phil Race
On Wed, 25 Aug 2021 10:39:42 GMT, Pankaj Bansal wrote: >> A container may include few default components as children, which are added >> to it during creation. Due to this, calling function getChildrenCount on a >> new created instance may return non zero value. This behaviour may vary >>

RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64

2021-08-08 Thread Phil Race
As per the bug comments, these tests fail too often on macOS arm. This will be too noisy for CI. So I would like to problem list them for mac-arm - Commit messages: - 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 Changes:

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64 [v2]

2021-08-09 Thread Phil Race
On Mon, 9 Aug 2021 04:39:02 GMT, Prasanta Sadhukhan wrote: > Maybe we should use JDK-8266243 instead. Other one has other tests as well. I can do that. Somehow my search missed that as an option. > Looks like this bug is a closed one, can it be open? I think it can be open but it won't be

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64 [v2]

2021-08-09 Thread Phil Race
> As per the bug comments, these tests fail too often on macOS arm. > This will be too noisy for CI. So I would like to problem list them for > mac-arm Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8272123: Problem lis

Integrated: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

2021-08-09 Thread Phil Race
On Mon, 9 Aug 2021 03:17:20 GMT, Phil Race wrote: > As per the bug comments, these tests fail too often on macOS arm. > This will be too noisy for CI. So I would like to problem list them for > mac-arm This pull request has now been integrated. Changeset: 0ac2be9b Author:Phil

Integrated: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9

2021-08-09 Thread Phil Race
On Tue, 20 Jul 2021 19:34:30 GMT, Phil Race wrote: > These fields > - have not been used by the implementation since JDK8, > - are not supposed to be used by applications, > - have been deprecated for removal since JDK 9 > - are non-standard, JDK not Java, classes >

Re: RFR: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9 [v2]

2021-08-04 Thread Phil Race
On Wed, 21 Jul 2021 07:19:02 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8268824: Remove unused jdk.accessibility APIs deprecated for removal in >> JDK 9 &

Re: RFR: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in JDK 9 [v2]

2021-08-04 Thread Phil Race
asses : just those > implementing ATs > > > The CSR for this is https://bugs.openjdk.java.net/browse/JDK-8270918 Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8268824: Remove unused jdk.accessibility APIs deprecated for removal in

Re: RFR: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K

2021-07-16 Thread Phil Race
On Fri, 16 Jul 2021 21:39:56 GMT, Vest wrote: >> This is the last part of Post JEP 411 refactoring that makes >> `@SuppressWarnings("removal")` more fine grained. This fix deals with all >> client libs annotations that cover more than 10K bytes of code. > >

Re: RFR: 8270859: Post JEP 411 refactoring: client libs with maximum covering > 10K

2021-07-16 Thread Phil Race
On Fri, 16 Jul 2021 20:52:08 GMT, Weijun Wang wrote: > This is the last part of Post JEP 411 refactoring that makes > `@SuppressWarnings("removal")` more fine grained. This fix deals with all > client libs annotations that cover more than 10K bytes of code.

<    1   2   3   4   5