Re: swing-dev Digest, Vol 122, Issue 16

Fix looks good to me. > On 14-Jun-2017, at 5:30 pm, swing-dev-requ...@openjdk.java.net wrote: > > Date: Wed, 14 Jun 2017 12:34:04 +0530 > From: Alexander Zvegintsev > > To: Prasanta Sadhukhan

Re: [10] RFR: JDK-8181782:[TESTBUG] [Macosx] JTextAreaEmojiTest is not executed

Fix looks good to me. > On 13-Jun-2017, at 5:30 pm, swing-dev-requ...@openjdk.java.net wrote: > > Date: Mon, 12 Jun 2017 07:21:13 -0700 (PDT) > From: Sreeprakash Sreedharan > > To: Prasanta Sadhukhan

Re: swing-dev Digest, Vol 121, Issue 19

+1 With Regards, Avik Niyogi > On 30-May-2017, at 10:30 pm, swing-dev-requ...@openjdk.java.net wrote: > > Date: Mon, 29 May 2017 11:49:45 +0530 > From: Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com > <mailto:prasanta.sadhuk...@oracle.com>> > To: Sergey Bylokh

Re: [10] RFR JDK-6461834: Minimize WindowsLookAndFeel classes included with Unix JDKs

+1 > On 24-May-2017, at 3:30 pm, swing-dev-requ...@openjdk.java.net wrote: > > Date: Tue, 23 May 2017 14:29:16 +0530 > From: Prasanta Sadhukhan > > To: Phil Race >, >

Re: [10] RFR JDK-7042497: javax.swing.JOptionPane.showInternalConfirmDialog throws RuntimeException

Hi, The fix looks good to me. With Regards, Avik Niyogi > > Subject: Re: [10] RFR JDK-7042497: > javax.swing.JOptionPane.showInternalConfirmDialog throws RuntimeException > Date: Mon, 15 May 2017 15:44:17 +0530 > From: Prasanta Sadhukhan <prasanta.sa

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

or bug ID: 8167160 Please find the copied content of the mail chain for that bug ID below: +1 On 11/23/2016 7:52 PM, Sergey Bylokhov wrote: > On 22.11.16 8:49, Avik Niyogi wrote: >> Hi All, >> Please review the code changes made as suggested by reviewers for JDK9 >> as availab

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

A gentle reminder, please review the code changes made. With Regards, Avik Niyogi > On 12-Jan-2017, at 10:02 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > In Nimbus and Aqua LAF, for focus traversal, keybindings do not existing only > arrow keys would work within ungro

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

do not use Aqua. I was informed last time a similar bug was fixed about this behaviour regarding Nimbus LAF as well and was confirmed by me by testing it. With Regards, Avik Niyogi > On 11-Jan-2017, at 7:38 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > >

Re: 8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

Hi All, I have addressed the inputs received in the following update. Please review the same for JDK 9. http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8172509/webrev.01/> With Regards, Avik Niyogi > On 11-Jan-2017, at 4:22 pm, Prasanta

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

in method createContentPane(). wildcard * is used in import statements which according to guidelines should be replace to use only the classes required. With Regards, Avik Niyogi

8172509: [TEST_BUG] [macosx] Failure of the new test java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java

versal works in those cases. With Regards, Avik Niyogi

Re: [9] RFR: JDK-8170349: The printed content is beyond the borders.

Fix looks good to me. > > > > On 12/9/2016 8:18 PM, Alexandr Scherbatiy wrote: >> On 12/6/2016 5:52 PM, Prasanta Sadhukhan wrote: >>> On 12/6/2016 8:17 PM, Alexandr Scherbatiy wrote: On 12/1/2016 9:16 AM, Prasanta Sadhukhan wrote: > On 11/30/2016 2:53 PM, Prasanta Sadhukhan wrote:

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

, used printStackTrace() With Regards, Avik Niyogi > On 22-Nov-2016, at 4:01 am, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > Hi, Avik. > Is it necessary to use logging in the test? > I guess that this code > Logger.getLogger(bug8033699.class.getName()).l

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

A gentle reminder, please review the code changes done as per the inputs received from reviewers. Thanks in advance. With Regards, Avik Niyogi > On 17-Nov-2016, at 4:15 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi All, > Please review the code changes made as sugg

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

Hi All, Please review the code changes made as suggested by reviewers for JDK9 as available for perusal in the link below http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/> With Regards, Avik Niyogi > On 14-Nov-2016, at 9:03

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works but for default settings on mac it is not working. > On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 14.11.16 17:18, Avik Niyogi wrote: >> I checked wit

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

I checked with MetalLAF as well. does not seem to work. also, tried with a native Mac app. Does not have any option for radio button focus traversal. > On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 14.11.16 6:43, Avik Niyogi wrot

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

This is OS X Specific. > On 14-Nov-2016, at 2:18 am, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > On 10.11.16 9:53, Avik Niyogi wrote: >> Arrow buttons for traversing a radio button group is not the expected OS X >> behaviour. > > This behav

8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

Hi All, Kindly review the proposed webrev for JDK9. Bug: https://bugs.openjdk.java.net/browse/JDK-8167160 Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/ Issue: The

Re: 8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

It did not fail on my system but it probably failed for slow systems in testing environment. Similar cases raised by Yuri had happened for several other cases which was confirmed to be fixed by the delay by him. With Regards, Avik Niyogi > On 27-Oct-2016, at 1:55 pm, Prasanta Sadhuk

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.04/> Thank you in advance. With Regards, Avik Niyogi > On 27-Oct-2016, at 2:3

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviver reviews. cr.openjdk.java.net/~aniyogi/8138771/webrev.03/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.03/> Thank you in advance. With Regards, Avik Niyogi

8168540: [TEST_BUG] On Unity, need a delay before screenshot taking to avoid animation

e: Animation before screen capture causes mismatch. Cause: Delay before screen capture albeit provided is not enough Fix: Delay provided to test case With Regards, Avik Niyogi

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

A gentle reminder, please review code changes as indicated in new webrev. With Regards, Avik Niyogi > On 07-Sep-2016, at 9:50 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 9/

8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

s test javax/swing/JColorChooser/Test7194184.java throws exception due to event delay. Cause: Delay for event idling was not added. Fix: Appropriate changes for autoWaitForIdle() were added. With Regards, Avik Niyogi

Re: 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

Hi All, Please review the proposed specification for JDK9 including inputs from reviewer reviews. http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/> Thank you in advance. With Regards, Avik Niyogi > On 29-Aug-2016, a

Re: 8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

Hi All, A gentle reminder, please review my code change. With Regards, Avik Niyogi > On 23-Aug-2016, at 2:28 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 23/08/16 10

8163161: [PIT][TEST_BUG] increase timeout in javax/swing/plaf/nimbus/8057791/bug8057791.java

s test javax/swing/plaf/nimbus/8057791/bug8057791.java times out Cause: No timeout delay was provided so it would fail on other systems. Fix: Appropriate changes for timeout were added. With Regards, Avik Niyogi

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

+ awt-dev > On 22-Aug-2016, at 12:28 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi All, > > Kindly review the proposed specifications for JDK9. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8138771 > <https://bugs.openjdk.java.net/brow

8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

es generated without the knowledge of the same. Fix: Appropriate comprehensive specifications required were added. With Regards, Avik Niyogi

8163169: [PIT][TEST_BUG] fix to JDK-8161470 doesn't work

work on PIT machines. With Regards, Avik Niyogi

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Hi Rajeev, Updated on same webrev due to single line change. > On 20-Jul-2016, at 11:41 am, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > Hello Avik, > > Line 67 can be removed from test. > > Regards, > Rajeev Chamyal > From: Avik Niyogi > S

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

Updated on the same webrev due to one line change. With Regards, Avik Niyogi > On 20-Jul-2016, at 11:41 am, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > Hello Avik, > > Line 67 can be removed from test. > > Regards, > Rajeev Chamyal > From: Avik N

Re: 8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

A gentle reminder, please review my code changes. With Regards, Avik Niyogi > On 19-Jul-2016, at 1:31 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/19/2016 9

8161470: [TEST_BUG] Failure javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java

e: This test consistently (12/12) fails on OS X 10.10 and also fails on Ubuntu 14.04. Cause: Due to quirk in robot.delay the UI was not getting appropriate behaviour response. Fix: Appropriate Robot methods were used to fix this. With Regards, Avik Niyogi

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi All, Another gentle reminder. Please review the changes made. > On 15-Jul-2016, at 2:50 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > A gentle reminder, please review the changes > >> On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy >> &

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

A gentle reminder, please review the changes > On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > > On 7/14/2016 9:53 AM, Avik Niyogi wrote: >> Hi All,

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi Prasanta, Kindly request you to review the webrev raised with inputs taken from reviewers in the mail trail. Thank you in advance. With Regards, Avik Niyogi > On 15-Jul-2016, at 11:37 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > I will ask Prasanta to review since it

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Another gentle reminder, please review my code changes. Thank you in advance. With Regards, Avik Niyogi > On 14-Jul-2016, at 8:46 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > &g

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi All, Please find my webrev below for review which includes changes as perceived from inputs provided. http://cr.openjdk.java.net/~aniyogi/8160438/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8160438/webrev.02/> With Regards, Avik Niyogi > On 12-Jul-2016, at 7:12 pm, Alexandr S

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

Hi All, A gentle reminder, please review my code changes. With Regards, Avik Niyogi > On 08-Jul-2016, at 4:24 pm, Yuri Nesterenko <yuri.nestere...@oracle.com> > wrote: > > It pass for me if I provide some time to process native events > after the user activity sim

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

inputs to modify the test case will be welcome. With Regards, Avik Niyogi > On 07-Jul-2016, at 9:51 pm, Semyon Sadetsky <semyon.sadet...@oracle.com> > wrote: > > > > On 7/7/2016 6:30 PM, Yuri Nesterenko wrote: >> On 07/07/2016 06:15 PM, Semyon Sadetsky wrote: >

Re: 8160438: [PIT][macosx] [TEST_BUG] javax/swing/plaf/nimbus/8057791/bug8057791.java fails

S X? > And also please be more specific on "negative scenarios" why they are > necessary ? > > Also could you replace labeled break with "return foundMatch; " > > --Semyon > > > On 07.07.2016 15:11, Avik Niyogi wrote: >> Hi All, >&

[9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

The bug fix looks good to me. With Regards, Avik Niyogi > On 03-Jun-2016, at 11:31 am, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > > > From: Alexandr Scherbatiy > Sent: 02 June 2016 12:00 > To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.ja

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

Hi Sergey, I ran the relevant test cases: ActionListenerCalledTwiceTest ScreenMenuBarInputTwice with different keyboard preferences and locales. Also tried different LAFs but found that only default (aqua) LAF is relevant for this case. With Regards, Avik Niyogi > On 31-May-2016, at 7:05

8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar Cause: The case for event that is not a Keydown has to be handled Fix: With fixing the if - else loop, the correct behaviour was confirmed. With Regards, Avik Niyogi

Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

owerHalfDrop Test case throws an exception when the behaviour is as expected. Cause: The robot does not have enough delay to run appropriately. Fix: The test case was fixed to have enough delay for the test case. With Regards, Avik Niyogi

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

A gentle reminder. Please review the bug fix: http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/> With Regards, Avik Niyogi > On 25-May-2016, at 2:30 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Changes u

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

Changes updated to same webrev.01 > http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01 > <http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01> With regards, Avik Niyogi > On 25-May-2016, at 2:21 pm, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > Looks ok

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

webrev.01/> With Regards, Avik Niyogi > On 24-May-2016, at 5:58 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > On 24/05/16 15:22, Avik Niyogi wrote: >> Hi All, >> >> Kindly review the fix for JDK9. >> Bug: https://bugs.openjdk.java.net

Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

dock height) for Mac. With Regards, Avik Niyogi

Re: [9] Review request for JDK-8153282 [TEST_BUG] some new JInternalFrame tests fail

>> Regards, >> Rajeev Chamyal >> >> -Original Message- >> From: Sergey Bylokhov >> Sent: 02 May 2016 19:05 >> To: Rajeev Chamyal; swing-dev@openjdk.java.net; Avik Niyogi >> Subject: Re: [9] Review request for JDK-8153282 [TEST_BUG] some &

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi All, I have added some comments and made some minor tweaks as per the inputs received. Please review my code changes as available at this link below: http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8152492/webrev.02/> With Regards, Avik

Re: Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

Hi Sergey, I have tried all these Input sources: I am unable to reproduce the test failure as mentioned by you with these inputs. Please provide some screenshots and/or details of the procedure used for this test failure. Thank you in advance. With Regards, Avik Niyogi > On 08-Apr-2016, a

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Sergey and Alexander, Please review the code changes done. With Regards, Avik Niyogi > On 28-Mar-2016, at 1:45 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > A gentle reminder, Please review the code changes as presented below. > > With Regards, > Avik Niyogi &g

Re: [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hi Rajeev, The fix looks fine to me. With Regards, Avik Niyogi -Original Message- From: Rajeev Chamyal Sent: 23 March 2016 14:45 To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net <mailto:swing-dev@openjdk.java.net> Subject: RE: [9] Review request for JDK-8

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

the UI by the arrow buttons AQUA provides instead of placing them in another row or column. This is also the expected behaviour for AquaLAF as per javadoc. With Regards, Avik Niyogi > On 24-Mar-2016, at 12:34 pm, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > Hello Avik, >

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

forth to the UI by the arrow buttons AQUA provides instead of placing them in another row or column. This is also the expected behaviour for AquaLAF as per javadoc. With Regards, Avik Niyogi > On 23-Mar-2016, at 4:14 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

> On 23-Mar-2016, at 3:31 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > On 21/03/16 09:19, Avik Niyogi wrote: >> Hi Alexander, >> I agree with what you said regarding the look and feel looking different. >> But this bug arrises due

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

ke the UI and different elements not required to be visible were being rendered because it is copying those elements from BasicUI. If a better solution is available without breaking some code apart from fix provided, please let me know. Thank you in advance. With Regards, Avik Niyogi > On 19-Mar-2016

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi All, Please find webrev with new code fix: http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8151282/webrev.02/> With Regards, Avik Niyogi > On 21-Mar-2016, at 8:07 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: &g

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi All, Please review the below code changes as per the inputs received. http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8148555/webrev.01/> With Regards, Avik Niyogi > On 21-Mar-2016, at 12:45 pm, Rajeev Chamyal <rajeev.cham...@oracl

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Manajit, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:20 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi Rajeev, > Please review the following code changes. > > With Regards, > Avik Niyogi >> On 21-M

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Rajeev, Please review the following code changes. With Regards, Avik Niyogi > On 21-Mar-2016, at 12:17 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi Sergey, > > Please review the following code changes. > With Regards, > Avik Niyogi >> On 1

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

Hi Sergey, Please review the following code changes. With Regards, Avik Niyogi > On 17-Mar-2016, at 7:03 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > The fix looks good to me. > > Just a small note: it is better to remove comment "

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi Sergey, Please review the following code change. With Regards, Avik Niyogi > On 19-Mar-2016, at 2:15 am, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 14/03/16 16:25, Avik Niyogi w

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, This bug fix has been committed and resolved. Does not require a review. With Regards, Avik Niyogi > On 21-Mar-2016, at 10:42 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi Sergey, > https://bugs.openjdk.java.net/browse/JDK-8151282 > <https://bugs.ope

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

duplicate code. With Regards, Avik Niyogi > On 19-Mar-2016, at 1:52 am, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > I would think about something like: > - > public class TabbedPaneLayout implements LayoutManager {

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, https://bugs.openjdk.java.net/browse/JDK-8151282 <https://bugs.openjdk.java.net/browse/JDK-8151282> is open and in progress. With Regards, Avik Niyogi > On 19-Mar-2016, at 4:52 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > I gues

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

to encompass actual expectations from Java on OS X as per native behaviour. Please review my current fix as available in the mail trail. Thank you in advance. With Regards, Avik Niyogi > On 14-Mar-2016, at 6:48 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > Hi, Avik

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Hi Alexander, The issue only applies for ScrollingTabbedPane and hence this fix. With Regards, Avik Niyogi > On 16-Mar-2016, at 4:51 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > Does the same issue affects the AquaTabbedPaneContrastUI? &g

Re: Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

It can be made into a class method, but herein this case it is needed for that instance only and hence the need for instance method and referred with “self”. With Regards, Avik Niyogi > On 16-Mar-2016, at 11:55 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: &

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

, but would be maintaining with requirements with code impact to superclasses. Please provide any insight to a probable compensate to mitigate this dichotomy of code expectation. Thank you in advance. With Regards, Avik Niyogi > On 18-Mar-2016, at 2:42 pm, Alexander Scherbatiy > <alexand

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi All, Please review code changes made as per inputs provided. http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8151282/webrev.01/> With Regards, Avik Niyogi > On 14-Mar-2016, at 10:53 am, Avik Niyogi <avik.niy...@oracle.com> wrote:

Re: Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

Hi Sergey, Seems like it is a delay issue. Will submit test case with a waitForIdle() fix. With Regards, Avik Niyogi > On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > Hi, Avik. > A few questions. > - Why webrev contains the new file?

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Policy(JTabbedPane.SCROLL_TAB_LAYOUT); is not honoured. In the new fix as provided, references to base class layout manager is removed in current solution. With Regards, Avik Niyogi > On 02-Mar-2016, at 7:50 pm, Alexander Potochkin > <alexander.potoch...@oracle.com> wrote: > >

Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

JNI. Albeit rendering is not yet supported, they will appear as blank “Missing font” notation. Also, added debug point in case of issue with glyph arrises. With Regards, Avik Niyogi

Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF

he test case failed for GTK LAF. Cause: The test case was meant to be Mac specific and was missing a jtreg parameter Fix: Minor change to test case with @requires tag added to set the fix. With Regards, Avik Niyogi

Re: Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Gentle reminder. Please review this fix. > On 26-Feb-2016, at 10:39 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > The issue is with setting of TabbedPaneScrollLayout() for the option > JTabbedPane.SCROLL_TAB_LAYOUT as is enabled in the test code > and not Tabbed

Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

or Aqua Look, multiple calls to pane.getMinimumSize().height causes incremental return of values. Cause: The impact was caused by a major broken code within AquaTabbedPaneUI.java for createLayoutManager() Fix: Major linking calls to super class fix done within createLayoutManager(). With R

Review Request of 8137169 :

or Aqua Look, multiple calls to pane.getMinimumSize().height causes incremental return of values. Cause: The impact was caused by a major broken code within AquaTabbedPaneUI.java for createLayoutManager() Fix: Major linking calls to super class fix done within createLayoutManager(). With R

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

A gentle reminder. Please review webrev with changes as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.06/ <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.06/> With Regards, Avik Niyogi > On 08-Feb-2016, at 12:42 pm, Avik Niyogi <avik.niy...@oracle.com>

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Sergey, Please review webrev with changes as per the inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.06/ <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.06/> With Regards, Avik Niyogi > On 08-Feb-2016, at 2:29 am, Sergey Bylokhov <sergey.bylok...@oracle.c

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04 <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.04> With Regards, Avik Niyogi > On 02-Feb-2016, at 5:55 pm, Alexandr Scherbatiy > <alexandr.scherb

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per the inputs provided: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/ <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.05/> With Regards, Avik Niyogi > On 03-Feb-2016, at 7:38 pm, Alexandr Scherbatiy > <alexandr.scherb

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Alexander, > On 02-Feb-2016, at 3:44 pm, Alexandr Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > On 2/2/2016 1:50 AM, Avik Niyogi wrote: >> Hi All, >> Please review the code changes made as per the inputs provided: >> cr.openjdk.java.net/

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, Please review the code changes made as per inputs provided: cr.openjdk.java.net/~aniyogi/8146321/webrev.02 <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.02> With Regards, Avik Niyogi > On 20-Jan-2016, at 10:35 pm, Sergey Bylokhov <sergey.bylok...@oracle.com> > wr

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please review my code change with inputs received: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.08/> With Regards, Avik Niyogi > On 21-Jan-2016, at 8:30 am, Avik Niyogi <avik.niy...@oracle.com> wrote:

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

) With Regards, Avik Niyogi > On 20-Jan-2016, at 4:30 pm, Alexander Scherbatiy > <alexandr.scherba...@oracle.com> wrote: > > > The fix looks good to me. > > Thanks, > Alexandr. > > On 1/20/2016 12:47 PM, Rajeev Chamyal wrote: >> >> Looks g

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi Sergey, The JTreg will pass, but the errors are posted to the log and not as an interrupt as it would prematurely terminate execution of entire test case for other look and feels if done so. With Regards, Avik Niyogi > On 21-Jan-2016, at 8:26 am, Avik Niyogi <avik.niy...@oracle.com&

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

tiy wrote: >> >> The fix looks good to me. >> >> Thanks, >> Alexandr. >> >> On 1/20/2016 12:47 PM, Rajeev Chamyal wrote: >>> >>> Looks good to me. >>> >>> Regards, >>> >>> Rajeev Chamyal >>&g

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, A gentle reminder. Please review my code changes as mentioned in the webrev below as available in the link in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 11:34 am, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi All, Please find the chan

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi All, A gentle reminder, please review my code changes as in the webrev below in the mail trail. With Regards, Avik Niyogi > On 18-Jan-2016, at 3:01 pm, Avik Niyogi <avik.niy...@oracle.com> wrote: > > Hi Sergey, > > Please review the webrev taking inputs as per the disc

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please review the code changes made as with inputs for the webrev: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.07/> With Regards, Avik Niyogi > On 20-Jan-2016, at 10:40 am, Rajeev Chamyal <rajeev.cham...@oracl

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

Hi Sergey, Please review the webrev taking inputs as per the discussion before: http://cr.openjdk.java.net/~aniyogi/8146321/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8146321/webrev.01/> With Regards, Avik Niyogi > On 14-Jan-2016, at 12:55 pm, Avik Niyogi <avik.niy...@oracl

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please find the changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.05/> With Regards, Avik Niyogi > On 14-Jan-2016, at 3:18 pm, Alexander Scherbatiy > <a

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/> With Regards, Avik Niyogi > On 13-Jan-2016, at 7:02 pm, Alexander Scherbatiy > <alexandr.scherb

Re: Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

e to do so and no control exists to prevent that. So, with or without my fix, this behaviour will be same for ImageIcon and Icon custom instances. Hope this clarifies the query. With Regards, Avik Niyogi > On 14-Jan-2016, at 11:36 am, Sergey Bylokhov <sergey.bylok...@oracle.com> >

Review Request of 8146321: [macosx] JInternalFrame frame icon in wrong position on Mac L if icon is not ImageIcon

null value for resized ImageIcon image was not well handled. Fix: All places in Aqua LAF where "instanceof Icon” (and not just ImageIcon class) is required, inputs were added after significant analyses. Check for null for getImage was done to remove a Null Pointer Exception. With Regards, Avik Niyogi

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, Please find code changes incorporating changes as suggested by inputs provided: http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8016665/webrev.02/> With Regards, Avik Niyogi > On 13-Jan-2016, at 11:38 pm, Sergey Bylokhov <

  1   2   >