Re: RFR: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable [v2]

On Mon, 6 Sep 2021 08:00:36 GMT, Prasanta Sadhukhan wrote: >> It is seen that if a JTabbedPane is unfocused, it's title is painted with >> **white** text on grey background >> as opposed to **black** text on grey background in unfoucsed native app on >> macOSX Catalina >> and is somewhat

Re: RFR: 8273375: Remove redundant 'new String' calls after concatenation in java.desktop

On Fri, 3 Sep 2021 07:53:21 GMT, Andrey Turbanov wrote: > Result of string concatenation is a newly created `String` object. There is > no need it wrap it in another `new String` call. > Such calls are confusing and produce warnings in IDE. Without them code is > easier to read. Link this PR

Re: RFR: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable

On Mon, 23 Aug 2021 12:32:20 GMT, Prasanta Sadhukhan wrote: > It is seen that if a JTabbedPane is unfocused, it's title is painted with > **white** text on grey background > as opposed to **black** text on grey background in unfoucsed native app on > macOSX Catalina > and is somewhat not

Re: RFR: 8271923: [macos] the text color on the selected disabled tabbed pane button remains white making text unreadable

On Mon, 23 Aug 2021 12:32:20 GMT, Prasanta Sadhukhan wrote: > It is seen that if a JTabbedPane is unfocused, it's title is painted with > **white** text on grey background > as opposed to **black** text on grey background in unfoucsed native app on > macOSX Catalina > and is somewhat not

Re: RFR: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aach64

On Mon, 9 Aug 2021 03:17:20 GMT, Phil Race wrote: > As per the bug comments, these tests fail too often on macOS arm. > This will be too noisy for CI. So I would like to problem list them for > mac-arm Marked as reviewed by jdv (Reviewer). - PR:

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v4]

On Thu, 5 Aug 2021 03:25:49 GMT, Yi Yang wrote: >> After JDK-8265518(#3615), it's possible to replace all variants of >> checkIndex by >> Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in >> the whole JDK codebase. >> >> As Mandy suggested, I create this PR for

Re: RFR: 6350025: API documentation for JOptionPane using deprecated methods.

On Mon, 2 Aug 2021 09:17:05 GMT, Prasanta Sadhukhan wrote: > The method show() in the JOptionPane javadoc example is deprecated. The > recommended method to call would be setVisible(true). Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4953

Re: RFR: 8270058: Use Objects.check{Index, FromIndexSize} for java.desktop [v3]

On Fri, 30 Jul 2021 08:40:34 GMT, Pankaj Bansal wrote: >> src/java.desktop/share/classes/javax/swing/JTabbedPane.java line 1793: >> >>> 1791: >>> 1792: private void checkIndex(int index) { >>> 1793: Objects.checkIndex(index, pages.size()); >> >> I think we should not replace IOOBE

Re: RFR: 8269269: [macos11] SystemIconTest fails with ClassCastException

On Wed, 14 Jul 2021 11:13:31 GMT, Alexander Zuev wrote: > Do not test situation where UIResource icon is returned > Added a whole bunch of debug information to see what file test is filed > upon. This issue is not specific to macOS 11, it is reproducible in my 10.15.7 also. Test fails with

Re: RFR: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS [v2]

On Tue, 4 May 2021 21:30:12 GMT, Alexander Zuev wrote: >> Fixed popup position taking into account its offset >> Added a lot of screenshots taking to better understand failures should they >> happen down the line > > Alexander Zuev has updated the pull request incrementally with one additional

Re: RFR: 8265291: Error in Javadoc for doAccessibleAction API in AccessibleJSlider class

On Sun, 2 May 2021 06:09:23 GMT, Pankaj Bansal wrote: > There is a small error in javadoc for doAccessibleAction function added in > AccessibleJSlider class under JDK-8262981. The documentation says that the > API returns true always, whereas it can return both true or false depending > upon

Re: RFR: 8265278: doc build fails after JDK-8262981

On Thu, 15 Apr 2021 13:51:57 GMT, Pankaj Bansal wrote: > The doc build fails after the JDK-8262981. The JDK-8262981 adds a new > function, but by mistake the param name used in function is different from > the param name mentioned in @param tag. This breaks the doc build. > > This change

Re: RFR: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java

On Fri, 22 Jan 2021 07:23:00 GMT, Prasanta Sadhukhan wrote: > This test was problemlisted for linux as it fails only on ubuntu18.04 in > mach5 nightly testing. It was infact passing on ubuntu19.10, 20.04 and 20.10 > so it was test specific issue. Made appropriate stability fix by adding >

Re: RFR: 8260035: Deproblemlist few problemlisted test

On Wed, 20 Jan 2021 11:49:25 GMT, Prasanta Sadhukhan wrote: > Few problemlisted test > javax/swing/plaf/basic/Test6984643.java > javax/swing/JMenuItem/6249972/bug6249972.java > javax/swing/JTree/6263446/bug6263446.java > were unstable in mach5 nightly testing. These can be deproblemlisted now

Re: RFR: 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"

On Sun, 17 Jan 2021 09:26:52 GMT, Alexander Zuev wrote: > 8259650: javax/swing/JComponent/7154030/bug7154030.java still fails with > "Exception: Failed to hide opaque button" Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2114

Re: RFR: 8258233: Reenable another fixed problemlisted test

On Mon, 14 Dec 2020 12:45:12 GMT, Prasanta Sadhukhan wrote: > javax/swing/JFileChooser/6868611/bug6868611.java was failing in windows in > mach5 testing but was fixed in JDK-8198004 later on, but this test was not > removed from problemList. We can remove it from problemlist now. > Tested for

Re: RFR: 8256713: SwingSet2 : Slider leaves tracks in uiScale=2

On Sun, 22 Nov 2020 08:59:48 GMT, Sergey Bylokhov wrote: > The problem became visible, when we draw a border across the component using > drawLine, and expected that fillRect will clear a border of the component. > This is incorrect because in the case of the scaled graphics(retina) some >

Integrated: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

On Tue, 3 Nov 2020 06:09:51 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and re

Re: RFR: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS [v2]

> This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and removed it from problemlist. There are > small tweaks in test also.

Integrated: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos

On Tue, 3 Nov 2020 05:48:13 GMT, Jayathirth D V wrote: > This issue is related to not giving permission for terminal to control things > in System Preferences -> Security & privacy -> Privacy -> Accessibility. > > I have verified the test in our CI and re

RFR: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS

This issue is related to not giving permission for terminal to control things in System Preferences -> Security & privacy -> Privacy -> Accessibility. I have verified the test in our CI and removed it from problemlist. There are small tweaks in test also. - Commit messages: -

RFR: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos

This issue is related to not giving permission for terminal to control things in System Preferences -> Security & privacy -> Privacy -> Accessibility. I have verified the test in our CI and removed it from problemlist. There are small tweaks in test also. - Commit messages: -

Re: RFR: 8196089: javax/swing/Action/8133039/bug8133039.java fails

On Mon, 2 Nov 2020 12:50:33 GMT, Prasanta Sadhukhan wrote: >> any comment on this review? > > ping? Looks like this is also related to giving permission to terminal in System Preferences -> Security & Privacy -> Privacy -> Accessibility. If we dont give permission the test fails.

Re: RFR: 8196089: javax/swing/Action/8133039/bug8133039.java fails

On Thu, 29 Oct 2020 12:11:33 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for an issue seen to be failing on mach5 systems due > to timing issue. > Adjusted the autoDelay time and moved the frame to center of screen. > Mach5 job has been run for several iterations in all

Re: RFR: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

On Thu, 29 Oct 2020 09:21:04 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to added delay() after frame is made visible and moved the > frame to centre of screen to be consistent

Re: RFR: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

On Mon, 2 Nov 2020 03:39:31 GMT, Jayathirth D V wrote: >> Please ask @jayathirthrao, who was able to reproduce this bug on the local >> system, about approval. > > I tested with or without fix in my local system with all the settings that we > do for jtreg tests but still

Re: RFR: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

On Thu, 29 Oct 2020 05:09:24 GMT, Prasanta Sadhukhan wrote: > Please review a test fix for a test issue seen to be failing on mach5 macos > systems due to timing issue. > Modified the test to modify setAutoDelay() time, added delay() after frame is > made visible and moved the frame to centre

Re: RFR: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

On Mon, 2 Nov 2020 03:39:18 GMT, Jayathirth D V wrote: >> Please ask @jayathirthrao, who was able to reproduce this bug on the local >> system, about approval. > > I tested with or without fix in my local system with all the settings that we > do for jtreg tests but still

Re: RFR: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos

On Thu, 29 Oct 2020 05:36:47 GMT, Sergey Bylokhov wrote: >> Please review a test fix for a test issue seen to be failing on mach5 macos >> systems due to timing issue. >> Modified the test to modify setAutoDelay() time, added delay() after frame >> is made visible and moved the frame to centre

Re: RFR: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

On Thu, 29 Oct 2020 23:26:58 GMT, Sergey Bylokhov wrote: >> Please review a test fix for a test issue seen to be failing on mach5 macos >> systems due to timing issue. >> Modified the test to added delay() after frame is made visible and moved the >> frame to centre of screen to be consistent

Re: Integrated: 8254141: Typo in copyright year

On Wed, 7 Oct 2020 07:08:47 GMT, Prasanta Sadhukhan wrote: > Fix typo in copyright Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/536

Re: RFR: 6646602: Spelling error in javadoc for javax.swing.tree.TreeModel

On Thu, 1 Oct 2020 07:49:59 GMT, Prasanta Sadhukhan wrote: > Fixed a typo in the documentation. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/453

Re: RFR: 6690021: typos in TransferHandler Javadoc

On Thu, 1 Oct 2020 07:43:07 GMT, Prasanta Sadhukhan wrote: > Fixed a typo removing superfluous ")" Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/452

Re: RFR: 8253792: javax.swing.text.GapContent documentation typos

On Wed, 30 Sep 2020 04:23:35 GMT, Prasanta Sadhukhan wrote: > Fixed some documentation typos Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/421

Re: RFR: 6441211: Small Error in API at javax.swing.plaf.synth.Region

On Tue, 29 Sep 2020 08:27:43 GMT, Prasanta Sadhukhan wrote: > Fixed a small typo Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/396

Re: RFR: 8251123: doclint warnings about missing javadoc tags and comments

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote: > We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even >

Re: RFR: 8253606: Need to add missed constructor to the SwingEventMonitor

On Thu, 24 Sep 2020 17:08:31 GMT, Sergey Bylokhov wrote: > The javadoc for the constructor in this class was added, but the constructor > itsef is missed.. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/340

Re: RFR: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac [v4]

On Sat, 26 Sep 2020 06:37:29 GMT, Tejpal Rebari wrote: >> The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for >> Mac OS X >> with the error message Popup was not shown on FileChooser. >> >> Popup doesn't appear for JFileChooser in MAC OS X platform so >> skipping this

Re: RFR: 8252194: Add automated test for fix done in JDK-8218469

On Sun, 27 Sep 2020 16:44:12 GMT, Pankaj Bansal wrote: > Under JDK-8218469, fix was made to correct the rendering of JSlider as the > Slider knob/head was not being rendered at > all. The reason was that gtk3 changed the way styles are used. No automated > test was written to verify the

Re: RFR: 8251123: doclint warnings about missing javadoc tags and comments

On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote: > We have a number of missing javadoc tags and comments in the desktop module. > Most of the missing comments are related to the serialized form. > > The fix: > - Adds missing comments to the non-static/non-transient fields(even >

Re: RFR 8249838: javax.swing.JLayeredPane has used valueOf twice in example code in documentation

+1. Thanks, Jay > On 06-Aug-2020, at 9:21 AM, Prasanta Sadhukhan > wrote: > > Hi All, > > Please review a doc fix where details section of JLayeredPane has used > valueOf twice as a typo > > Bug: https://bugs.openjdk.java.net/browse/JDK-8249838 >

Re: RFR: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac

And this should be pushed to JDK16 as we have already passed RDP1 of JDK15. Thanks, Jay > On 17-Jun-2020, at 11:49 AM, Jayathirth D v wrote: > > +1. > > Thanks, > Jay > >> On 31-May-2020, at 3:38 PM, Pankaj Bansal wrote: >> >> Hi All, >>

Re: RFR: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac

+1. Thanks, Jay > On 31-May-2020, at 3:38 PM, Pankaj Bansal wrote: > > Hi All, > > Please review the following test only fix for jdk15. > > Bug : https://bugs.openjdk.java.net/browse/JDK-8198623 > webrev: http://cr.openjdk.java.net/~pbansal/8198623/webrev00/ >

Re: RFR: 8233550: [TESTBUG] JTree tests fail regularly on MacOS

Looks good to me. Thanks, Jay > On 22-May-2020, at 1:08 PM, Pankaj Bansal wrote: > > https://bugs.openjdk.java.net/browse/JDK-8233550 >

RFR: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList

Hello All, Please review the following fix in JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8245165 Webrev : http://cr.openjdk.java.net/~jdv/8245165/webrev.00/ Fixing copy paste

Re: RFR: 8229856 [macos] Opening a menu on a JTextField can clear the text selection

Looks good to me. Thanks, Jay > On 06-May-2020, at 9:43 AM, Tejpal Rebari wrote: > > Hi Prasanta, > > >> On 22-Apr-2020, at 1:59 PM, Prasanta Sadhukhan >> mailto:prasanta.sadhuk...@oracle.com>> wrote: >> >> Hi Tejpal, >> >> Does it need to be triple click of any button or only left mouse

Re: RFR JDK-8208566: [TEST_BUG] javax\swing\text\GlyphPainter2\6427244\bug6427244.java: Test failed

+1. Thanks, Jay > On 29-Apr-2020, at 8:14 PM, Prasanta Sadhukhan > wrote: > > Hi All, > > This test was added to ProblemList few months back due to it failing on macOS > during nightly testing. > > But I tried with latest build on local mac and mach5 system (job detail in > JBS) where it

Re: RFR JDK-8232243:Wrong caret position in JTextPane on Windows with a screen resolution > 100%

+1. Thanks, Jay > On 29-Apr-2020, at 4:39 AM, Philip Race wrote: > > +1 from me. > > -phil. > > On 4/26/20, 9:13 PM, Prasanta Sadhukhan wrote: >> >> Sure..test updated... >> >> http://cr.openjdk.java.net/~psadhukhan/8232243/webrev.2/ >>

Re: RFR JDK-8169953:JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

+1. Thanks, Jay > On 28-Apr-2020, at 6:37 PM, Prasanta Sadhukhan > wrote: > > Hi All, > > This test was added to ProblemList due to it failing on windows and sometimes > on mac. > > But I have tried with latest build on local windows and mac system and also > on mach5 system (job detail

Re: RFR JDK-8226464:TitledBorder label appears cut off on hidpi devices

+1. Thanks, Jay > On 16-Apr-2020, at 4:44 PM, Sergey Bylokhov > wrote: > > Looks fine. > > On 4/15/20 8:32 pm, Prasanta Sadhukhan wrote: >> Yes, 8075918 fix also works ok with this fix as I can see. >> Regards >> Prasanta >> On 15-Apr-20 10:37 PM, Sergey Bylokhov wrote: >>> Hi, Prasanta. >>>

Re: RFR JDK-8178028: Typing 'C' cannot change the tab layout to WRAP_TAB_LAYOUT

Thanks for clarification. +1. Regards, Jay > On 22-Apr-2020, at 12:07 PM, Prasanta Sadhukhan > wrote: > > internal CI system is automated testing whereas this test is manual . > > Regards > Prasanta > On 22-Apr-20 12:05 PM, Jayathirth D v wrote: >> Looks good t

Re: RFR JDK-8178028: Typing 'C' cannot change the tab layout to WRAP_TAB_LAYOUT

Looks good to me if it is verified to pass in our internal CI system also. Thanks, Jay > On 17-Apr-2020, at 8:34 PM, Prasanta Sadhukhan > wrote: > > Hi All, > > Please review a test fix for an issue where it is seen that JTabbedPane > tabLayoutPolicy was not getting changed from

Re: RFR JDK-8233644, , [TESTBUG] JInternalFrame test bug8020708.java is failing on macos

+1. Thanks, Jay > On 16-Apr-2020, at 4:53 PM, Sergey Bylokhov > wrote: > > Looks fine. > > On 4/13/20 11:47 am, Prasanta Sadhukhan wrote: >> Hi All, >> The fix done for "8242526: PIT: >> javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu >> system" works for macOS

Re: RFR JDK-8213123:javax/swing/JButton/4368790/bug4368790.java fails on mac

+1. Thanks, Jay > On 09-Apr-2020, at 5:05 PM, Sergey Bylokhov > wrote: > > Looks fine. > > On 4/8/20 10:14 pm, Prasanta Sadhukhan wrote: >> Yes, other L does not have this bug as confirmed by updated test testing >> all installed L >> http://cr.openjdk.java.net/~psadhukhan/8213123/webrev.1/

Re: RFR: 8152332 [macosx] JFileChooser cannot be serialized on Mac OS X

+1. Regards, Jay > On 13-Apr-2020, at 6:33 PM, Sergey Bylokhov > wrote: > > On 4/12/20 7:37 am, Pankaj Bansal wrote: >> Looks good to me. > > Thank you. > >> One minor nit, don’t we need to add the current bug id to the test? > > Nope, that field mostly for the product bugs, which is

Re: RFR: 8238719 [macOS] Delete the property which use deprecated prefix "com.apple.macos."

Change looks good to me. Thanks, Jay > On 23-Mar-2020, at 11:50 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238719 > CSR: https://bugs.openjdk.java.net/browse/JDK-8238722 > Fix:

Re: RFR: 8241233 Typo in problem listing of UIDefaultKeySizeTest.java

Looks good to me. Thanks, Jay > On 19-Mar-2020, at 7:09 AM, Philip Race wrote: > > This is a bit of an oops but the fix > https://bugs.openjdk.java.net/browse/JDK-8241229 > included the "jdk/" parent directory in the path name of the file to be > excluded. > > bug:

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

+1. Thanks, Jay > On 13-Mar-2020, at 4:31 PM, Tejpal Rebari wrote: > > Hi Jay, >> On 13-Mar-2020, at 3:55 PM, Jayathirth D v > <mailto:jayathirth@oracle.com>> wrote: >> >> Hi Tejpal, >> >> Test case is not verifying all failure scenar

Re: RFR: 8146330 [macosx] UIDefaults.keys() different size than UIDefaults.keySet()

Hi Tejpal, Test case is not verifying all failure scenarios properly (If both test cases fail exception will be thrown only for first test failure) Make sure that you verify each test case failure and print appropriate message. Source change looks good to me. Thanks, Jay > On 13-Mar-2020, at

Re: RFR: 8219578 No associated icon for the leaf node of Jtree

Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; swing-dev@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf

Re: [15] RFR JDK-8222759: com.sun.java.swing.plaf.gtk.GTKLookAndFeel Unneccessary casts to GTKStyleFactory

gt; > > Regards, > Pankaj >   <> > From: Jayathirth D v > Sent: Monday, December 23, 2019 12:08 PM > To: Pankaj Bansal > Cc: swing-dev@openjdk.java.net > Subject: Re: [15] RFR JDK-8222759: > com.sun.java.swing.plaf.gtk.GTKLookAndFeel Unneccessary casts to >

Re: [15] RFR JDK-8222759: com.sun.java.swing.plaf.gtk.GTKLookAndFeel Unneccessary casts to GTKStyleFactory

Its better if we can make this test run only in Linux as GTK is specific to it. Other changes are fine. Thanks, Jay > On 20-Dec-2019, at 10:31 PM, Phil Race wrote: > > Looks fine. Please use the amended and corrected bug synopsis in the commit > message > > -phil. > > On 12/19/19 11:36 PM,

Re: [14] RFR JDK-7020860 - BasicTreeUI contains getters/setters with unclear spec

Hi Tejpal,   I think Sergey has given more inputs on the present change that you have at : http://mail.openjdk.java.net/pipermail/swing-dev/2016-October/006815.html and http://mail.openjdk.java.net/pipermail/swing-dev/2017-June/007495.html   Apart from this changes are fine.   Thanks, Jay

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

confirm that all of them release these keys on all code paths. > > @Phil : Yes we should use equalsIgnoreCase() that would be more cleaner > approach. I will update the webrev. > > Thanks, > Jay > >> On 08-Nov-2019, at 2:27 AM, Sergey Bylokhov > <mailto:sergey.byl

Re: [14] RFR JDK-8233986:ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64

Changes are fine. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 14, 2019 4:40 AM To: Prasanta Sadhukhan ; swing-dev@openjdk.java.net Subject: Re: [14] RFR JDK-8233986:ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for

Re: [14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

4:23 am, Jayathirth D V wrote: Solution : I tried many things like finding test cases where we might not be restoring the CAPS_LOCK state or using get/setLockingKeyState(). But they were not feasible solutions Why this solution does not work? so I am modifying the test cases which are

[14] RFR JDK-8233696:[TESTBUG]Some jtreg tests fail when CAPS_LOCK is ON

Hello All, Please review the following fix in JDK14: Bug : https://bugs.openjdk.java.net/browse/JDK-8233696 Webrev : http://cr.openjdk.java.net/~jdv/8233696/webrev.00/ Issue : State of CAPS_LOCK changes the way some of our jtreg tests behave. Solution : I tried many things like

Re: [14] JDK-8233583:ProblemList javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java & ShapedPerPixelTranslucentGradient.java failing incosist

Changes are fine.   Thanks, Jay   From: Prasanta Sadhukhan Sent: Tuesday, November 5, 2019 3:13 PM To: swing-dev@openjdk.java.net Subject: Re: [14] JDK-8233583:ProblemList javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java &

Re: [13] RFR 8224876:javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedPerPixelTranslucentGradient.java fails on linux-x64

Changes are fine but we should wait on Sergey's manual check of test in the system. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Monday, June 03, 2019 3:54 PM To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [13] RFR

Re: [12] RFR JDK-8213844: Typo in ProblemList updation under JDK-8213536

Changes are fine +1. Thanks, Jay From: Pankaj Bansal Sent: Wednesday, November 14, 2018 6:11 PM To: swing-dev@openjdk.java.net Subject: [12] RFR JDK-8213844: Typo in ProblemList updation under JDK-8213536 Hi All, Please review a fix for Typo done in ProblemList updation under

Re: [12] RFR JDK-8213138: Update ProblemList.txt for mac

Changes are fine.   Regards, Jay   From: Prasanta Sadhukhan Sent: Tuesday, October 30, 2018 3:28 PM To: awt-...@openjdk.java.net; swing-dev@openjdk.java.net; 2d-dev Subject: [12] RFR JDK-8213138: Update ProblemList.txt for mac   Hi All, Please review an updation of ProblemList for mac

[OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/ These are the test failures/errors which happen when they are run individually. All the failures/erros are

Re: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful

Hi Prasanta, Looks good to me. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Friday, August 10, 2018 10:50 AM To: swing-dev@openjdk.java.net Subject: [12] RFR JDK-8209343:Test javax/swing/border/TestTitledBorderLeak.java should be marked as headful Hi All, Please

Re: [12] RFR: JDK-8205535:Useless (or buggy) call to Math.round on int input

Hi Prasanta, Looks good to me. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Thursday, July 19, 2018 3:28 PM To: swing-dev@openjdk.java.net Subject: Re: [12] RFR: JDK-8205535:Useless (or buggy) call to Math.round on int input A correction on the fix. Correct

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

changes are fine. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Friday, June 15, 2018 2:02 PM To: Jayathirth D V; Philip Race Cc: swing-dev@openjdk.java.net Subject: Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen reso

Re: [11] RFR: JDK-8199441: Wrong caret position in multiline text components on Windows with a screen resolution higher than 100%

Hello Phil & Prasanta, Please find my observation: I went through the history of webrev's to understand what we are trying to do with respect to "round" value. It looks like the problem we have is : When we have floating point "view location" and "useFPAPI == true" whether to use round value

Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java is unstable

Hi Sergey, Thanks for the clarification. Changes are fine. Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, April 26, 2018 5:48 AM To: Jayathirth D V; swing-dev@openjdk.java.net Subject: Re: [11] Review Request: 8198342 Test FileSystemViewListenerLeak.java

Re: [11] JDK-8191957: JFileChooser shows empty name for external drives shown under Desktop

name for external drives shown under Desktop Hi Jay/Patrick, Thanks for the review. @jay << More inputs: <http://cr.openjdk.java.net/~pbansal/8191957/webrev.02/ Regards, Pankaj Bansal -Original Message- From: Jayathirth D V Sent: Wednesday, March 21, 2018 12:45 AM To: Pankaj Bansal;

Re: [11] JDK-8191957: JFileChooser shows empty name for external drives shown under Desktop

Hi Pankaj, More inputs: Since the test case is valid only when we have windows 10 system with some external drive making the test case manual is also a good idea. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Wednesday, March 21, 2018 12:06 AM To: Pankaj Bansal; swing-dev

Re: [11] JDK-8191957: JFileChooser shows empty name for external drives shown under Desktop

Hi Pankaj, I see that you have mentioned this bug is specific to Windows 10 and test case needs to be run with some Removable drive. It better to capture this information in test case also as a comment or in jtreg summary. In test case we have verification part like : if

Re: [11] RFR JDK-8186513:TESTBUG] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java

Hi Prasanta, Just doing setUndecorated(true) is making the test pass in my windows 7 system. Was there any specific problem in other platforms with respect to reading rgb value from the edge? Also the newly added println is fine but please add space between first and second argument which will

Re: [11] JDK-8190347: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentJComboBox.java fails

wait for more inputs from others before pushing the change. Thanks, Jay From: Pankaj Bansal Sent: Thursday, February 22, 2018 7:39 PM To: Jayathirth D V; swing-dev@openjdk.java.net; Sergey Bylokhov; Prasanta Sadhukhan Subject: RE: [11] JDK-8190347: [TESTBUG] Test javax/swing/JWindow

Re: [11] JDK-8190347: [TESTBUG] Test javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentJComboBox.java fails

Hi Pankaj, Please find my input: We need to update Copyright year, add new bug id in jtreg comment & it's better to keep jtreg comments before code for program starts like import statements. I think any one condition out of "(popup.getLocationOnScreen().y > ls.y"&

Re: [11] RFR JDK-8198004: javax/swing/JFileChooser/6868611/bug6868611.java throws error

nd then iterate only till that value, rather than 1000. Thanks, Krishna Message: 3 Date: Wed, 21 Feb 2018 22:04:32 -0800 (PST) From: Jayathirth D V <jayathirth@oracle.com> To: Semyon Sadetsky <semyon.sadet...@oracle.com>, swing-dev@openjdk.java.net Subject: Re: [11] RFR

Re: [11] RFR JDK-8198004: javax/swing/JFileChooser/6868611/bug6868611.java throws error

Hi Semyon, Thanks for your inputs. I have moved file deletion logic to finally block. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8198004/webrev.01/ Thanks, Jay From: Semyon Sadetsky Sent: Thursday, February 22, 2018 7:03 AM To: Jayathirth D V; swing

[11] RFR JDK-8198004: javax/swing/JFileChooser/6868611/bug6868611.java throws error

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8198004 Webrev : http://cr.openjdk.java.net/~jdv/8198004/webrev.00/ Issue: If we run javax/swing/JFileChooser/6868611/bug6868611.java it times out and throws jtreg error. Root

Re: [11] JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws error

Hi Prasanta, Changes are fine. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Wednesday, February 21, 2018 3:23 PM To: Jayathirth D V; Sergey Bylokhov; swing-dev@openjdk.java.net Subject: Re: [11] JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws

Re: [11] JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws error

To: Prasanta Sadhukhan; Jayathirth D V; swing-dev@openjdk.java.net Subject: Re: [11] JDK-8198005:javax/swing/JFileChooser/7199708/bug7199708.java throws error It seems it hangs even before the test starts: at java.io.WinNTFileSystem.createFileExclusively(java.base@11-internal/Native Method

Re: [11] Review Request: JDK-6481195 ListSelectionListener indicates events on model.addElement after model.clear()

Hi Pankaj, Changes are fine. Thanks, Jay From: Pankaj Bansal Sent: Tuesday, January 30, 2018 2:43 PM To: Jayathirth D V; swing-dev@openjdk.java.net; Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan Subject: RE: [11] Review Request: JDK-6481195 ListSelectionListener indicates

Re: [11] Review Request: JDK-7007967 DefaultRowSorter: incorrect sorting due to not updating comparator cache

Hi Pankaj, Changes are fine. Thanks, Jay From: Pankaj Bansal Sent: Tuesday, January 30, 2018 2:12 PM To: Jayathirth D V; swing-dev@openjdk.java.net; Sergey Bylokhov; Semyon Sadetsky Subject: RE: [11] Review Request: JDK-7007967 DefaultRowSorter: incorrect sorting due

Re: [11] Review Request: JDK-6481195 ListSelectionListener indicates events on model.addElement after model.clear()

. In test case this needs to be updated. There is no need for another webrev please update it before you push the change. Thanks, Jay From: Pankaj Bansal Sent: Monday, January 29, 2018 3:39 PM To: Jayathirth D V; swing-dev@openjdk.java.net; Sergey Bylokhov; Semyon Sadetsky; Prasanta

Re: [11] Review Request: JDK-7007967 DefaultRowSorter: incorrect sorting due to not updating comparator cache

e "Wrong sorting before ." and "Wrong sorting after .". Also in jtreg comments section maintain the indentation of multiline comment. Thanks, Jay From: Pankaj Bansal Sent: Monday, January 29, 2018 2:31 PM To: Jayathirth D V; swing-dev@openjdk.java.net; Sergey Bylokho

Re: [11] Review Request: JDK-7007967 DefaultRowSorter: incorrect sorting due to not updating comparator cache

Hello Pankaj, Please find my inputs: At line 1036 number of characters per line is more than 80, we can divide the conditions into multiple lines. 1036 if (!sorted || viewToModel.length == 0 || (lastRow - firstRow) > viewToModel.length / 10) { 1037 // We either

Re: [11] Review Request: JDK-6481195 ListSelectionListener indicates events on model.addElement after model.clear()

Hi Pankaj, Please find my inputs: Test case is working properly before and after changes. But I think we should make changes in test to actually detect all failure cases properly instead of throwing RuntimeException when we hit first failure: if (numberOfEvents > 2)

Re: [10][11][JDK-8194044] Regression manual Test javax/swing/JFileChooser/8067660/FileChooserTest.java fails

Hi Krishna, Changes are fine. Thanks, Jay From: Krishna Addepalli Sent: Wednesday, January 10, 2018 8:17 PM To: Jayathirth D V; swing-dev@openjdk.java.net Subject: RE: [10][11][JDK-8194044] Regression manual Test javax/swing/JFileChooser/8067660/FileChooserTest.java fails Hi

Re: [10][11][JDK-8194044] Regression manual Test javax/swing/JFileChooser/8067660/FileChooserTest.java fails

From: Krishna Addepalli Sent: Wednesday, January 10, 2018 6:00 PM To: Jayathirth D V; swing-dev@openjdk.java.net Subject: RE: [10][11][JDK-8194044] Regression manual Test javax/swing/JFileChooser/8067660/FileChooserTest.java fails Hi Jay, Thanks for your time and review. I have incorpora

Re: [10][11][JDK-8194044] Regression manual Test javax/swing/JFileChooser/8067660/FileChooserTest.java fails

Hi Krishna, Please find my inputs: Test case needs to be updated with minor changes: 1) Copyright information needs to be added at the start of test file. 2) Jtreg test summary needs to be updated to mention what the test is trying to achieve instead of JBS bug title. 3)

Re: [10] Review Request: JDK-7108280 : JList.getSelectedValuesList fails if JList.setSelectionInterval larger than list

Hello Pankaj, Please find my observation: As you have mentioned I also feel that adding check in setSelectionInterval() or addSelectionInterval() would be a good approach. Since I am not aware of swing component code I will leave this decision to others. Regarding