Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-13 Thread Sergey Bylokhov
Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description On 11/04/2018 02:55, Pankaj Bansal wrote: I have checked all the functions and I could not find any other API with wrong description. ok < This test will check that this method

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-12 Thread Pankaj Bansal
Hi Sergey, <http://cr.openjdk.java.net/~pbansal/8153532/webrev.02/ Regards, Pankaj Bansal -Original Message- From: Sergey Bylokhov Sent: Thursday, April 12, 2018 4:18 AM To: Pankaj Bansal; swing-dev@openjdk.java.net Subject: Re: [11][JDK-8153532] RFR: Add @throws NPE java

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-11 Thread Sergey Bylokhov
On 11/04/2018 02:55, Pankaj Bansal wrote: I have checked all the functions and I could not find any other API with wrong description. ok < This test will check that this method works according to its specification. Previously NPE was not specified and implementation of the method could

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-11 Thread Phil Race
jdk.java.net/%7Epbansal/8153532/webrev.01/> Regards, Pankaj Bansal *From:*Phil Race *Sent:* Thursday, April 12, 2018 12:08 AM *To:* Krishna Addepalli; Pankaj Bansal; swing-dev@openjdk.java.net *Subject:* Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) met

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-11 Thread Pankaj Bansal
: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description Can we change all occurrences of @exception -> @throws in this method ? In fact this method appears to be the only one in this class to use @exception so it is doubly anomalous. -phil. On 0

Re: [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-11 Thread Phil Race
nks, Krishna *From:* Pankaj Bansal *Sent:* Tuesday, April 10, 2018 4:27 PM *To:* swing-dev@openjdk.java.net *Subject:* [11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description Hi All, Please review a very simple fix for documentation change enhancement:

[11][JDK-8153532] RFR: Add @throws NPE javadoc to UIManager.setLookAndFeel(String) method description

2018-04-10 Thread Pankaj Bansal
Hi All, Please review a very simple fix for documentation change enhancement: JDK-8153532: https://bugs.openjdk.java.net/browse/JDK-8153532 Webrev: http://cr.openjdk.java.net/~pbansal/8153532/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8201363 UIManager.setLookAndFeel