Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2017-01-12 Thread alexander popov
Yep, its reasonable! Will fix that and update diff. On 1/11/2017 1:39 PM, Avik Niyogi wrote: Hi Alexander, The following is my input for this webrev: In case the LAF is Aqua, the check for combobox alignment is skipped. Instead, if default LAF is Aqua, the LAF should be changed to cross

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2017-01-11 Thread Avik Niyogi
Hi Alexander, The following is my input for this webrev: In case the LAF is Aqua, the check for combobox alignment is skipped. Instead, if default LAF is Aqua, the LAF should be changed to cross platform LAF to check if it works on other LAF or not. Either run this in a loop with checks for all

Fwd: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2016-12-26 Thread Alexander Popov
See new diffs here pls - http://cr.openjdk.java.net/~avstepan/8165207/webrev.02/ Sergey, failure could be reproduced on any OS X - just comment the following lines in my fix:   if (!UIManager.getLookAndFeel() .getName().toLowerCase().contains("os x"))

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2016-12-26 Thread Александр Попов
See new diffs here pls - http://cr.openjdk.java.net/~avstepan/8165207/webrev.02/ Sergey,failure could be reproduced on any OS X - just comment the following lines in my fix:  if (!UIManager.getLookAndFeel().getName().toLowerCase().contains("os x"))  old

Re: [9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2016-12-19 Thread Sergey Bylokhov
Hi, Alex. Can you please clarify on what versions of OS X and JDK the bug can be reproduced? Thanks. > > Hello, > review my changes please. > > Fix for https://bugs.openjdk.java.net/browse/JDK-8165207: > Webrev:http://cr.openjdk.java.net/~avstepan/8165207/webrev.01/ > Issue:

[9] Review request for 8165207: [macosx] Test javax/swing/Popup/TaskbarPositionTest.java fails on Mac 10.12

2016-12-19 Thread Александр Попов
Hello, review my changes please. Fix for https://bugs.openjdk.java.net/browse/JDK-8165207: Webrev:http://cr.openjdk.java.net/~avstepan/8165207/webrev.01/ Issue: https://bugs.openjdk.java.net/browse/JDK-8165207 This is a test bug. On Aqua LaF JCombobox popup could appear both upper label and